[GitHub] junichi11 opened a new pull request #982: New phpsigfiles

[GitBox <gi...@apache.org>]

junichi11 opened a new pull request #982: New phpsigfiles
URL: https://github.com/apache/incubator-netbeans/pull/982
 
 
   First of all, we can create this PR, definitely, thanks to @tmysik and @matthiasblaesing :)
   
   1. Merged the changes suggested by Matthias into this branch
   2. Generated the new sigfiles
   3. Fixed the license
       - Change the license of sigfiles to CC-BY-3.0 because they are generated from the PHP manual
       - Add the notice file
       - Sigfiles don't have license headers, instead, add the license and notice file to the zip file
   
   @matthiasblaesing 
   If my understanding is correct, we have to use the zip file because sigfiles license is CC-BY-3.0, right?
   I didn't add the license headers to the sigfiles, instead, added the license and the notice file(from you) to the zip file. Is this OK?
   If there is something having a problem, please let us know.
   
   Maybe, `http://netbeans.osuosl.org/binaries/` is not synchronized with `https://hg.netbeans.org/binaries/` yet. So this build would fail. If we would like to verify this soon, we have to add `-Dbinaries.server="https://hg.netbeans.org/binaries/"` option.
   
   zip: https://hg.netbeans.org/binaries/09ABCACCDE3E0F75127E84BBB18F92C0B2C6A5CEphpsigfiles-1.1.zip
   
   If there is no problem, let's merge this into the release100 branch too.
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists