You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by rip-nsk <gi...@git.apache.org> on 2017/12/06 01:29:21 UTC
[GitHub] orc pull request #198: Orc-272: Minor porting changes.
GitHub user rip-nsk opened a pull request:
https://github.com/apache/orc/pull/198
Orc-272: Minor porting changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rip-nsk/orc ORC-272
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #198
----
commit 65f47ec5d6bd7d2d32e03a1ea8ede8d4e3869c8b
Author: rip-nsk <ri...@gmail.com>
Date: 2017-12-05T23:35:48Z
fix the return type pf fls() prototype.
commit f4852f5abd0bbbf08518fe388f4f519e309bf7b6
Author: rip-nsk <ri...@gmail.com>
Date: 2017-12-05T23:41:04Z
alignment of arguments types for std::min
commit ac6df14ba0fe5cdefaac7dbb0ca7f2266e24ab8f
Author: rip-nsk <ri...@gmail.com>
Date: 2017-12-06T00:20:05Z
use LL suffix for int64 constants (or explicit cast)
commit 623f82b134ad13efb88e9e2fe39bb94feb606a67
Author: rip-nsk <ri...@gmail.com>
Date: 2017-12-06T00:21:22Z
Use heap to store big array.
commit 6ab81b971d91134544bfdbffa90da76fe47bf6c4
Author: rip-nsk <ri...@gmail.com>
Date: 2017-12-06T00:30:11Z
use std::numeric_limits<float>::max() for FLT_MAX
----
---
[GitHub] orc issue #198: Orc-272: Minor porting changes.
Posted by rip-nsk <gi...@git.apache.org>.
Github user rip-nsk commented on the issue:
https://github.com/apache/orc/pull/198
I don't think it is related to the proposed changes since io/InputStream.cc (and any headers) are not touched.
---
[GitHub] orc issue #198: Orc-272: Minor porting changes.
Posted by xndai <gi...@git.apache.org>.
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/198
LGTM
---
[GitHub] orc issue #198: Orc-272: [C++] Minor porting changes.
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/198
Ok, now that I have travis happy again, let me test this one out.
---
[GitHub] orc pull request #198: Orc-272: [C++] Minor porting changes.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/198
---
[GitHub] orc pull request #198: Orc-272: Minor porting changes.
Posted by wgtmac <gi...@git.apache.org>.
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/198#discussion_r155619755
--- Diff: c++/src/Int128.cc ---
@@ -22,6 +22,7 @@
#include <iomanip>
#include <iostream>
#include <sstream>
+#include <algorithm> // std::min
--- End diff --
nit: you may want to sort them alphabetically.
---
[GitHub] orc issue #198: Orc-272: Minor porting changes.
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/198
This patch works on MacOS, but fails on CentOS 6. In general, for this kind of change, I like to run the docker/run-all.sh on the patch. I get:
```
[ 42%] Building CXX object c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o
In file included from /root/orc/c++/src/io/InputStream.cc:19:
/root/orc/c++/include/orc/Exceptions.hh:31: error: expected ';' before 'noexcept'
/root/orc/c++/include/orc/Exceptions.hh:41: error: expected ';' before 'noexcept'
/root/orc/c++/include/orc/Exceptions.hh:51: error: expected ';' before 'noexcept'
make[2]: *** [c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o] Error 1
```
---