[GitHub] [incubator-devlake] likyh commented on a diff in pull request #3327: fix: fix sidebar href

[GitBox <gi...@apache.org>]

likyh commented on code in PR #3327:
URL: https://github.com/apache/incubator-devlake/pull/3327#discussion_r990988348


##########
config-ui/src/components/Sidebar/SidebarMenu.jsx:
##########
@@ -18,13 +18,25 @@
 import React, { useEffect, Fragment } from 'react'
 import { Menu } from '@blueprintjs/core'
 import '@/styles/sidebar-menu.scss'
+import { useHistory } from 'react-router-dom'
 
 const SidebarMenu = (props) => {
+  const history = useHistory()
   const { menu } = props
   // const activeRoute = useRouteMatch()
 
   useEffect(() => {}, [menu])
 
+  const handleProviderClick = (route) => {
+    if (route) {
+      if (route.includes('//')) {

Review Comment:
   URL contains `//` perhaps means it is an absolute URL. like `http://...../...`.  sometimes http(s) can be ellipsis to `//baidu.com/`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org