You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/16 14:24:24 UTC

[GitHub] [spark] cchighman commented on a change in pull request #28841: [SPARK-31962][SQL] Provide option to load files after a specified date when reading from a folder path

cchighman commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r440891685



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala
##########
@@ -176,9 +180,27 @@ object InMemoryFileIndex extends Logging {
   private[sql] def bulkListLeafFiles(
       paths: Seq[Path],
       hadoopConf: Configuration,
-      filter: PathFilter,
+      filters: ParArray[PathFilter],
       sparkSession: SparkSession,
       areRootPaths: Boolean): Seq[(Path, Seq[FileStatus])] = {
+    bulkListLeafFiles(paths, hadoopConf, filters, sparkSession, areRootPaths, Map[String, String]())

Review comment:
       Classes leveraging InMemoryFileIndex continue using the same interface for bulkListLeafFiles, no risk for backwards compatibility issues.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org