[GitHub] [arrow-rs] jhorstmann commented on a change in pull request #1449: Remove Clone and copy source structs internally

[GitBox <gi...@apache.org>]

jhorstmann commented on a change in pull request #1449:
URL: https://github.com/apache/arrow-rs/pull/1449#discussion_r835740249



##########
File path: arrow/src/ffi.rs
##########
@@ -781,11 +781,19 @@ impl ArrowArray {
                     .to_string(),
             ));
         };
-        let ffi_array = (*array).clone();
-        let ffi_schema = (*schema).clone();
+
+        let array_mut = array as *mut FFI_ArrowArray;
+        let schema_mut = schema as *mut FFI_ArrowSchema;
+
+        let array_data = std::ptr::replace(array_mut, FFI_ArrowArray::empty());

Review comment:
       I'm trying to catch up with these discussions since I'll soon have a need to create Buffers from foreign memory. The cast to `*mut` followed by `std::ptr::replace` here doesn't look safe to me. When the pointer is coming from an `Arc` that seems to violate rust's unique ownership rules.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org