You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/03/26 03:50:05 UTC
Review Request 32521: Sqoop-2256: Creator should have access to its
entities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32521/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
If the user is the owner/creator of this resource, then privilege will not be checked.
It is a hack code for the time being. The concept of "Owner" will be added in the future and this code will be removed.
Diffs
-----
security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java d261027ff5aefa728c5f761534f4439264b4ae45
Diff: https://reviews.apache.org/r/32521/diff/
Testing
-------
manual test
Thanks,
richard zhou
Re: Review Request 32521: Sqoop-2256: Creator should have access to
its entities
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32521/#review78145
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On March 26, 2015, 8:52 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32521/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 8:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> If the user is the owner/creator of this resource, then privilege will not be checked.
> It is a hack code for the time being. The concept of "Owner" will be added in the future and this code will be removed.
>
>
> Diffs
> -----
>
> security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java 333919d9e6895cd21c74c75eac8af16573632b75
>
> Diff: https://reviews.apache.org/r/32521/diff/
>
>
> Testing
> -------
>
> manual test
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 32521: Sqoop-2256: Creator should have access to
its entities
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32521/
-----------------------------------------------------------
(Updated March 26, 2015, 8:52 a.m.)
Review request for Sqoop.
Changes
-------
Avoid NPE for link.getCreationUser()
Repository: sqoop-sqoop2
Description
-------
If the user is the owner/creator of this resource, then privilege will not be checked.
It is a hack code for the time being. The concept of "Owner" will be added in the future and this code will be removed.
Diffs (updated)
-----
security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java 333919d9e6895cd21c74c75eac8af16573632b75
Diff: https://reviews.apache.org/r/32521/diff/
Testing
-------
manual test
Thanks,
richard zhou
Re: Review Request 32521: Sqoop-2256: Creator should have access to
its entities
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32521/
-----------------------------------------------------------
(Updated March 26, 2015, 5:07 a.m.)
Review request for Sqoop.
Changes
-------
Rebased the latest version, due to some conflict
Repository: sqoop-sqoop2
Description
-------
If the user is the owner/creator of this resource, then privilege will not be checked.
It is a hack code for the time being. The concept of "Owner" will be added in the future and this code will be removed.
Diffs (updated)
-----
security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java 333919d9e6895cd21c74c75eac8af16573632b75
Diff: https://reviews.apache.org/r/32521/diff/
Testing
-------
manual test
Thanks,
richard zhou
Re: Review Request 32521: Sqoop-2256: Creator should have access to
its entities
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32521/
-----------------------------------------------------------
(Updated March 26, 2015, 5 a.m.)
Review request for Sqoop.
Changes
-------
Add imports
Repository: sqoop-sqoop2
Description
-------
If the user is the owner/creator of this resource, then privilege will not be checked.
It is a hack code for the time being. The concept of "Owner" will be added in the future and this code will be removed.
Diffs (updated)
-----
security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java d261027ff5aefa728c5f761534f4439264b4ae45
Diff: https://reviews.apache.org/r/32521/diff/
Testing
-------
manual test
Thanks,
richard zhou