You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2026/09/01 11:17:30 UTC
[PR] [SPARK-59148][PYTHON][CONNECT][TEST][4.0] Skip test_nested_dataframes in the Spark Connect compatibility test [spark]
LuciferYang opened a new pull request, #58446:
URL: https://github.com/apache/spark/pull/58446
### What changes were proposed in this pull request?
Skip `StreamingForeachBatchParityTests.test_nested_dataframes` when `SPARK_SKIP_CONNECT_COMPAT_TESTS` is set.
### Why are the changes needed?
The Spark Connect compatibility jobs run this branch's `pyspark-connect` tests against a server built from `master`. The `pyspark-connect-old-client` job in `build_and_test.yml` and `build_python_connect40.yml` both clone `branch-4.0` for the client side.
https://github.com/apache/spark/pull/55410 (SPARK-44462) changes the server so the DataFrame handed to `foreachBatch` is bound to the session `StreamExecution` clones for the query, which is what classic `foreachBatch` already does. `test_nested_dataframes` creates a temp view from the batch DataFrame and reads it back through the client session, so against that server it fails:
```
File ".../connect/streaming/test_parity_foreach_batch.py", line 49, in test_nested_dataframes
collected = self.spark.sql("select * from batch_updates").collect()
pyspark.errors.exceptions.connect.AnalysisException: [TABLE_OR_VIEW_NOT_FOUND] The table or view `batch_updates` cannot be found.
```
Failing run: https://github.com/LuciferYang/spark/actions/runs/33346837991/job/99354964415
The assertion holds for a 4.0 server, so the guard is scoped to the compatibility jobs and this branch's own CI keeps running the test. SPARK-52077 skipped `ArrowUDTFParityTests` the same way.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
`test_nested_dataframes` still runs with `SPARK_SKIP_CONNECT_COMPAT_TESTS` unset and is skipped with it set to `1`. This branch's CI cannot exercise the case the guard is for, since it runs against a 4.0 server; the `pyspark-connect-old-client` job on https://github.com/apache/spark/pull/55410 is what verifies it, once this lands.
Pass GitHub Actions.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59148][PYTHON][CONNECT][TEST][4.0] Skip test_nested_dataframes in the Spark Connect compatibility test [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #58446:
URL: https://github.com/apache/spark/pull/58446#issuecomment-5504655370
**Merge Summary:**
- merged into branch-4.0 https://github.com/apache/spark/commit/4e5431e50da4b21887ed1016afccee3bc241fa33
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59148][PYTHON][CONNECT][TEST][4.0] Skip test_nested_dataframes in the Spark Connect compatibility test [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #58446: [SPARK-59148][PYTHON][CONNECT][TEST][4.0] Skip test_nested_dataframes in the Spark Connect compatibility test
URL: https://github.com/apache/spark/pull/58446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59148][PYTHON][CONNECT][TEST][4.0] Skip test_nested_dataframes in the Spark Connect compatibility test [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #58446:
URL: https://github.com/apache/spark/pull/58446#issuecomment-5504661768
Thank you @HyukjinKwon @uros-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org