You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "voonhous (via GitHub)" <gi...@apache.org> on 2026/04/21 13:42:04 UTC
[PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
voonhous opened a new pull request, #18540:
URL: https://github.com/apache/hudi/pull/18540
### Describe the issue this Pull Request addresses
`INSERT INTO` on a table with a Hudi custom logical type column (e.g. `VECTOR(n)`, `BLOB`) fails:
```
SchemaBackwardsCompatibilityException: MISSING_UNION_BRANCH:
reader union lacking writer type: VECTOR for field: '<table>_record.<col>'
```
**Root cause**:
Spark's `TableOutputResolver.resolveOutputColumns` wraps each INSERT output in `Alias(Cast(input, expected.dataType), ...)`. `Cast` drops `StructField.metadata`, which strips the `HoodieSchema.TYPE_METADATA_FIELD` (`hudi_type`) marker that tags the column as VECTOR / BLOB. By the time `InsertIntoHoodieTableCommand.run` hits `sparkSession.internalCreateDataFrame(query.execute(), query.schema)`, the source `StructType` no longer carries the marker. `HoodieSparkSqlWriter` then emits plain Avro `array<float>` / `bytes` via `convertStructTypeToHoodieSchema(df.schema, ...)`, which no longer matches the VECTOR/BLOB `fixed` branch persisted in `tableCreateSchema`, so the schema compat check rejects the write.
### Summary and Changelog
SQL `INSERT INTO` now works for VECTOR and BLOB columns.
Changes:
- New helper `HoodieSchemaConversionUtils.enrichWithCustomTypeMetadata(sourceSchema, targetSchema)`: for each source field whose matching target field carries `HoodieSchema.TYPE_METADATA_FIELD`, copies that metadata key back onto the source field.
- `InsertIntoHoodieTableCommand.run` (both `hudi-spark3-common` and `hudi-spark4-common`): calls the helper with `catalogTable.tableSchemaWithoutMetaFields` before building the DataFrame, so downstream `convertStructTypeToHoodieSchema(df.schema, ...)` regenerates the correct custom Avro type.
- `TestCreateTable`: the existing VECTOR persistence test now also runs `INSERT INTO ... VALUES (...)` and expects success. Renamed to `"VECTOR column persists as VECTOR in Hudi tableCreateSchema and supports INSERT INTO"`.
### Impact
Public API: adds one helper on `HoodieSchemaConversionUtils`, no existing signatures changed.
Behavior: fixes a broken write path. No change to on disk format or to the persisted `tableCreateSchema`.
Perf: one name keyed map lookup per top level field before `internalCreateDataFrame`. No row level work.
### Risk Level
low
Scope is the SQL INSERT path. Fields without the `hudi_type` marker on the target schema are returned unchanged, so non custom type tables are untouched. Row data already matches the backing physical layout, so row serialization is not modified.
Verified:
- New test: `INSERT INTO ... VALUES (array(cast(0.1 as float), ...))` against `VECTOR(3)` completes without `MISSING_UNION_BRANCH`.
- Existing VECTOR CREATE and READ assertions in `TestCreateTable.scala` still pass.
### Documentation Update
none
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Enough context is provided in the sections above
- [x] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322634684
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.78%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 67.78% -1.10%
+ Complexity 28532 28066 -466
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
- Hits 94244 92941 -1303
- Misses 34982 36503 +1521
- Partials 7584 7661 +77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.83% <41.37%> (-6.65%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.11% <70.68%> (-0.18%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [213 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322648853
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 68.88% 68.89% +0.01%
- Complexity 28532 28580 +48
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
+ Hits 94244 94465 +221
- Misses 34982 35020 +38
- Partials 7584 7620 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.45% <43.10%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3143731092
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestCreateTable.scala:
##########
@@ -2333,4 +2333,96 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
val hiveSchema = CreateHoodieTableCommand.toHiveCompatibleSchema(schema)
assertEquals(ArrayType(FloatType, containsNull = false), hiveSchema("floats").dataType)
}
+
+ test("VECTOR column persists as VECTOR in Hudi tableCreateSchema and allows INSERT INTO") {
+ withTempDir { tmp =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
+ |CREATE TABLE $tableName (
+ | id BIGINT,
+ | embedding VECTOR(3)
+ |) USING hudi
+ |LOCATION '${tmp.getCanonicalPath}'
+ |TBLPROPERTIES (
+ | primaryKey = 'id'
+ |)
+ """.stripMargin)
+
+ val metaClient = createMetaClient(spark, tmp.getCanonicalPath)
+ val persistedOpt = metaClient.getTableConfig.getTableCreateSchema
+ assertTrue(persistedOpt.isPresent, "tableCreateSchema should be present")
+ val persisted = persistedOpt.get()
+ val embedding = persisted.getField("embedding").get().schema().getNonNullType()
+ assertEquals(HoodieSchemaType.VECTOR, embedding.getType)
+ assertEquals(3, embedding.asInstanceOf[HoodieSchema.Vector].getDimension)
+
+ spark.sql(s"""
+ INSERT INTO $tableName VALUES
+ (1, array(cast(0.1 as float), cast(0.2 as float), cast(0.3 as float))),
+ (2, array(cast(0.4 as float), cast(0.5 as float), cast(0.6 as float)))
+ """)
+ }
Review Comment:
@voonhous for your tests after adding data can you run one SELECT * query and assert expected values?
Can you do this for tests in `TestMergeIntoTable` and in `TestUpdateTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322411237
@yihua to take one pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3143058019
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +146,103 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
Review Comment:
Let's try to use multi-line selects next time.
<img width="620" height="229" alt="image" src="https://github.com/user-attachments/assets/9e17e404-7c4b-4402-945c-c1e8b513de66" />
This is not showing everything...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321451697
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.38%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (4a72e7f). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (4a72e7f) |
>|------|------|------|
>|spark-scala-tests|10|6|
>|spark-java-tests|14|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 55.38% -13.51%
+ Complexity 28532 19234 -9298
=============================================
Files 2479 2019 -460
Lines 136810 113625 -23185
Branches 16660 14523 -2137
=============================================
- Hits 94244 62929 -31315
- Misses 34982 44171 +9189
+ Partials 7584 6525 -1059
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.97% <20.68%> (-16.52%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <70.68%> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `70.66% <53.57%> (-8.65%)` | :arrow_down: |
... and [1378 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321447854
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.32%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (4a72e7f). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (4a72e7f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.32% -20.57%
+ Complexity 28532 16753 -11779
=============================================
Files 2479 2019 -460
Lines 136810 113625 -23185
Branches 16660 14523 -2137
=============================================
- Hits 94244 54910 -39334
- Misses 34982 52776 +17794
+ Partials 7584 5939 -1645
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.36% <20.68%> (-16.13%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <53.44%> (-12.41%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1542 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311696706
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.00%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.00% -0.89%
+ Complexity 28532 28149 -383
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 93075 -1169
- Misses 34982 36144 +1162
- Partials 7584 7643 +59
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <43.10%> (-3.93%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294185145
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.16667%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.83%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 67.87% 67.83% -0.05%
+ Complexity 28025 27995 -30
============================================
Files 2475 2475
Lines 136566 136604 +38
Branches 16611 16625 +14
============================================
- Hits 92699 92664 -35
- Misses 36308 36357 +49
- Partials 7559 7583 +24
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <33.33%> (-0.19%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <79.16%> (+0.02%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
... and [42 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295892156
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.69%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-java-tests|15|6|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 63.69% -5.16%
+ Complexity 28462 21813 -6649
============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
============================================
- Hits 94041 72105 -21936
+ Misses 34977 34157 -820
+ Partials 7562 6938 -624
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.79% <28.12%> (-6.64%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [1086 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294083803
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `33.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.31%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 33.33% | [9 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (69b7c97). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (69b7c97) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 45.81% 39.31% -6.51%
+ Complexity 14827 12342 -2485
============================================
Files 1951 1953 +2
Lines 105721 105695 -26
Branches 12730 12779 +49
============================================
- Hits 48434 41550 -6884
- Misses 52314 59268 +6954
+ Partials 4973 4877 -96
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.38% <33.33%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `53.27% <33.33%> (-6.26%)` | :arrow_down: |
... and [684 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294093995
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `33.33333%` with `16 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.85%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 33.33% | [9 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 48.35% 45.85% -2.50%
+ Complexity 16317 14828 -1489
============================================
Files 1986 1953 -33
Lines 110550 105719 -4831
Branches 13858 12798 -1060
============================================
- Hits 53452 48481 -4971
- Misses 51557 52283 +726
+ Partials 5541 4955 -586
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.38% <33.33%> (+0.05%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `54.62% <33.33%> (-10.85%)` | :arrow_down: |
... and [454 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289441074
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.00000%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.39%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 40.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (59fee58) and HEAD (34b7555). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (59fee58) | HEAD (34b7555) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 63.39% -5.47%
+ Complexity 28449 26111 -2338
============================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
============================================
- Hits 93985 86534 -7451
- Misses 34953 42956 +8003
+ Partials 7561 7019 -542
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.66% <40.00%> (-6.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <40.00%> (-12.90%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.02% <40.00%> (-4.41%)` | :arrow_down: |
... and [399 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289488437
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.54%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.54% -0.31%
+ Complexity 28449 28263 -186
============================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
============================================
- Hits 93985 93574 -411
- Misses 34953 35481 +528
+ Partials 7561 7454 -107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.08% <40.00%> (-0.33%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.00% <90.00%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [47 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4290934522
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.85%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.85% -0.01%
- Complexity 28449 28459 +10
============================================
Files 2475 2475
Lines 136499 136523 +24
Branches 16594 16597 +3
============================================
+ Hits 93985 94000 +15
- Misses 34953 34966 +13
+ Partials 7561 7557 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.43% <40.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <90.00%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303859488
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.82% -0.03%
+ Complexity 28468 28458 -10
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16652 +18
============================================
+ Hits 94112 94115 +3
- Misses 35008 35061 +53
- Partials 7571 7573 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.40% <32.43%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <62.16%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308078754
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.91%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 65.91% -2.94%
+ Complexity 28468 27269 -1199
============================================
Files 2477 2478 +1
Lines 136691 136737 +46
Branches 16634 16653 +19
============================================
- Hits 94112 90136 -3976
- Misses 35008 38958 +3950
- Partials 7571 7643 +72
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <20.68%> (-17.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <70.68%> (-0.29%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `71.11% <53.57%> (-8.20%)` | :arrow_down: |
... and [387 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303536241
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.77%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 44.77% -24.08%
+ Complexity 28468 8510 -19958
=============================================
Files 2477 1200 -1277
Lines 136691 62477 -74214
Branches 16634 6754 -9880
=============================================
- Hits 94112 27974 -66138
+ Misses 35008 31445 -3563
+ Partials 7571 3058 -4513
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2078 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306804703
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `61.76471%` with `26 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.37%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 72.22% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 54.37% -14.48%
+ Complexity 28468 18545 -9923
=============================================
Files 2477 2017 -460
Lines 136691 113330 -23361
Branches 16634 14464 -2170
=============================================
- Hits 94112 61623 -32489
- Misses 35008 45272 +10264
+ Partials 7571 6435 -1136
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <38.23%> (-17.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <55.88%> (-12.89%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.97% <21.42%> (-17.34%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `71.01% <72.22%> (-0.42%)` | :arrow_down: |
... and [1405 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306808047
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `61.76471%` with `26 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.23%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 72.22% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 61.23% -7.62%
+ Complexity 28468 25278 -3190
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16659 +25
============================================
- Hits 94112 83733 -10379
- Misses 35008 45888 +10880
+ Partials 7571 7128 -443
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <38.23%> (-17.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <55.88%> (-12.89%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.38% <21.42%> (-15.94%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `71.01% <72.22%> (-0.42%)` | :arrow_down: |
... and [556 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306985784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 06a7f9e8333a73e73b3c1487b1629cd3f1013cc8 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306899791
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.64706%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.65%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 77.77% | [4 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 28.57% | [0 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.65% -1.20%
+ Complexity 28468 27914 -554
============================================
Files 2477 2478 +1
Lines 136691 136763 +72
Branches 16634 16661 +27
============================================
- Hits 94112 92521 -1591
- Misses 35008 36729 +1721
+ Partials 7571 7513 -58
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.49% <44.11%> (-3.94%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <66.17%> (-0.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.52% <28.57%> (-2.79%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.91% <77.77%> (+2.48%)` | :arrow_up: |
... and [187 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307665066
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 06a7f9e8333a73e73b3c1487b1629cd3f1013cc8 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491)
* 839ee5166867c465f7c5d72872a101e26736fe92 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495)
* 288aad1b3d8f8ae825841f3a56b1b2cccff761ba UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4302537939
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.77% -0.09%
+ Complexity 28462 28399 -63
============================================
Files 2475 2475
Lines 136580 136597 +17
Branches 16613 16627 +14
============================================
- Hits 94041 93941 -100
- Misses 34977 35102 +125
+ Partials 7562 7554 -8
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.38% <31.25%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303316939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475)
* d3c9220ef21705582d43471b21a6df685ea4d0e9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305514787
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `43.24324%` with `21 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.51%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 55.17% | [7 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [0 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (266cbd9). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (266cbd9) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 48.51% -20.34%
+ Complexity 28468 16352 -12116
=============================================
Files 2477 2000 -477
Lines 136691 110881 -25810
Branches 16634 13912 -2722
=============================================
- Hits 94112 53790 -40322
- Misses 35008 51446 +16438
+ Partials 7571 5645 -1926
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.39% <27.02%> (-16.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <40.54%> (-12.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `52.85% <0.00%> (-26.46%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `62.83% <55.17%> (-8.60%)` | :arrow_down: |
... and [1551 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305502301
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.54054%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.84%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 51.72% | [7 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [0 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (266cbd9). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (266cbd9) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 46.84% -22.01%
+ Complexity 28468 15138 -13330
=============================================
Files 2477 1954 -523
Lines 136691 105870 -30821
Branches 16634 12764 -3870
=============================================
- Hits 94112 49594 -44518
- Misses 35008 51111 +16103
+ Partials 7571 5165 -2406
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.22% <40.54%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `51.90% <0.00%> (-27.41%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `38.05% <51.72%> (-33.38%)` | :arrow_down: |
... and [1631 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306827186
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.17647%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.69%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 77.77% | [4 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 65.69% -3.16%
+ Complexity 28468 27127 -1341
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16659 +25
============================================
- Hits 94112 89831 -4281
- Misses 35008 39365 +4357
+ Partials 7571 7553 -18
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <38.23%> (-17.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.55% <66.17%> (-0.76%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `68.54% <21.42%> (-10.77%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.91% <77.77%> (+2.48%)` | :arrow_up: |
... and [389 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305857891
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 266cbd9e50951dde68b23c4adc9d9742ffb01ae9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295962717
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.42%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 66.42% -2.43%
+ Complexity 28462 22992 -5470
============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
============================================
- Hits 94041 75197 -18844
+ Misses 34977 31335 -3642
+ Partials 7562 6668 -894
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.29% <31.25%> (-0.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [830 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295915950
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.22%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 65.22% -3.64%
+ Complexity 28462 22557 -5905
============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
============================================
- Hits 94041 73833 -20208
+ Misses 34977 32629 -2348
+ Partials 7562 6738 -824
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.60% <31.25%> (-3.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [943 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295936423
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.32%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 66.32% -2.53%
+ Complexity 28462 22939 -5523
============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
============================================
- Hits 94041 75084 -18957
+ Misses 34977 31450 -3527
+ Partials 7562 6666 -896
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.06% <31.25%> (-0.36%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [842 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3127476301
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,72 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach custom Hudi logical-type metadata (e.g. VECTOR, BLOB) from `targetSchema` onto
+ * matching fields of `sourceSchema`. Spark's TableOutputResolver wraps write-path outputs in
+ * Cast(...) (and UPDATE assignments go through castIfNeeded), both of which drop the
+ * StructField metadata that marks these custom types. Without re-attaching, downstream
+ * conversion to HoodieSchema yields the backing physical type (e.g. plain ARRAY for VECTOR,
+ * plain STRUCT for BLOB) and the schema-compat check against the persisted
+ * tableCreateSchema fails.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType - the shapes where BLOB can legally be nested. Fields
+ * without a matching target (source-only columns such as MERGE join keys) are returned
+ * unchanged.
+ *
+ * @param sourceSchema the schema whose fields may have lost custom-type metadata
+ * @param targetSchema the catalog schema that owns the authoritative metadata
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def reattachCustomTypeMetadata(sourceSchema: StructType,
+ targetSchema: StructType,
+ caseSensitive: Boolean): StructType = {
+ val targetByName: Map[String, StructField] =
Review Comment:
🤖 nit: `targetByName` re-implements the `caseSensitive → toLowerCase` logic that `lookupKey` already captures, but because `lookupKey` is declared after it, it can't be reused. Could you swap the two `val`s so `lookupKey` comes first? Then `targetByName` simplifies to `targetSchema.fields.map(f => lookupKey(f.name) -> f).toMap` and there's no duplicated branching to keep in sync.
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303394611
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `62.50000%` with `12 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.43%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 66.43% -2.42%
+ Complexity 28468 27352 -1116
============================================
Files 2477 2477
Lines 136691 136722 +31
Branches 16634 16650 +16
============================================
- Hits 94112 90834 -3278
- Misses 35008 38514 +3506
+ Partials 7571 7374 -197
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.46% <25.00%> (-8.91%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.87% <62.50%> (-1.45%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `60.95% <12.50%> (-18.36%)` | :arrow_down: |
... and [293 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306663069
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 266cbd9e50951dde68b23c4adc9d9742ffb01ae9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485)
* b6235e1eef6740d98ea9cc72490bb731f9d8e1de Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488)
* 06a7f9e8333a73e73b3c1487b1629cd3f1013cc8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305256316
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4729eef1a150bf906ccb01b5943fc3903ab3adb0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479)
* 266cbd9e50951dde68b23c4adc9d9742ffb01ae9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3131670004
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,86 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Align `sourceSchema` with the authoritative `targetSchema` (the catalog table schema)
+ * along two dimensions that Spark's write-path rewrites strip away:
+ *
+ * 1. Custom Hudi logical-type metadata (VECTOR, BLOB). TableOutputResolver's Cast(...)
+ * and UPDATE's castIfNeeded drop the StructField metadata that marks these types;
+ * without re-attaching, downstream conversion yields the backing physical type
+ * (plain ARRAY for VECTOR, plain STRUCT for BLOB) and the schema-compat check fails
+ * with MISSING_UNION_BRANCH.
+ * 2. Nullability. The resolved query schema typically marks every column nullable
+ * (VALUES literals and Cast outputs are nullable by default), which diverges from
+ * the catalog's declared nullability (e.g. primaryKey columns are non-null). Since
+ * the rebuilt schema becomes the DataFrame's schema, and therefore the writer's
+ * Avro schema, leaving source nullability in place produces a writer/reader mismatch
+ * like writer=["null","long"] vs reader="long" and fails the compat check.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType. Fields without a matching target (source-only columns such
+ * as MERGE join keys) are returned unchanged.
+ *
+ * @param sourceSchema the schema produced by the query (may have lost metadata and may
+ * carry over-permissive nullability)
+ * @param targetSchema the catalog schema that owns the authoritative metadata and
+ * nullability
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def alignSchemaWithCatalog(sourceSchema: StructType,
+ targetSchema: StructType,
+ caseSensitive: Boolean): StructType = {
+ val targetByName: Map[String, StructField] =
+ if (caseSensitive) {
+ targetSchema.fields.map(f => f.name -> f).toMap
+ } else {
+ targetSchema.fields.map(f => f.name.toLowerCase -> f).toMap
+ }
+ val lookupKey: String => String =
+ if (caseSensitive) identity else (_: String).toLowerCase
+
+ StructType(sourceSchema.fields.map { field =>
+ targetByName.get(lookupKey(field.name)) match {
+ case Some(target) => alignField(field, target, caseSensitive)
+ case None => field
+ }
+ })
+ }
+
+ private def alignField(source: StructField,
+ target: StructField,
+ caseSensitive: Boolean): StructField = {
+ val withNestedDataType = (source.dataType, target.dataType) match {
+ case (s: StructType, t: StructType) =>
+ source.copy(
+ dataType = alignSchemaWithCatalog(s, t, caseSensitive),
Review Comment:
🤖 `alignField` unconditionally copies `target.nullable` onto the source, which *narrows* nullable→non-null when the catalog field is non-null. For INSERT/UPDATE Spark's resolver asserts non-null before we get here, so the RDD should never actually hold nulls on those columns — but the MERGE path passes the raw `sourceDF` here (pre-assignment), where a source expression may legitimately be nullable even when the matching target column is non-null. Would it be safer to only widen (i.e. `nullable = source.nullable || target.nullable`) and rely on Spark's downstream null assertions to fail cleanly, rather than relabeling a schema that may not match the underlying InternalRows? A mislabeled non-null schema over rows that actually contain nulls could surface as an AvroRuntimeException at write time or, worse, affect any reader path that trusts `StructField.nullable`.
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,86 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Align `sourceSchema` with the authoritative `targetSchema` (the catalog table schema)
+ * along two dimensions that Spark's write-path rewrites strip away:
+ *
+ * 1. Custom Hudi logical-type metadata (VECTOR, BLOB). TableOutputResolver's Cast(...)
+ * and UPDATE's castIfNeeded drop the StructField metadata that marks these types;
+ * without re-attaching, downstream conversion yields the backing physical type
+ * (plain ARRAY for VECTOR, plain STRUCT for BLOB) and the schema-compat check fails
+ * with MISSING_UNION_BRANCH.
+ * 2. Nullability. The resolved query schema typically marks every column nullable
+ * (VALUES literals and Cast outputs are nullable by default), which diverges from
+ * the catalog's declared nullability (e.g. primaryKey columns are non-null). Since
+ * the rebuilt schema becomes the DataFrame's schema, and therefore the writer's
+ * Avro schema, leaving source nullability in place produces a writer/reader mismatch
+ * like writer=["null","long"] vs reader="long" and fails the compat check.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType. Fields without a matching target (source-only columns such
+ * as MERGE join keys) are returned unchanged.
+ *
+ * @param sourceSchema the schema produced by the query (may have lost metadata and may
+ * carry over-permissive nullability)
+ * @param targetSchema the catalog schema that owns the authoritative metadata and
+ * nullability
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def alignSchemaWithCatalog(sourceSchema: StructType,
Review Comment:
🤖 nit: `lookupKey` is defined after `targetByName` but encodes exactly the transformation used to build it. Could you swap the order — define `lookupKey` first, then collapse the if/else here to `targetSchema.fields.map(f => lookupKey(f.name) -> f).toMap`?
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,86 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Align `sourceSchema` with the authoritative `targetSchema` (the catalog table schema)
+ * along two dimensions that Spark's write-path rewrites strip away:
+ *
+ * 1. Custom Hudi logical-type metadata (VECTOR, BLOB). TableOutputResolver's Cast(...)
+ * and UPDATE's castIfNeeded drop the StructField metadata that marks these types;
+ * without re-attaching, downstream conversion yields the backing physical type
+ * (plain ARRAY for VECTOR, plain STRUCT for BLOB) and the schema-compat check fails
+ * with MISSING_UNION_BRANCH.
+ * 2. Nullability. The resolved query schema typically marks every column nullable
+ * (VALUES literals and Cast outputs are nullable by default), which diverges from
+ * the catalog's declared nullability (e.g. primaryKey columns are non-null). Since
+ * the rebuilt schema becomes the DataFrame's schema, and therefore the writer's
+ * Avro schema, leaving source nullability in place produces a writer/reader mismatch
+ * like writer=["null","long"] vs reader="long" and fails the compat check.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType. Fields without a matching target (source-only columns such
+ * as MERGE join keys) are returned unchanged.
+ *
+ * @param sourceSchema the schema produced by the query (may have lost metadata and may
+ * carry over-permissive nullability)
+ * @param targetSchema the catalog schema that owns the authoritative metadata and
+ * nullability
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def alignSchemaWithCatalog(sourceSchema: StructType,
+ targetSchema: StructType,
+ caseSensitive: Boolean): StructType = {
+ val targetByName: Map[String, StructField] =
+ if (caseSensitive) {
+ targetSchema.fields.map(f => f.name -> f).toMap
+ } else {
+ targetSchema.fields.map(f => f.name.toLowerCase -> f).toMap
+ }
+ val lookupKey: String => String =
+ if (caseSensitive) identity else (_: String).toLowerCase
+
+ StructType(sourceSchema.fields.map { field =>
+ targetByName.get(lookupKey(field.name)) match {
+ case Some(target) => alignField(field, target, caseSensitive)
+ case None => field
+ }
+ })
+ }
+
+ private def alignField(source: StructField,
Review Comment:
🤖 nit: `withNestedDataType` names a `StructField`, but reads like a `DataType`. Something like `fieldWithAlignedType` or `alignedField` might make it easier to follow the two-step build-up (align nested type → enrich metadata) at a quick scan.
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308147815
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.79%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.79% -0.06%
+ Complexity 28468 28443 -25
============================================
Files 2477 2478 +1
Lines 136691 136737 +46
Branches 16634 16653 +19
============================================
- Hits 94112 94074 -38
- Misses 35008 35100 +92
+ Partials 7571 7563 -8
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.03% <43.10%> (-0.40%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [41 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294148599
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f104c57b7539e59468aea3171f531fdd0e70f980 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430)
* 69b7c9779c03f08f664eeb8d6c79395886db883c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295872718
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.61%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-java-tests|15|6|
>|spark-scala-tests|10|7|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 63.61% -5.24%
+ Complexity 28462 21772 -6690
============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
============================================
- Hits 94041 72013 -22028
+ Misses 34977 34242 -735
+ Partials 7562 6945 -617
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.79% <28.12%> (-6.64%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <62.50%> (-0.29%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [1107 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295844060
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.12500%` with `15 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.59%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-java-tests|15|5|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 54.59% -14.26%
+ Complexity 28462 18655 -9807
=============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
=============================================
- Hits 94041 61802 -32239
- Misses 34977 44888 +9911
+ Partials 7562 6510 -1052
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <25.00%> (-17.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <53.12%> (-12.43%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `70.37% <70.83%> (-1.06%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `58.09% <0.00%> (-21.22%)` | :arrow_down: |
... and [1401 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295871164
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd7672c304cdf9889be3fb0c797651a69053e39c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303303093
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.90%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|9|1|
>|spark-java-tests|5|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 66.07% 46.90% -19.17%
+ Complexity 27351 15159 -12192
=============================================
Files 2477 1953 -524
Lines 136691 105789 -30902
Branches 16634 12811 -3823
=============================================
- Hits 90315 49621 -40694
- Misses 38733 51016 +12283
+ Partials 7643 5152 -2491
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.29% <56.25%> (-12.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `42.59% <70.83%> (-28.84%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `51.90% <12.50%> (-19.04%)` | :arrow_down: |
... and [1524 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4293551383
Added tests for UPDATE/DELETE/MERGE-INTO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4296090357
The failing tests will be fixed in The failing tests is fixed in #18538, so please merge the aforementioned PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289166017
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.78%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (59fee58) and HEAD (34b7555). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (59fee58) | HEAD (34b7555) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|13|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 44.78% -24.07%
+ Complexity 28448 8503 -19945
=============================================
Files 2475 1198 -1277
Lines 136499 62350 -74149
Branches 16594 6733 -9861
=============================================
- Hits 93983 27923 -66060
+ Misses 34954 31376 -3578
+ Partials 7562 3051 -4511
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2077 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289048532
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34b7555383976f932baa24bc0631fb610924cf9d Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311615971
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.79%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|14|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.79% -20.10%
+ Complexity 28532 16472 -12060
=============================================
Files 2479 1988 -491
Lines 136810 110820 -25990
Branches 16660 13931 -2729
=============================================
- Hits 94244 54072 -40172
- Misses 34982 51037 +16055
+ Partials 7584 5711 -1873
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <20.68%> (-16.50%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <50.00%> (-12.28%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `66.66% <60.00%> (-4.77%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.77% <39.28%> (-25.54%)` | :arrow_down: |
... and [1556 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311624980
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.94%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 58.94% -9.94%
+ Complexity 28532 24463 -4069
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 80677 -13567
- Misses 34982 49113 +14131
+ Partials 7584 7072 -512
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.20% <20.68%> (-17.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <53.44%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.55% <46.42%> (-15.76%)` | :arrow_down: |
... and [661 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4312669476
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.88%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=========================================
Coverage 68.88% 68.88%
+ Complexity 28532 28519 -13
=========================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
=========================================
+ Hits 94244 94280 +36
- Misses 34982 34986 +4
- Partials 7584 7596 +12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.49% <43.10%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4338500774
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.90%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 18 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 68.88% 68.90% +0.01%
- Complexity 28532 28580 +48
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
+ Hits 94244 94467 +223
- Misses 34982 35018 +36
- Partials 7584 7620 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.51% <43.10%> (+0.03%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [30 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311302609
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.82% -0.07%
+ Complexity 28532 28471 -61
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 94193 -51
- Misses 34982 35087 +105
+ Partials 7584 7582 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.07% <43.10%> (-0.42%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.06%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [34 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311282388
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.99%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 67.99% -0.89%
+ Complexity 28532 28132 -400
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 93064 -1180
- Misses 34982 36170 +1188
- Partials 7584 7628 +44
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.59% <43.10%> (-3.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.26% <70.68%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [161 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303790974
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.89%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.89% -0.96%
+ Complexity 28468 28068 -400
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16652 +18
============================================
- Hits 94112 92846 -1266
- Misses 35008 36294 +1286
- Partials 7571 7609 +38
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <32.43%> (-4.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <62.16%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [177 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321446218
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.95%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (4a72e7f). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (4a72e7f) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 45.95% -22.93%
+ Complexity 28532 15587 -12945
=============================================
Files 2479 1989 -490
Lines 136810 111002 -25808
Branches 16660 13962 -2698
=============================================
- Hits 94244 51016 -43228
- Misses 34982 54477 +19495
+ Partials 7584 5509 -2075
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <50.00%> (-12.35%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `43.85% <60.00%> (-27.57%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.77% <39.28%> (-25.54%)` | :arrow_down: |
... and [1606 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321541069
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
}, {
"hash" : "873d4aefc68214948ee600469ed64e6d20e48004",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529",
"triggerID" : "873d4aefc68214948ee600469ed64e6d20e48004",
"triggerType" : "PUSH"
}, {
"hash" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530",
"triggerID" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"triggerType" : "PUSH"
}, {
"hash" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604",
"triggerID" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3143731092
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestCreateTable.scala:
##########
@@ -2333,4 +2333,96 @@ class TestCreateTable extends HoodieSparkSqlTestBase {
val hiveSchema = CreateHoodieTableCommand.toHiveCompatibleSchema(schema)
assertEquals(ArrayType(FloatType, containsNull = false), hiveSchema("floats").dataType)
}
+
+ test("VECTOR column persists as VECTOR in Hudi tableCreateSchema and allows INSERT INTO") {
+ withTempDir { tmp =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
+ |CREATE TABLE $tableName (
+ | id BIGINT,
+ | embedding VECTOR(3)
+ |) USING hudi
+ |LOCATION '${tmp.getCanonicalPath}'
+ |TBLPROPERTIES (
+ | primaryKey = 'id'
+ |)
+ """.stripMargin)
+
+ val metaClient = createMetaClient(spark, tmp.getCanonicalPath)
+ val persistedOpt = metaClient.getTableConfig.getTableCreateSchema
+ assertTrue(persistedOpt.isPresent, "tableCreateSchema should be present")
+ val persisted = persistedOpt.get()
+ val embedding = persisted.getField("embedding").get().schema().getNonNullType()
+ assertEquals(HoodieSchemaType.VECTOR, embedding.getType)
+ assertEquals(3, embedding.asInstanceOf[HoodieSchema.Vector].getDimension)
+
+ spark.sql(s"""
+ INSERT INTO $tableName VALUES
+ (1, array(cast(0.1 as float), cast(0.2 as float), cast(0.3 as float))),
+ (2, array(cast(0.4 as float), cast(0.5 as float), cast(0.6 as float)))
+ """)
+ }
Review Comment:
@voonhous for your tests after adding data can you run one SELECT * query and assert expected values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322617740
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.40%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (48694ab). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (48694ab) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 61.40% -7.49%
+ Complexity 28532 25470 -3062
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
- Hits 94244 84185 -10059
- Misses 34982 45686 +10704
+ Partials 7584 7234 -350
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.16% <20.68%> (-17.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `64.00% <46.42%> (-15.32%)` | :arrow_down: |
... and [550 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4293878963
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.77%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f104c57`](https://app.codecov.io/gh/apache/hudi/commit/f104c57b7539e59468aea3171f531fdd0e70f980?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (59fee58) and HEAD (f104c57). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (59fee58) | HEAD (f104c57) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 44.77% -24.09%
+ Complexity 28449 8502 -19947
=============================================
Files 2475 1198 -1277
Lines 136499 62383 -74116
Branches 16594 6738 -9856
=============================================
- Hits 93985 27929 -66056
+ Misses 34953 31403 -3550
+ Partials 7561 3051 -4510
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2077 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303296678
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `32 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.01%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [24 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|8|0|
>|spark-java-tests|5|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 65.96% 54.01% -11.95%
+ Complexity 27280 12365 -14915
=============================================
Files 2477 1430 -1047
Lines 136691 71551 -65140
Branches 16634 8116 -8518
=============================================
- Hits 90165 38648 -51517
+ Misses 38936 29448 -9488
+ Partials 7590 3455 -4135
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `16.66% <0.00%> (-54.27%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.48% <0.00%> (-64.95%)` | :arrow_down: |
... and [1746 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294187858
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.16667%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.83%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 67.97% 67.83% -0.14%
+ Complexity 28093 27995 -98
============================================
Files 2475 2475
Lines 136580 136604 +24
Branches 16613 16625 +12
============================================
- Hits 92838 92664 -174
- Misses 36133 36357 +224
+ Partials 7609 7583 -26
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <33.33%> (-0.19%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <79.16%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
... and [47 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303377402
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.94%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.84% 60.94% -7.91%
+ Complexity 28468 25106 -3362
============================================
Files 2477 2477
Lines 136691 136722 +31
Branches 16634 16650 +16
============================================
- Hits 94110 83326 -10784
- Misses 35010 46392 +11382
+ Partials 7571 7004 -567
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.28% <25.00%> (-17.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <56.25%> (-13.55%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `55.71% <12.50%> (-23.60%)` | :arrow_down: |
... and [557 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303388842
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `62.50000%` with `12 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.40%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.84% 65.40% -3.45%
+ Complexity 28468 26960 -1508
============================================
Files 2477 2477
Lines 136691 136722 +31
Branches 16634 16650 +16
============================================
- Hits 94110 89428 -4682
- Misses 35010 39867 +4857
+ Partials 7571 7427 -144
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.28% <25.00%> (-17.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.87% <62.50%> (-1.45%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `60.95% <12.50%> (-18.36%)` | :arrow_down: |
... and [392 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289481421
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.70%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.70% -1.15%
+ Complexity 28449 27915 -534
============================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
============================================
- Hits 93985 92426 -1559
- Misses 34953 36569 +1616
+ Partials 7561 7514 -47
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.96% <40.00%> (-6.45%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.00% <90.00%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [184 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289495145
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.67%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.67% -0.19%
+ Complexity 28449 28336 -113
============================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
============================================
- Hits 93985 93741 -244
- Misses 34953 35258 +305
+ Partials 7561 7510 -51
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.08% <40.00%> (-0.33%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.18% <90.00%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [36 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3121598861
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,30 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach custom Hudi logical-type metadata (e.g. VECTOR, BLOB) from `targetSchema` onto
+ * matching fields of `sourceSchema`, by name. Spark's TableOutputResolver wraps INSERT outputs
+ * in Cast(...) which drops the StructField metadata that marks these custom types. Without
+ * re-attaching, downstream conversion to HoodieSchema yields the backing physical type
+ * (e.g. plain ARRAY) and the schema-compat check against the persisted tableCreateSchema fails.
+ */
+ def enrichWithCustomTypeMetadata(sourceSchema: StructType, targetSchema: StructType): StructType = {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294123599
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.63%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 61.16% 58.63% -2.53%
+ Complexity 25243 24237 -1006
============================================
Files 2475 2475
Lines 136566 136590 +24
Branches 16611 16623 +12
============================================
- Hits 83526 80093 -3433
- Misses 46011 49542 +3531
+ Partials 7029 6955 -74
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <33.33%> (+0.78%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <70.83%> (+0.48%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-0.80%)` | :arrow_down: |
... and [253 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303017383
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd7672c304cdf9889be3fb0c797651a69053e39c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437)
* a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303616884
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d3c9220ef21705582d43471b21a6df685ea4d0e9 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477)
* 4729eef1a150bf906ccb01b5943fc3903ab3adb0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303725564
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.98%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 58.98% -9.87%
+ Complexity 28468 24456 -4012
============================================
Files 2477 2478 +1
Lines 136691 136735 +44
Branches 16634 16650 +16
============================================
- Hits 94112 80649 -13463
- Misses 35008 49022 +14014
+ Partials 7571 7064 -507
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <27.02%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <54.05%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.33% <12.50%> (-15.98%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.02% <65.51%> (-2.41%)` | :arrow_down: |
... and [667 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321395889
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
}, {
"hash" : "873d4aefc68214948ee600469ed64e6d20e48004",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529",
"triggerID" : "873d4aefc68214948ee600469ed64e6d20e48004",
"triggerType" : "PUSH"
}, {
"hash" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530",
"triggerID" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"triggerType" : "PUSH"
}, {
"hash" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604",
"triggerID" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530)
* 4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4302576204
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.77% -0.09%
+ Complexity 28462 28399 -63
============================================
Files 2475 2475
Lines 136580 136597 +17
Branches 16613 16627 +14
============================================
- Hits 94041 93941 -100
- Misses 34977 35102 +125
+ Partials 7562 7554 -8
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.38% <31.25%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295864242
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.34%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-java-tests|15|6|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 58.34% -10.52%
+ Complexity 28462 19949 -8513
=============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
=============================================
- Hits 94041 66045 -27996
- Misses 34977 40611 +5634
+ Partials 7562 6544 -1018
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.79% <28.12%> (-6.64%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <53.12%> (-12.43%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `71.29% <70.83%> (-0.14%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `72.38% <12.50%> (-6.93%)` | :arrow_down: |
... and [1265 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306801853
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `61.76471%` with `26 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.11%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 72.22% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 54.11% -14.74%
+ Complexity 28468 18470 -9998
=============================================
Files 2477 2017 -460
Lines 136691 113330 -23361
Branches 16634 14464 -2170
=============================================
- Hits 94112 61325 -32787
- Misses 35008 45650 +10642
+ Partials 7571 6355 -1216
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <38.23%> (-16.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <55.88%> (-12.89%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.97% <21.42%> (-17.34%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `71.01% <72.22%> (-0.42%)` | :arrow_down: |
... and [1411 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311592978
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.41%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 46.41% -22.48%
+ Complexity 28532 15352 -13180
=============================================
Files 2479 1971 -508
Lines 136810 108454 -28356
Branches 16660 13417 -3243
=============================================
- Hits 94244 50339 -43905
- Misses 34982 52789 +17807
+ Partials 7584 5326 -2258
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <50.00%> (-12.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `42.10% <60.00%> (-29.33%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.33% <39.28%> (-25.98%)` | :arrow_down: |
... and [1621 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311204386
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.76%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|14|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.76% -20.13%
+ Complexity 28532 16470 -12062
=============================================
Files 2479 1988 -491
Lines 136810 110820 -25990
Branches 16660 13931 -2729
=============================================
- Hits 94244 54041 -40203
- Misses 34982 51061 +16079
+ Partials 7584 5718 -1866
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.37% <20.68%> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <50.00%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `66.66% <60.00%> (-4.77%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.77% <39.28%> (-25.54%)` | :arrow_down: |
... and [1555 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4304296173
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4729eef1a150bf906ccb01b5943fc3903ab3adb0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305652763
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.89%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.89% -0.96%
+ Complexity 28468 28067 -401
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16649 +15
============================================
- Hits 94112 92851 -1261
- Misses 35008 36260 +1252
- Partials 7571 7638 +67
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.64% <32.43%> (-3.80%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <62.16%> (-0.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [180 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305718808
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.81%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.81% -0.04%
+ Complexity 28468 28461 -7
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16649 +15
============================================
- Hits 94112 94100 -12
- Misses 35008 35080 +72
+ Partials 7571 7569 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <32.43%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <62.16%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307271030
Note to self, in a bug fix, we should always be fixing the specific issue raised.
If someone says: have you tested this and that, pushback and use this PR as an example of what will happen if we try considering other cases to cover.
Do not chase for perfection with a PR. PRs are meant to be incremental. As can be seen with this PR, by adding in the other tests... Look what it has become.
1. It killed the momentum.
2. Issues are no longer isolated.
3. Instead of fixing 1 issue and we move on to another, the issue that is fixed is blocked by 2 other issues that is sitting of this PR.
So... Whoever is always trying to add scope to a PR... Point them to this PR as an example of why:
<img width="498" height="498" alt="image" src="https://github.com/user-attachments/assets/8b82a72c-c4dd-46e6-82e7-7dd08c1613bf" />
is the correct answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311229143
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.94%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 58.94% -9.94%
+ Complexity 28532 24464 -4068
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 80680 -13564
- Misses 34982 49110 +14128
+ Partials 7584 7072 -512
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.20% <20.68%> (-17.29%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.55% <46.42%> (-15.76%)` | :arrow_down: |
... and [661 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311723962
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.88%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.88% -0.01%
+ Complexity 28532 28517 -15
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
+ Hits 94244 94274 +30
- Misses 34982 34991 +9
- Partials 7584 7597 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <43.10%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303818007
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.80%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.80% -0.05%
+ Complexity 28468 28450 -18
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16652 +18
============================================
- Hits 94112 94094 -18
- Misses 35008 35085 +77
+ Partials 7571 7570 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <32.43%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <62.16%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [25 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306907260
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.64706%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.75%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 77.77% | [4 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 28.57% | [0 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.75% -1.10%
+ Complexity 28468 27970 -498
============================================
Files 2477 2478 +1
Lines 136691 136777 +86
Branches 16634 16663 +29
============================================
- Hits 94112 92669 -1443
- Misses 35008 36561 +1553
+ Partials 7571 7547 -24
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.62% <44.11%> (-3.81%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <66.17%> (-0.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.52% <28.57%> (-2.79%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.91% <77.77%> (+2.48%)` | :arrow_up: |
... and [180 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306950899
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.64706%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.63%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 77.77% | [4 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 28.57% | [0 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.63% -0.22%
+ Complexity 28468 28342 -126
============================================
Files 2477 2478 +1
Lines 136691 136777 +86
Branches 16634 16663 +29
============================================
- Hits 94112 93876 -236
- Misses 35008 35407 +399
+ Partials 7571 7494 -77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <44.11%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <66.17%> (-0.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.52% <28.57%> (-2.79%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.91% <77.77%> (+2.48%)` | :arrow_up: |
... and [48 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308066527
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.45%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (288aad1). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (288aad1) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 61.45% -7.40%
+ Complexity 28468 25420 -3048
============================================
Files 2477 2478 +1
Lines 136691 136737 +46
Branches 16634 16653 +19
============================================
- Hits 94112 84030 -10082
- Misses 35008 45480 +10472
+ Partials 7571 7227 -344
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <20.68%> (-17.21%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <53.44%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `64.00% <46.42%> (-15.32%)` | :arrow_down: |
... and [546 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308025643
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 57.68%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (288aad1). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (288aad1) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 57.68% -11.17%
+ Complexity 28468 23489 -4979
=============================================
Files 2477 2449 -28
Lines 136691 134118 -2573
Branches 16634 16093 -541
=============================================
- Hits 94112 77362 -16750
- Misses 35008 50035 +15027
+ Partials 7571 6721 -850
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <50.00%> (-12.34%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `43.85% <60.00%> (-27.57%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `55.55% <39.28%> (-23.76%)` | :arrow_down: |
... and [725 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3143060057
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -278,10 +282,22 @@ object HoodieSparkSchemaConverters extends SparkAdapterSupport {
metadataBuilder.putString(HoodieSchema.TYPE_METADATA_FIELD, HoodieSchema.Blob.TYPE_DESCRIPTOR)
}
val metadata = metadataBuilder.build()
- StructField(f.name(), schemaType.dataType, schemaType.nullable, metadata)
+ // For BLOB: force nullable-everywhere at the Spark type layer. The RFC-100
Review Comment:
Uhm, KIV this please, i have encountered quite a bit of errors around this.This is not a 1-day ordeal. Let's take more time to look into this after 1.2 as i've found that Spark3.3,3.4,3.5 and 4.0 have different schema validation/check flows.
And i have encountered quite abit of errors around this error which i had to fix and patch.
Agree that we should file an issue here and find the best way forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321456937
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.84%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 65.84% -3.05%
+ Complexity 28532 27300 -1232
============================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
============================================
- Hits 94244 90241 -4003
- Misses 34982 39147 +4165
- Partials 7584 7659 +75
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.17% <20.68%> (-17.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <70.68%> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `71.11% <53.57%> (-8.20%)` | :arrow_down: |
... and [389 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321512432
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
==========================================
Coverage 68.88% 68.89%
- Complexity 28532 28575 +43
==========================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
==========================================
+ Hits 94244 94420 +176
- Misses 34982 35013 +31
- Partials 7584 7614 +30
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.44% <43.10%> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <70.68%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321513707
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
==========================================
Coverage 68.88% 68.89%
- Complexity 28532 28575 +43
==========================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
==========================================
+ Hits 94244 94420 +176
- Misses 34982 35013 +31
- Partials 7584 7614 +30
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.47% <43.10%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <70.68%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3143829436
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -373,14 +420,25 @@ object HoodieSparkSchemaConverters extends SparkAdapterSupport {
* Validates that a StructType matches the expected unshredded variant schema
* (two non-null {@code BinaryType} fields: {@code metadata} and {@code value}).
*
+ * Note on nullability: unlike BLOB, VARIANT is not projected nullable-everywhere at the
+ * Spark type layer because the user-facing path is gated. Spark 3.x rejects VARIANT at
+ * schema resolution, and Spark 4.0+ exposes it as the native {@code VariantType} populated
+ * via {@code parse_json(...)}, never a user-supplied {@code named_struct}. The internal
+ * physical layout ({@code struct<metadata, value>} with non-null fields) only appears
+ * through {@link HoodieSparkSchemaConverters#toSqlType}, which produces the canonical
+ * non-null shape this validator expects.
+ *
* @param structType the StructType to validate
* @throws IllegalArgumentException if the structure does not match the expected variant schema
*/
private def validateVariantStructure(structType: StructType): Unit = {
- val fieldsByName = structType.fields.map(f => f.name -> f).toMap
+ val caseSensitive = SQLConf.get.caseSensitiveAnalysis
+ val key: String => String =
+ if (caseSensitive) identity else (_: String).toLowerCase(Locale.ROOT)
+ val fieldsByName = structType.fields.map(f => key(f.name) -> f).toMap
val ok = structType.length == 2 &&
- fieldsByName.get(HoodieSchema.Variant.VARIANT_METADATA_FIELD).exists(f => f.dataType == BinaryType && !f.nullable) &&
- fieldsByName.get(HoodieSchema.Variant.VARIANT_VALUE_FIELD).exists(f => f.dataType == BinaryType && !f.nullable)
+ fieldsByName.get(key(HoodieSchema.Variant.VARIANT_METADATA_FIELD)).exists(f => f.dataType == BinaryType && !f.nullable) &&
+ fieldsByName.get(key(HoodieSchema.Variant.VARIANT_VALUE_FIELD)).exists(f => f.dataType == BinaryType && !f.nullable)
Review Comment:
_⚠️ Potential issue_ | _🟠 Major_
**Reject reordered VARIANT physical structs.**
This validator only checks for two named binary fields via a map, so `struct<value: binary, metadata: binary>` currently passes. The documented canonical layout is `struct<metadata: binary, value: binary>`, and Spark rows are positional, so accepting reordered fields can corrupt the metadata/value swap on write.
<details>
<summary>🔧 Suggested fix</summary>
```diff
private def validateVariantStructure(structType: StructType): Unit = {
val caseSensitive = SQLConf.get.caseSensitiveAnalysis
- val key: String => String =
- if (caseSensitive) identity else (_: String).toLowerCase(Locale.ROOT)
- val fieldsByName = structType.fields.map(f => key(f.name) -> f).toMap
- val ok = structType.length == 2 &&
- fieldsByName.get(key(HoodieSchema.Variant.VARIANT_METADATA_FIELD)).exists(f => f.dataType == BinaryType && !f.nullable) &&
- fieldsByName.get(key(HoodieSchema.Variant.VARIANT_VALUE_FIELD)).exists(f => f.dataType == BinaryType && !f.nullable)
+ val expectedFields = expectedVariantStructType.fields
+ val ok = structType.length == expectedFields.length &&
+ structType.fields.zip(expectedFields).forall { case (actual, expected) =>
+ nameEquals(actual.name, expected.name, caseSensitive) &&
+ actual.dataType == expected.dataType &&
+ actual.nullable == expected.nullable
+ }
if (!ok) {
throw new IllegalArgumentException(
s"""Invalid variant schema structure. Expected schema:
```
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify each finding against the current code and only fix it if needed.
In
`@hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala`
around lines 434 - 441, The validator validateVariantStructure currently accepts
any two-field binary struct by name lookup, which allows reordered physical
structs like struct<value: binary, metadata: binary>; update
validateVariantStructure to enforce the canonical positional layout by checking
structType.fields length == 2 and then validating that the first field (apply
case-sensitive keying using SQLConf.get.caseSensitiveAnalysis and the key
function) has name equal to HoodieSchema.Variant.VARIANT_METADATA_FIELD and is
BinaryType non-nullable, and the second field has name equal to
HoodieSchema.Variant.VARIANT_VALUE_FIELD and is BinaryType non-nullable (do not
rely on a fieldsByName map for this check).
```
</details>
<!-- fingerprinting:phantom:medusa:grasshopper:35812c3a-9e4a-4e1e-bd5e-a4a34016e80a -->
<!-- 4e71b3a2 -->
<!-- This is an auto-generated comment by CodeRabbit -->
— *CodeRabbit* ([original](https://github.com/hudi-agent/hudi/pull/15#discussion_r3143071733)) (source:comment#3143071733)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322612705
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.41%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (48694ab). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (48694ab) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.41% -20.48%
+ Complexity 28532 16792 -11740
=============================================
Files 2479 2021 -458
Lines 136810 113683 -23127
Branches 16660 14542 -2118
=============================================
- Hits 94244 55040 -39204
- Misses 34982 52713 +17731
+ Partials 7584 5930 -1654
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.57% <20.68%> (-16.91%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1542 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322604042
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.83%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (48694ab). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (48694ab) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 46.83% -22.05%
+ Complexity 28532 15198 -13334
=============================================
Files 2479 1956 -523
Lines 136810 106171 -30639
Branches 16660 12899 -3761
=============================================
- Hits 94244 49729 -44515
- Misses 34982 51274 +16292
+ Partials 7584 5168 -2416
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <50.00%> (-12.08%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `41.22% <60.00%> (-30.21%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `52.44% <39.28%> (-26.87%)` | :arrow_down: |
... and [1650 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295761750
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.62500%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.84%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 54.16% | [4 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 39.84% -29.01%
+ Complexity 28462 12469 -15993
=============================================
Files 2475 1951 -524
Lines 136580 105752 -30828
Branches 16613 12746 -3867
=============================================
- Hits 94041 42136 -51905
- Misses 34977 58529 +23552
+ Partials 7562 5087 -2475
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <40.62%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `48.57% <0.00%> (-30.74%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `37.96% <54.16%> (-33.47%)` | :arrow_down: |
... and [1839 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295768790
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.62500%` with `19 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.78%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 54.16% | [4 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-java-tests|15|0|
>|spark-scala-tests|10|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 46.78% -22.08%
+ Complexity 28462 15118 -13344
=============================================
Files 2475 1951 -524
Lines 136580 105752 -30828
Branches 16613 12746 -3867
=============================================
- Hits 94041 49475 -44566
- Misses 34977 51115 +16138
+ Partials 7562 5162 -2400
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.16% <40.62%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `49.04% <0.00%> (-30.27%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `37.96% <54.16%> (-33.47%)` | :arrow_down: |
... and [1631 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295836339
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.12500%` with `15 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.37%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-java-tests|15|4|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 48.37% -20.49%
+ Complexity 28462 16709 -11753
=============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
=============================================
- Hits 94041 54758 -39283
- Misses 34977 52542 +17565
+ Partials 7562 5900 -1662
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <25.00%> (-16.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <53.12%> (-12.43%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `70.37% <70.83%> (-1.06%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `57.14% <0.00%> (-22.17%)` | :arrow_down: |
... and [1536 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295971878
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.44%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 66.44% -2.42%
+ Complexity 28462 23000 -5462
============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
============================================
- Hits 94041 75213 -18828
+ Misses 34977 31316 -3661
+ Partials 7562 6671 -891
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <31.25%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [832 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4290460472
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.84%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.84% -0.01%
- Complexity 28449 28458 +9
============================================
Files 2475 2475
Lines 136499 136523 +24
Branches 16594 16597 +3
============================================
+ Hits 93985 93995 +10
- Misses 34953 34972 +19
+ Partials 7561 7556 -5
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.42% <40.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <90.00%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4290419516
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.84%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.84% -0.01%
- Complexity 28449 28458 +9
============================================
Files 2475 2475
Lines 136499 136523 +24
Branches 16594 16597 +3
============================================
+ Hits 93985 93995 +10
- Misses 34953 34972 +19
+ Partials 7561 7556 -5
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.42% <40.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <90.00%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294112857
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.43%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (69b7c97). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (69b7c97) |
>|------|------|------|
>|spark-java-tests|3|1|
>|spark-scala-tests|5|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 58.65% 48.43% -10.23%
+ Complexity 24264 16311 -7953
=============================================
Files 2475 1997 -478
Lines 136566 110816 -25750
Branches 16611 13920 -2691
=============================================
- Hits 80106 53675 -26431
- Misses 49577 51524 +1947
+ Partials 6883 5617 -1266
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.38% <33.33%> (+0.77%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <70.83%> (+0.65%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `66.66% <70.83%> (-3.58%)` | :arrow_down: |
... and [1127 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294140063
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.69%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (69b7c97). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (69b7c97) |
>|------|------|------|
>|spark-scala-tests|6|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 65.70% 58.69% -7.02%
+ Complexity 27129 24255 -2874
============================================
Files 2475 2475
Lines 136566 136590 +24
Branches 16611 16623 +12
============================================
- Hits 89732 80168 -9564
- Misses 39341 49482 +10141
+ Partials 7493 6940 -553
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <33.33%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <70.83%> (-11.79%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
... and [463 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289474509
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.45%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.45% -1.41%
+ Complexity 28449 27804 -645
============================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
============================================
- Hits 93985 92078 -1907
- Misses 34953 36967 +2014
+ Partials 7561 7464 -97
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.66% <40.00%> (-6.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.74% <90.00%> (-0.57%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [231 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303727973
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.45%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 61.45% -7.40%
+ Complexity 28468 25419 -3049
============================================
Files 2477 2478 +1
Lines 136691 136735 +44
Branches 16634 16650 +16
============================================
- Hits 94112 84030 -10082
- Misses 35008 45490 +10482
+ Partials 7571 7215 -356
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <27.02%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <54.05%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.80% <12.50%> (-15.51%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.02% <65.51%> (-2.41%)` | :arrow_down: |
... and [550 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303819199
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.80%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.80% -0.05%
+ Complexity 28468 28450 -18
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16652 +18
============================================
- Hits 94112 94094 -18
- Misses 35008 35085 +77
+ Partials 7571 7570 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.32% <32.43%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <62.16%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [25 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305240511
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4729eef1a150bf906ccb01b5943fc3903ab3adb0 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479)
* 266cbd9e50951dde68b23c4adc9d9742ffb01ae9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305485483
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.00%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [29 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (266cbd9). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (266cbd9) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 54.00% -14.85%
+ Complexity 28468 12365 -16103
=============================================
Files 2477 1430 -1047
Lines 136691 71556 -65135
Branches 16634 8116 -8518
=============================================
- Hits 94112 38644 -55468
+ Misses 35008 29459 -5549
+ Partials 7571 3453 -4118
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `16.66% <0.00%> (-62.65%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.19% <0.00%> (-65.24%)` | :arrow_down: |
... and [1823 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3131742902
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -27,7 +27,7 @@ import org.apache.avro.{AvroRuntimeException, Schema}
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.avro.HoodieSparkSchemaConverters
import org.apache.spark.sql.catalyst.InternalRow
-import org.apache.spark.sql.types.{ArrayType, DataType, MapType, StructType}
+import org.apache.spark.sql.types.{ArrayType, DataType, MapType, MetadataBuilder, StructField, StructType}
Review Comment:
_⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
# Read the entire file to understand its structure and confirm the issue
cat -n hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala
```
Repository: hudi-agent/hudi
Length of output: 17860
---
</details>
**Use locale-stable lowercasing for case-insensitive field matching.**
`toLowerCase` without `Locale.ROOT` uses the JVM's default locale, which can produce inconsistent results. For example, in Turkish locale, lowercase 'I' becomes 'ı' (dotless i) instead of 'i', breaking case-insensitive field lookup.
<details>
<summary>🔧 Proposed fix</summary>
```diff
+import java.util.Locale
import java.util.concurrent.ConcurrentHashMap
@@
- targetSchema.fields.map(f => f.name.toLowerCase -> f).toMap
+ targetSchema.fields.map(f => f.name.toLowerCase(Locale.ROOT) -> f).toMap
@@
- if (caseSensitive) identity else (_: String).toLowerCase
+ if (caseSensitive) identity else (_: String).toLowerCase(Locale.ROOT)
```
</details>
Also applies to: 182-185
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify each finding against the current code and only fix it if needed.
In
`@hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala`
at line 30, Replace locale-dependent toLowerCase() calls used for
case-insensitive field matching in HoodieSchemaConversionUtils with
locale-stable toLowerCase(Locale.ROOT); add an import for java.util.Locale and
update every occurrence (including the ones around the case-insensitive field
lookup code flagged at the other occurrence) so comparisons use
fieldName.toLowerCase(Locale.ROOT) (or equivalent) instead of
fieldName.toLowerCase(), ensuring all case-insensitive matching logic in
HoodieSchemaConversionUtils uses Locale.ROOT.
```
</details>
<!-- fingerprinting:phantom:poseidon:hawk:1e5feb16-b05f-43d8-a79f-58ee11e70de5 -->
<!-- This is an auto-generated comment by CodeRabbit -->
— *CodeRabbit* ([original](https://github.com/hudi-agent/hudi/pull/15#discussion_r3131740259)) (source:comment#3131740259)
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -363,6 +369,16 @@ object HoodieSparkSchemaConverters extends SparkAdapterSupport {
}
}
+ private def isAssignableTo(source: DataType, expected: DataType): Boolean = (source, expected) match {
+ case (s: StructType, e: StructType) =>
+ s.length == e.length && s.fields.zip(e.fields).forall { case (sf, ef) =>
+ sf.name == ef.name &&
+ (ef.nullable || !sf.nullable) &&
+ isAssignableTo(sf.dataType, ef.dataType)
+ }
+ case _ => source == expected
Review Comment:
_⚠️ Potential issue_ | _🟠 Major_
**Use Spark's resolver for BLOB/VARIANT field-name checks.**
These validators hard-code exact field-name matching (`sf.name == ef.name` and exact `Map` lookup). Under Spark's default case-insensitive analysis, a source struct that only differs by case can still be valid, but it will fail here after metadata is reattached. Please make these checks case-sensitivity-aware instead of comparing names literally.
Also applies to: 395-406
<details>
<summary>🤖 Prompt for AI Agents</summary>
```
Verify each finding against the current code and only fix it if needed.
In
`@hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala`
around lines 372 - 379, The field-name comparisons in isAssignableTo (and the
similar Map lookups around lines 395-406) use exact string equality and must
instead use Spark's case-sensitivity-aware resolver; change sf.name == ef.name
to use the active resolver (e.g.
sparkSession.sessionState.conf.resolver(sf.name, ef.name) or the local resolver
function available in context) and replace direct Map lookup by exact key
(map.get(key) or map(key)) with a search like map.find { case (k, _) =>
resolver(k, lookupKey) }. Update the helper isAssignableTo and the Map lookup
sites to use that resolver so name equality honors Spark's case-insensitivity
settings.
```
</details>
<!-- fingerprinting:phantom:medusa:grasshopper:eb4a9b5d-15c2-414d-8b80-c11a3cb058ae -->
<!-- This is an auto-generated comment by CodeRabbit -->
— *CodeRabbit* ([original](https://github.com/hudi-agent/hudi/pull/15#discussion_r3131740270)) (source:comment#3131740270)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305593721
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `62.16216%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.91%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 65.91% -2.94%
+ Complexity 28468 27273 -1195
============================================
Files 2477 2478 +1
Lines 136691 136735 +44
Branches 16634 16647 +13
============================================
- Hits 94112 90128 -3984
- Misses 35008 38966 +3958
- Partials 7571 7641 +70
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <27.02%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <62.16%> (-0.27%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `69.04% <12.50%> (-10.27%)` | :arrow_down: |
... and [379 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305712508
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.81%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.81% -0.04%
+ Complexity 28468 28461 -7
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16649 +15
============================================
- Hits 94112 94100 -12
- Misses 35008 35080 +72
+ Partials 7571 7569 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <32.43%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <62.16%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305834573
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.82% -0.03%
+ Complexity 28468 28465 -3
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16649 +15
============================================
+ Hits 94112 94114 +2
- Misses 35008 35067 +59
+ Partials 7571 7568 -3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.42% <32.43%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <62.16%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [20 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3132304791
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,86 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Align `sourceSchema` with the authoritative `targetSchema` (the catalog table schema)
+ * along two dimensions that Spark's write-path rewrites strip away:
+ *
+ * 1. Custom Hudi logical-type metadata (VECTOR, BLOB). TableOutputResolver's Cast(...)
+ * and UPDATE's castIfNeeded drop the StructField metadata that marks these types;
+ * without re-attaching, downstream conversion yields the backing physical type
+ * (plain ARRAY for VECTOR, plain STRUCT for BLOB) and the schema-compat check fails
+ * with MISSING_UNION_BRANCH.
+ * 2. Nullability. The resolved query schema typically marks every column nullable
+ * (VALUES literals and Cast outputs are nullable by default), which diverges from
+ * the catalog's declared nullability (e.g. primaryKey columns are non-null). Since
+ * the rebuilt schema becomes the DataFrame's schema, and therefore the writer's
+ * Avro schema, leaving source nullability in place produces a writer/reader mismatch
+ * like writer=["null","long"] vs reader="long" and fails the compat check.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType. Fields without a matching target (source-only columns such
+ * as MERGE join keys) are returned unchanged.
+ *
+ * @param sourceSchema the schema produced by the query (may have lost metadata and may
+ * carry over-permissive nullability)
+ * @param targetSchema the catalog schema that owns the authoritative metadata and
+ * nullability
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def alignSchemaWithCatalog(sourceSchema: StructType,
+ targetSchema: StructType,
+ caseSensitive: Boolean): StructType = {
+ val targetByName: Map[String, StructField] =
+ if (caseSensitive) {
+ targetSchema.fields.map(f => f.name -> f).toMap
+ } else {
+ targetSchema.fields.map(f => f.name.toLowerCase -> f).toMap
+ }
+ val lookupKey: String => String =
+ if (caseSensitive) identity else (_: String).toLowerCase
+
+ StructType(sourceSchema.fields.map { field =>
+ targetByName.get(lookupKey(field.name)) match {
+ case Some(target) => alignField(field, target, caseSensitive)
+ case None => field
+ }
+ })
+ }
+
+ private def alignField(source: StructField,
+ target: StructField,
+ caseSensitive: Boolean): StructField = {
+ val withNestedDataType = (source.dataType, target.dataType) match {
+ case (s: StructType, t: StructType) =>
+ source.copy(
+ dataType = alignSchemaWithCatalog(s, t, caseSensitive),
Review Comment:
Addressed.
Adding a `alignNullability: Boolean` flag on the existing function. **INSERT/UPDATE** pass _true_, **MERGE** passes _false_. Smaller diff, one function, explicit at each call site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3132279521
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,86 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Align `sourceSchema` with the authoritative `targetSchema` (the catalog table schema)
+ * along two dimensions that Spark's write-path rewrites strip away:
+ *
+ * 1. Custom Hudi logical-type metadata (VECTOR, BLOB). TableOutputResolver's Cast(...)
+ * and UPDATE's castIfNeeded drop the StructField metadata that marks these types;
+ * without re-attaching, downstream conversion yields the backing physical type
+ * (plain ARRAY for VECTOR, plain STRUCT for BLOB) and the schema-compat check fails
+ * with MISSING_UNION_BRANCH.
+ * 2. Nullability. The resolved query schema typically marks every column nullable
+ * (VALUES literals and Cast outputs are nullable by default), which diverges from
+ * the catalog's declared nullability (e.g. primaryKey columns are non-null). Since
+ * the rebuilt schema becomes the DataFrame's schema, and therefore the writer's
+ * Avro schema, leaving source nullability in place produces a writer/reader mismatch
+ * like writer=["null","long"] vs reader="long" and fails the compat check.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType. Fields without a matching target (source-only columns such
+ * as MERGE join keys) are returned unchanged.
+ *
+ * @param sourceSchema the schema produced by the query (may have lost metadata and may
+ * carry over-permissive nullability)
+ * @param targetSchema the catalog schema that owns the authoritative metadata and
+ * nullability
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def alignSchemaWithCatalog(sourceSchema: StructType,
+ targetSchema: StructType,
+ caseSensitive: Boolean): StructType = {
+ val targetByName: Map[String, StructField] =
+ if (caseSensitive) {
+ targetSchema.fields.map(f => f.name -> f).toMap
+ } else {
+ targetSchema.fields.map(f => f.name.toLowerCase -> f).toMap
+ }
+ val lookupKey: String => String =
+ if (caseSensitive) identity else (_: String).toLowerCase
+
+ StructType(sourceSchema.fields.map { field =>
+ targetByName.get(lookupKey(field.name)) match {
+ case Some(target) => alignField(field, target, caseSensitive)
+ case None => field
+ }
+ })
+ }
+
+ private def alignField(source: StructField,
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3132274877
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,86 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Align `sourceSchema` with the authoritative `targetSchema` (the catalog table schema)
+ * along two dimensions that Spark's write-path rewrites strip away:
+ *
+ * 1. Custom Hudi logical-type metadata (VECTOR, BLOB). TableOutputResolver's Cast(...)
+ * and UPDATE's castIfNeeded drop the StructField metadata that marks these types;
+ * without re-attaching, downstream conversion yields the backing physical type
+ * (plain ARRAY for VECTOR, plain STRUCT for BLOB) and the schema-compat check fails
+ * with MISSING_UNION_BRANCH.
+ * 2. Nullability. The resolved query schema typically marks every column nullable
+ * (VALUES literals and Cast outputs are nullable by default), which diverges from
+ * the catalog's declared nullability (e.g. primaryKey columns are non-null). Since
+ * the rebuilt schema becomes the DataFrame's schema, and therefore the writer's
+ * Avro schema, leaving source nullability in place produces a writer/reader mismatch
+ * like writer=["null","long"] vs reader="long" and fails the compat check.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType. Fields without a matching target (source-only columns such
+ * as MERGE join keys) are returned unchanged.
+ *
+ * @param sourceSchema the schema produced by the query (may have lost metadata and may
+ * carry over-permissive nullability)
+ * @param targetSchema the catalog schema that owns the authoritative metadata and
+ * nullability
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def alignSchemaWithCatalog(sourceSchema: StructType,
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3132288677
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -27,7 +27,7 @@ import org.apache.avro.{AvroRuntimeException, Schema}
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.avro.HoodieSparkSchemaConverters
import org.apache.spark.sql.catalyst.InternalRow
-import org.apache.spark.sql.types.{ArrayType, DataType, MapType, StructType}
+import org.apache.spark.sql.types.{ArrayType, DataType, MapType, MetadataBuilder, StructField, StructType}
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306257248
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 266cbd9e50951dde68b23c4adc9d9742ffb01ae9 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485)
* b6235e1eef6740d98ea9cc72490bb731f9d8e1de UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306779063
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `61.76471%` with `26 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.88%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 72.22% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 47.88% -20.97%
+ Complexity 28468 16524 -11944
=============================================
Files 2477 2017 -460
Lines 136691 113330 -23361
Branches 16634 14464 -2170
=============================================
- Hits 94112 54272 -39840
- Misses 35008 53305 +18297
+ Partials 7571 5753 -1818
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.00% <38.23%> (-16.43%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <55.88%> (-12.89%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.03% <21.42%> (-18.28%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `71.01% <72.22%> (-0.42%)` | :arrow_down: |
... and [1546 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4302593331
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.76% -0.09%
+ Complexity 28462 28399 -63
============================================
Files 2475 2475
Lines 136580 136611 +31
Branches 16613 16629 +16
============================================
- Hits 94041 93941 -100
- Misses 34977 35116 +139
+ Partials 7562 7554 -8
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.38% <31.25%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4302804621
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.77% -0.08%
+ Complexity 28462 28406 -56
============================================
Files 2475 2475
Lines 136580 136611 +31
Branches 16613 16629 +16
============================================
- Hits 94041 93959 -82
- Misses 34977 35095 +118
+ Partials 7562 7557 -5
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.41% <31.25%> (-0.02%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4302748122
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.76% -0.09%
+ Complexity 28462 28400 -62
============================================
Files 2475 2475
Lines 136580 136611 +31
Branches 16613 16629 +16
============================================
- Hits 94041 93943 -98
- Misses 34977 35115 +138
+ Partials 7562 7553 -9
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.38% <31.25%> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [31 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307975327
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 839ee5166867c465f7c5d72872a101e26736fe92 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495)
* 288aad1b3d8f8ae825841f3a56b1b2cccff761ba Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311057854
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 288aad1b3d8f8ae825841f3a56b1b2cccff761ba Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498)
* ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311192554
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.41%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 46.41% -22.47%
+ Complexity 28532 15355 -13177
=============================================
Files 2479 1971 -508
Lines 136810 108454 -28356
Branches 16660 13417 -3243
=============================================
- Hits 94244 50341 -43903
- Misses 34982 52789 +17807
+ Partials 7584 5324 -2260
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.14% <50.00%> (-12.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `42.10% <60.00%> (-29.33%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.33% <39.28%> (-25.98%)` | :arrow_down: |
... and [1620 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311165553
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `1.72414%` with `57 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.91%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 3.57% | [24 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 53.91% -14.98%
+ Complexity 28532 12366 -16166
=============================================
Files 2479 1430 -1049
Lines 136810 71680 -65130
Branches 16660 8151 -8509
=============================================
- Hits 94244 38645 -55599
+ Misses 34982 29579 -5403
+ Partials 7584 3456 -4128
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `15.55% <3.57%> (-63.76%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.14% <0.00%> (-65.29%)` | :arrow_down: |
... and [1824 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311212259
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.36%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|2|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.36% -20.53%
+ Complexity 28532 16737 -11795
=============================================
Files 2479 2018 -461
Lines 136810 113443 -23367
Branches 16660 14492 -2168
=============================================
- Hits 94244 54868 -39376
- Misses 34982 52652 +17670
+ Partials 7584 5923 -1661
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.00% <20.68%> (-16.49%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1538 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311270384
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.94%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 65.94% -2.95%
+ Complexity 28532 27312 -1220
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 90255 -3989
- Misses 34982 38947 +3965
- Partials 7584 7660 +76
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.20% <20.68%> (-17.29%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <70.68%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `71.11% <53.57%> (-8.20%)` | :arrow_down: |
... and [365 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311454532
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.75%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 44.75% -24.14%
+ Complexity 28532 8512 -20020
=============================================
Files 2479 1200 -1279
Lines 136810 62507 -74303
Branches 16660 6762 -9898
=============================================
- Hits 94244 27975 -66269
+ Misses 34982 31473 -3509
+ Partials 7584 3059 -4525
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2080 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311608009
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.94%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 45.94% -22.94%
+ Complexity 28532 15554 -12978
=============================================
Files 2479 1988 -491
Lines 136810 110820 -25990
Branches 16660 13931 -2729
=============================================
- Hits 94244 50919 -43325
- Misses 34982 54395 +19413
+ Partials 7584 5506 -2078
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <50.00%> (-12.28%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `43.85% <60.00%> (-27.57%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.77% <39.28%> (-25.54%)` | :arrow_down: |
... and [1605 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321468553
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.94%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 65.94% -2.94%
+ Complexity 28532 27344 -1188
============================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
============================================
- Hits 94244 90380 -3864
- Misses 34982 39031 +4049
- Partials 7584 7636 +52
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.17% <20.68%> (-17.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.68%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `71.11% <53.57%> (-8.20%)` | :arrow_down: |
... and [355 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322645557
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 68.88% 68.89% +0.01%
- Complexity 28532 28579 +47
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
+ Hits 94244 94462 +218
- Misses 34982 35021 +39
- Partials 7584 7622 +38
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.41% <43.10%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [33 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321438165
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `1.72414%` with `57 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.99%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 3.57% | [24 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (4a72e7f). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (4a72e7f) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 53.99% -14.90%
+ Complexity 28532 12391 -16141
=============================================
Files 2479 1431 -1048
Lines 136810 71832 -64978
Branches 16660 8178 -8482
=============================================
- Hits 94244 38786 -55458
+ Misses 34982 29569 -5413
+ Partials 7584 3477 -4107
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `15.55% <3.57%> (-63.76%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.14% <0.00%> (-65.29%)` | :arrow_down: |
... and [1826 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322610539
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.33%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (48694ab). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (48694ab) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.33% -20.55%
+ Complexity 28532 16768 -11764
=============================================
Files 2479 2021 -458
Lines 136810 113683 -23127
Branches 16660 14542 -2118
=============================================
- Hits 94244 54953 -39291
- Misses 34982 52786 +17804
+ Partials 7584 5944 -1640
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <20.68%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1544 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322678773
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.90%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 68.88% 68.90% +0.01%
- Complexity 28532 28580 +48
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
+ Hits 94244 94467 +223
- Misses 34982 35018 +36
- Partials 7584 7620 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.48% <43.10%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [30 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4293849903
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34b7555383976f932baa24bc0631fb610924cf9d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412)
* f104c57b7539e59468aea3171f531fdd0e70f980 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294310473
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.16667%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.77% -0.08%
+ Complexity 28462 28396 -66
============================================
Files 2475 2475
Lines 136580 136618 +38
Branches 16613 16627 +14
============================================
- Hits 94041 93963 -78
- Misses 34977 35104 +127
+ Partials 7562 7551 -11
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.41% <33.33%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <79.16%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
... and [33 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321473425
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.75%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.75% -0.14%
+ Complexity 28532 28501 -31
============================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
============================================
- Hits 94244 94220 -24
- Misses 34982 35231 +249
- Partials 7584 7596 +12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.83% <43.10%> (-0.66%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <70.68%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [64 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321476515
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.79%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.79% -0.10%
+ Complexity 28532 28513 -19
============================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
============================================
+ Hits 94244 94276 +32
- Misses 34982 35171 +189
- Partials 7584 7600 +16
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.01% <43.10%> (-0.48%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <70.68%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [50 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305761274
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.81%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.81% -0.04%
+ Complexity 28468 28465 -3
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16649 +15
============================================
- Hits 94112 94107 -5
- Misses 35008 35074 +66
+ Partials 7571 7568 -3
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.41% <32.43%> (-0.02%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <62.16%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306795432
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `61.76471%` with `26 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.93%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 72.22% | [8 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 47.93% -20.92%
+ Complexity 28468 16536 -11932
=============================================
Files 2477 2017 -460
Lines 136691 113330 -23361
Branches 16634 14464 -2170
=============================================
- Hits 94112 54321 -39791
- Misses 35008 53270 +18262
+ Partials 7571 5739 -1832
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <38.23%> (-16.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <55.88%> (-12.89%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.03% <21.42%> (-18.28%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `71.01% <72.22%> (-0.42%)` | :arrow_down: |
... and [1546 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311226357
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311683022
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.73%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 67.73% -1.16%
+ Complexity 28532 28010 -522
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 92705 -1539
- Misses 34982 36509 +1527
- Partials 7584 7648 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.69% <41.37%> (-6.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <70.68%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [211 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308323302
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.83%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.83% -0.02%
+ Complexity 28468 28453 -15
============================================
Files 2477 2478 +1
Lines 136691 136737 +46
Branches 16634 16653 +19
============================================
+ Hits 94112 94120 +8
- Misses 35008 35047 +39
+ Partials 7571 7570 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.19% <43.10%> (-0.25%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [36 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311273354
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.88%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 67.88% -1.01%
+ Complexity 28532 28087 -445
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 92907 -1337
- Misses 34982 36324 +1342
- Partials 7584 7631 +47
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.41% <43.10%> (-4.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <70.68%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [194 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311279822
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.92%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 67.92% -0.96%
+ Complexity 28532 28100 -432
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 92969 -1275
- Misses 34982 36253 +1271
- Partials 7584 7640 +56
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.59% <43.10%> (-3.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <70.68%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [182 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311763415
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
}, {
"hash" : "873d4aefc68214948ee600469ed64e6d20e48004",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529",
"triggerID" : "873d4aefc68214948ee600469ed64e6d20e48004",
"triggerType" : "PUSH"
}, {
"hash" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530",
"triggerID" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 873d4aefc68214948ee600469ed64e6d20e48004 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529)
* c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305648652
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.87%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.87% -0.98%
+ Complexity 28468 28054 -414
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16649 +15
============================================
- Hits 94112 92813 -1299
- Misses 35008 36313 +1305
- Partials 7571 7623 +52
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.50% <32.43%> (-3.93%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <62.16%> (-0.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [183 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3132263686
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,72 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach custom Hudi logical-type metadata (e.g. VECTOR, BLOB) from `targetSchema` onto
+ * matching fields of `sourceSchema`. Spark's TableOutputResolver wraps write-path outputs in
+ * Cast(...) (and UPDATE assignments go through castIfNeeded), both of which drop the
+ * StructField metadata that marks these custom types. Without re-attaching, downstream
+ * conversion to HoodieSchema yields the backing physical type (e.g. plain ARRAY for VECTOR,
+ * plain STRUCT for BLOB) and the schema-compat check against the persisted
+ * tableCreateSchema fails.
+ *
+ * Recurses into nested StructType, ArrayType whose element is a StructType, and MapType
+ * whose value is a StructType - the shapes where BLOB can legally be nested. Fields
+ * without a matching target (source-only columns such as MERGE join keys) are returned
+ * unchanged.
+ *
+ * @param sourceSchema the schema whose fields may have lost custom-type metadata
+ * @param targetSchema the catalog schema that owns the authoritative metadata
+ * @param caseSensitive whether field name matching should be case-sensitive (mirrors
+ * `spark.sql.caseSensitive`)
+ */
+ def reattachCustomTypeMetadata(sourceSchema: StructType,
+ targetSchema: StructType,
+ caseSensitive: Boolean): StructType = {
+ val targetByName: Map[String, StructField] =
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306749807
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `48.52941%` with `35 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.84%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 61.11% | [12 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [5 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 46.84% -22.01%
+ Complexity 28468 15128 -13340
=============================================
Files 2477 1954 -523
Lines 136691 105898 -30793
Branches 16634 12778 -3856
=============================================
- Hits 94112 49605 -44507
- Misses 35008 51123 +16115
+ Partials 7571 5170 -2401
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.21% <48.52%> (-12.10%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `51.17% <0.00%> (-28.14%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `44.20% <61.11%> (-27.23%)` | :arrow_down: |
... and [1631 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306751509
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `48.52941%` with `35 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.81%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 61.11% | [12 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [5 Missing and 9 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 44.81% -24.04%
+ Complexity 28468 15128 -13340
=============================================
Files 2477 1988 -489
Lines 136691 110694 -25997
Branches 16634 13818 -2816
=============================================
- Hits 94112 49605 -44507
- Misses 35008 55919 +20911
+ Partials 7571 5170 -2401
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.77% <48.52%> (-13.54%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `51.17% <0.00%> (-28.14%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `44.20% <61.11%> (-27.23%)` | :arrow_down: |
... and [1625 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311708880
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.08%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.08% -0.81%
+ Complexity 28532 28200 -332
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 93182 -1062
- Misses 34982 36037 +1055
- Partials 7584 7643 +59
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.78% <43.10%> (-3.70%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [142 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311719111
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.85%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.85% -0.04%
+ Complexity 28532 28505 -27
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 94233 -11
- Misses 34982 35046 +64
+ Partials 7584 7583 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.23% <43.10%> (-0.25%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [23 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311291749
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.04% -0.85%
+ Complexity 28532 28163 -369
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 93121 -1123
- Misses 34982 36104 +1122
- Partials 7584 7637 +53
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.59% <43.10%> (-3.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.06%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322616751
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.93%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (48694ab). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (48694ab) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 58.93% -9.95%
+ Complexity 28532 24508 -4024
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
- Hits 94244 80809 -13435
- Misses 34982 49216 +14234
+ Partials 7584 7080 -504
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.16% <20.68%> (-17.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.55% <46.42%> (-15.76%)` | :arrow_down: |
... and [667 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3143820891
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -278,10 +282,22 @@ object HoodieSparkSchemaConverters extends SparkAdapterSupport {
metadataBuilder.putString(HoodieSchema.TYPE_METADATA_FIELD, HoodieSchema.Blob.TYPE_DESCRIPTOR)
}
val metadata = metadataBuilder.build()
- StructField(f.name(), schemaType.dataType, schemaType.nullable, metadata)
+ // For BLOB: force nullable-everywhere at the Spark type layer. The RFC-100
+ // canonical schema declares `type`, `reference.external_path`, and
+ // `reference.managed` as strictly non-null, but that contract is conditional
+ // ("required when parent is present") and Spark's type system can't model it.
+ // Projecting BLOB as nullable-everywhere for Spark avoids downstream pain
+ // (Cast / TableOutputResolver / Cast.canCast rewrites); the on-disk physical
+ // schema stays RFC-100 compliant because the write path goes through
+ // HoodieSchema.Blob.createBlob(), which uses the canonical fields verbatim.
+ if (isBlob) {
+ StructField(f.name(), withAllFieldsNullable(schemaType.dataType), nullable = true, metadata)
Review Comment:
Your example should fail during the write stage IIUC as the write side `create_blob` by Hoodie schema will see a TYPE as null as invalid. i.e. writer side will fail.
Followup task with more details on why this is written this way: #18601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #18540:
URL: https://github.com/apache/hudi/pull/18540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306441210
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `44 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.00%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6235e1`](https://app.codecov.io/gh/apache/hudi/commit/b6235e1eef6740d98ea9cc72490bb731f9d8e1de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (b6235e1). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (b6235e1) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 54.00% -14.85%
+ Complexity 28468 12364 -16104
=============================================
Files 2477 1430 -1047
Lines 136691 71560 -65131
Branches 16634 8120 -8514
=============================================
- Hits 94112 38644 -55468
+ Misses 35008 29462 -5546
+ Partials 7571 3454 -4117
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `16.43% <0.00%> (-62.88%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.14% <0.00%> (-65.29%)` | :arrow_down: |
... and [1824 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306499680
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `47.72727%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.38%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6235e1`](https://app.codecov.io/gh/apache/hudi/commit/b6235e1eef6740d98ea9cc72490bb731f9d8e1de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (b6235e1). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (b6235e1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 48.38% -20.47%
+ Complexity 28468 16726 -11742
=============================================
Files 2477 2017 -460
Lines 136691 113306 -23385
Branches 16634 14454 -2180
=============================================
- Hits 94112 54825 -39287
- Misses 35008 52559 +17551
+ Partials 7571 5922 -1649
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <25.00%> (-16.42%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <47.72%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.03% <21.42%> (-18.28%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
... and [1540 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311330266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
}, {
"hash" : "873d4aefc68214948ee600469ed64e6d20e48004",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "873d4aefc68214948ee600469ed64e6d20e48004",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526)
* 873d4aefc68214948ee600469ed64e6d20e48004 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4313536756
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.88%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=========================================
Coverage 68.88% 68.88%
+ Complexity 28532 28519 -13
=========================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
=========================================
+ Hits 94244 94280 +36
- Misses 34982 34986 +4
- Partials 7584 7596 +12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.49% <43.10%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289344658
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.00000%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.50%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 40.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (59fee58) and HEAD (34b7555). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (59fee58) | HEAD (34b7555) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 46.50% -22.35%
+ Complexity 28449 15044 -13405
=============================================
Files 2475 1951 -524
Lines 136499 105738 -30761
Branches 16594 12739 -3855
=============================================
- Hits 93985 49178 -44807
- Misses 34953 51504 +16551
+ Partials 7561 5056 -2505
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <40.00%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `34.04% <40.00%> (-37.39%)` | :arrow_down: |
... and [1637 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289503934
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.77% -0.09%
+ Complexity 28449 28404 -45
============================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
============================================
- Hits 93985 93882 -103
- Misses 34953 35067 +114
+ Partials 7561 7560 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.11% <40.00%> (-0.30%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <90.00%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303358852
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.84%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|11|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.84% 47.84% -21.01%
+ Complexity 28468 16441 -12027
=============================================
Files 2477 2017 -460
Lines 136691 113311 -23380
Branches 16634 14455 -2179
=============================================
- Hits 94109 54212 -39897
- Misses 35011 53401 +18390
+ Partials 7571 5698 -1873
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.63% <25.00%> (-16.74%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <56.25%> (-13.55%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.33% <12.50%> (-25.98%)` | :arrow_down: |
... and [1544 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303464217
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475)
* d3c9220ef21705582d43471b21a6df685ea4d0e9 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477)
* 4729eef1a150bf906ccb01b5943fc3903ab3adb0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303678986
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `37 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.00%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [29 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 54.00% -14.85%
+ Complexity 28468 12366 -16102
=============================================
Files 2477 1430 -1047
Lines 136691 71556 -65135
Branches 16634 8116 -8518
=============================================
- Hits 94112 38644 -55468
+ Misses 35008 29461 -5547
+ Partials 7571 3451 -4120
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `16.66% <0.00%> (-62.65%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.19% <0.00%> (-65.24%)` | :arrow_down: |
... and [1824 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303714617
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.39%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|2|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 48.39% -20.46%
+ Complexity 28468 16731 -11737
=============================================
Files 2477 2017 -460
Lines 136691 113302 -23389
Branches 16634 14453 -2181
=============================================
- Hits 94112 54837 -39275
- Misses 35008 52544 +17536
+ Partials 7571 5921 -1650
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <27.02%> (-16.42%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <54.05%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.42% <12.50%> (-17.89%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.02% <65.51%> (-2.41%)` | :arrow_down: |
... and [1539 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303702366
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.98%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 45.98% -22.87%
+ Complexity 28468 15552 -12916
=============================================
Files 2477 1988 -489
Lines 136691 110683 -26008
Branches 16634 13893 -2741
=============================================
- Hits 94112 50903 -43209
- Misses 35008 54283 +19275
+ Partials 7571 5497 -2074
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <54.05%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.33% <12.50%> (-25.98%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `45.13% <65.51%> (-26.30%)` | :arrow_down: |
... and [1604 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305570266
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.45%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (266cbd9). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (266cbd9) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 61.45% -7.40%
+ Complexity 28468 25426 -3042
============================================
Files 2477 2478 +1
Lines 136691 136735 +44
Branches 16634 16647 +13
============================================
- Hits 94112 84033 -10079
- Misses 35008 45485 +10477
+ Partials 7571 7217 -354
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <27.02%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <54.05%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.80% <12.50%> (-15.51%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.02% <65.51%> (-2.41%)` | :arrow_down: |
... and [547 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322648292
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 68.88% 68.89% +0.01%
- Complexity 28532 28580 +48
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
+ Hits 94244 94465 +221
- Misses 34982 35020 +38
- Partials 7584 7620 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.45% <43.10%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322638519
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.05% -0.84%
+ Complexity 28532 28225 -307
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
- Hits 94244 93308 -936
- Misses 34982 36117 +1135
- Partials 7584 7680 +96
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.72% <43.10%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [160 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3143065830
##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -407,6 +407,16 @@ case class MergeIntoHoodieTableCommand(mergeInto: MergeIntoTable) extends Hoodie
* expressions to the ExpressionPayload#getInsertValue.
*/
private def executeUpsert(sourceDF: DataFrame, parameters: Map[String, String]): Unit = {
+ // Source data doesn't carry custom Hudi logical-type metadata (hudi_type, e.g. VECTOR/BLOB);
+ // restore it from the catalog schema so downstream Avro conversion emits the right branch.
+ val enrichedSourceSchema = HoodieSchemaConversionUtils.alignSchemaWithCatalog(
+ sourceDF.schema,
+ hoodieCatalogTable.tableSchemaWithoutMetaFields,
+ sparkSession.sessionState.conf.caseSensitiveAnalysis,
+ alignNullability = false)
Review Comment:
🤖 `enrichedSourceDF` is built here at the top of `executeUpsert`, but the diff only updates two later references (`enrichedSourceDF.schema` at ~497 and `enrichedSourceDF` at ~508). Could you double-check that no other `sourceDF` reference in the unchanged portion of this method (e.g. building joined output, projections, schema bookkeeping) is still seeing the un-enriched schema? A mixed view would leave `hudi_type` metadata only partially threaded through. Same applies to the spark4-common copy.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +146,82 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach catalog metadata/nullability that Spark's write-path rewrites strip:
+ *
+ * 1. VECTOR/BLOB logical-type metadata - dropped by TableOutputResolver's Cast and
+ * UPDATE's castIfNeeded; without it, conversion falls back to the physical type
+ * (ARRAY/STRUCT) and schema compatibility fails.
+ * 2. Nullability (only when `alignNullability = true`) - VALUES literals and Cast
+ * outputs are nullable by default, which conflicts with non-null catalog columns
+ * (e.g. primaryKey) once this schema becomes the writer's canonical schema.
+ *
+ * `alignNullability = true` is only safe when upstream null-assertion expressions
+ * guarantee no nulls flow into non-null columns (INSERT/UPDATE via TableOutputResolver/
+ * castIfNeeded). MERGE must pass `false`: assignments run later inside ExpressionPayload,
+ * so raw source rows may legitimately carry nulls.
+ *
+ * BLOB is projected nullable-everywhere by [[HoodieSparkSchemaConverters.toSqlType]], so
+ * the nullability branch is a no-op inside BLOB subtrees; RFC-100 non-null invariants are
+ * enforced at the physical-schema boundary in HoodieSchema.Blob#createBlob.
+ *
+ * Recurses into nested structs, struct-element arrays, and struct-value maps. Source-only
+ * fields (e.g. MERGE join keys) are returned unchanged.
+ */
+ def alignSchemaWithCatalog(sourceSchema: StructType,
+ targetSchema: StructType,
+ caseSensitive: Boolean,
+ alignNullability: Boolean): StructType = {
+ val lookupKey: String => String =
+ if (caseSensitive) identity else (_: String).toLowerCase(Locale.ROOT)
+ val targetByName: Map[String, StructField] =
+ targetSchema.fields.map(f => lookupKey(f.name) -> f).toMap
+
+ StructType(sourceSchema.fields.map { field =>
+ targetByName.get(lookupKey(field.name)) match {
+ case Some(target) => alignField(field, target, caseSensitive, alignNullability)
+ case None => field
+ }
+ })
+ }
+
+ private def alignField(source: StructField,
+ target: StructField,
+ caseSensitive: Boolean,
+ alignNullability: Boolean): StructField = {
+ val alignedNullable = if (alignNullability) target.nullable else source.nullable
Review Comment:
🤖 For VECTOR (`ArrayType[FloatType]`), neither element is a `StructType`, so this branch is skipped and only top-level nullability is adjusted; source's `containsNull` is preserved. In the MERGE path (`alignNullability=false`) with literals like `array(cast(0.9 as float), ...)` whose `containsNull` may be `true`, the metadata is re-attached on top of an array-of-nullable-floats. Have you verified that `convertStructTypeToHoodieSchema` emits the correct non-null VECTOR element schema in that case (rather than e.g. failing schema-compat with a nullable element union)?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322635875
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.85%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 67.85% -1.04%
+ Complexity 28532 28100 -432
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
- Hits 94244 93035 -1209
- Misses 34982 36415 +1433
- Partials 7584 7655 +71
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.83% <41.37%> (-6.65%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.24% <70.68%> (-0.04%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [190 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321452890
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 63.77%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (4a72e7f). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (4a72e7f) |
>|------|------|------|
>|spark-scala-tests|10|6|
>|spark-java-tests|14|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 63.77% -5.12%
+ Complexity 28532 26486 -2046
============================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
============================================
- Hits 94244 87398 -6846
- Misses 34982 42076 +7094
+ Partials 7584 7573 -11
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.17% <20.68%> (-17.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <70.68%> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `70.66% <53.57%> (-8.65%)` | :arrow_down: |
... and [498 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321447363
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.58%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (4a72e7f). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (4a72e7f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 45.58% -23.31%
+ Complexity 28532 15849 -12683
=============================================
Files 2479 2019 -460
Lines 136810 113625 -23185
Branches 16660 14523 -2137
=============================================
- Hits 94244 51795 -42449
- Misses 34982 56107 +21125
+ Partials 7584 5723 -1861
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.88% <53.44%> (-12.41%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `44.73% <60.00%> (-26.70%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1589 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321479828
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
==========================================
Coverage 68.88% 68.89%
- Complexity 28532 28574 +42
==========================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
==========================================
+ Hits 94244 94413 +169
- Misses 34982 35018 +36
- Partials 7584 7616 +32
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <43.10%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <70.68%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3142820947
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +146,103 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
Review Comment:
@voonhous you think we can make this java doc comment more concise if possibe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322681263
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.90%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 68.88% 68.90% +0.01%
- Complexity 28532 28580 +48
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
+ Hits 94244 94467 +223
- Misses 34982 35018 +36
- Partials 7584 7620 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.51% <43.10%> (+0.03%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [30 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4290503492
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.85%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.85% -0.01%
- Complexity 28449 28459 +10
============================================
Files 2475 2475
Lines 136499 136523 +24
Branches 16594 16597 +3
============================================
+ Hits 93985 94000 +15
- Misses 34953 34966 +13
+ Partials 7561 7557 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.43% <40.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <90.00%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4293987798
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.77%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 44.78% 44.77% -0.01%
+ Complexity 8507 8506 -1
============================================
Files 1198 1198
Lines 62383 62383
Branches 6738 6738
============================================
- Hits 27937 27933 -4
- Misses 31397 31402 +5
+ Partials 3049 3048 -1
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294196922
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.16667%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.87%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.77% 67.87% -0.91%
+ Complexity 28410 28009 -401
============================================
Files 2475 2475
Lines 136580 136604 +24
Branches 16613 16625 +12
============================================
- Hits 93934 92718 -1216
- Misses 35083 36297 +1214
- Partials 7563 7589 +26
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.48% <33.33%> (-3.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <79.16%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
... and [169 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295899436
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.18%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 65.18% -3.67%
+ Complexity 28462 22544 -5918
============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
============================================
- Hits 94041 73795 -20246
+ Misses 34977 32682 -2295
+ Partials 7562 6723 -839
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <31.25%> (-3.96%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [947 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311209244
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.32%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.32% -20.57%
+ Complexity 28532 16727 -11805
=============================================
Files 2479 2018 -461
Lines 136810 113443 -23367
Branches 16660 14492 -2168
=============================================
- Hits 94244 54821 -39423
- Misses 34982 52689 +17707
+ Partials 7584 5933 -1651
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.37% <20.68%> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1538 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311287222
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.99%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 67.99% -0.89%
+ Complexity 28532 28132 -400
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 93065 -1179
- Misses 34982 36170 +1188
- Partials 7584 7627 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.59% <43.10%> (-3.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.27% <70.68%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [160 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311581995
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.81%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 46.81% -22.08%
+ Complexity 28532 15148 -13384
=============================================
Files 2479 1953 -526
Lines 136810 105931 -30879
Branches 16660 12849 -3811
=============================================
- Hits 94244 49588 -44656
- Misses 34982 51181 +16199
+ Partials 7584 5162 -2422
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <50.00%> (-12.08%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `41.22% <60.00%> (-30.21%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `52.44% <39.28%> (-26.87%)` | :arrow_down: |
... and [1648 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311662279
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.88%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 65.88% -3.01%
+ Complexity 28532 27276 -1256
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 90165 -4079
- Misses 34982 39052 +4070
- Partials 7584 7645 +61
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.20% <20.68%> (-17.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.02% <70.68%> (-0.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `71.11% <53.57%> (-8.20%)` | :arrow_down: |
... and [375 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311664273
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
}, {
"hash" : "873d4aefc68214948ee600469ed64e6d20e48004",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529",
"triggerID" : "873d4aefc68214948ee600469ed64e6d20e48004",
"triggerType" : "PUSH"
}, {
"hash" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530",
"triggerID" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526)
* 873d4aefc68214948ee600469ed64e6d20e48004 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529)
* c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303373663
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.94%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.84% 60.94% -7.91%
+ Complexity 28468 25106 -3362
============================================
Files 2477 2477
Lines 136691 136722 +31
Branches 16634 16650 +16
============================================
- Hits 94110 83326 -10784
- Misses 35010 46392 +11382
+ Partials 7571 7004 -567
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.28% <25.00%> (-17.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <56.25%> (-13.55%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `55.71% <12.50%> (-23.60%)` | :arrow_down: |
... and [557 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303375701
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.94%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.84% 60.94% -7.91%
+ Complexity 28468 25106 -3362
============================================
Files 2477 2477
Lines 136691 136722 +31
Branches 16634 16650 +16
============================================
- Hits 94110 83326 -10784
- Misses 35010 46392 +11382
+ Partials 7571 7004 -567
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.28% <25.00%> (-17.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <56.25%> (-13.55%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `55.71% <12.50%> (-23.60%)` | :arrow_down: |
... and [557 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303721465
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.95%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 58.95% -9.90%
+ Complexity 28468 24447 -4021
============================================
Files 2477 2478 +1
Lines 136691 136735 +44
Branches 16634 16650 +16
============================================
- Hits 94112 80616 -13496
- Misses 35008 49051 +14043
+ Partials 7571 7068 -503
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.64% <27.02%> (-16.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <54.05%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.33% <12.50%> (-15.98%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.02% <65.51%> (-2.41%)` | :arrow_down: |
... and [667 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305540394
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.42%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (266cbd9). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (266cbd9) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 48.42% -20.43%
+ Complexity 28468 16744 -11724
=============================================
Files 2477 2017 -460
Lines 136691 113311 -23380
Branches 16634 14446 -2188
=============================================
- Hits 94112 54872 -39240
- Misses 35008 52522 +17514
+ Partials 7571 5917 -1654
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.63% <27.02%> (-16.81%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <54.05%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.42% <12.50%> (-17.89%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.02% <65.51%> (-2.41%)` | :arrow_down: |
... and [1539 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305558976
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.45%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (266cbd9). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (266cbd9) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 61.45% -7.40%
+ Complexity 28468 25426 -3042
============================================
Files 2477 2478 +1
Lines 136691 136735 +44
Branches 16634 16647 +13
============================================
- Hits 94112 84028 -10084
- Misses 35008 45487 +10479
+ Partials 7571 7220 -351
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <27.02%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <54.05%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.80% <12.50%> (-15.51%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.02% <65.51%> (-2.41%)` | :arrow_down: |
... and [547 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3132371447
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -363,6 +369,16 @@ object HoodieSparkSchemaConverters extends SparkAdapterSupport {
}
}
+ private def isAssignableTo(source: DataType, expected: DataType): Boolean = (source, expected) match {
+ case (s: StructType, e: StructType) =>
+ s.length == e.length && s.fields.zip(e.fields).forall { case (sf, ef) =>
+ sf.name == ef.name &&
+ (ef.nullable || !sf.nullable) &&
+ isAssignableTo(sf.dataType, ef.dataType)
+ }
+ case _ => source == expected
Review Comment:
addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306313863
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.77%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6235e1`](https://app.codecov.io/gh/apache/hudi/commit/b6235e1eef6740d98ea9cc72490bb731f9d8e1de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (b6235e1). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (b6235e1) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 44.77% -24.08%
+ Complexity 28468 8510 -19958
=============================================
Files 2477 1200 -1277
Lines 136691 62477 -74214
Branches 16634 6754 -9880
=============================================
- Hits 94112 27974 -66138
+ Misses 35008 31445 -3563
+ Partials 7571 3058 -4513
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2078 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306491261
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `47.72727%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.60%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6235e1`](https://app.codecov.io/gh/apache/hudi/commit/b6235e1eef6740d98ea9cc72490bb731f9d8e1de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (b6235e1). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (b6235e1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 45.60% -23.25%
+ Complexity 28468 15814 -12654
=============================================
Files 2477 2017 -460
Lines 136691 113306 -23385
Branches 16634 14454 -2180
=============================================
- Hits 94112 51678 -42434
- Misses 35008 55914 +20906
+ Partials 7571 5714 -1857
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <47.72%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.03% <21.42%> (-18.28%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `44.73% <60.00%> (-26.70%)` | :arrow_down: |
... and [1588 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306817289
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b6235e1eef6740d98ea9cc72490bb731f9d8e1de Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488)
* 06a7f9e8333a73e73b3c1487b1629cd3f1013cc8 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307518162
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.78%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`839ee51`](https://app.codecov.io/gh/apache/hudi/commit/839ee5166867c465f7c5d72872a101e26736fe92?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (839ee51). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (839ee51) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 44.78% -24.07%
+ Complexity 28468 8514 -19954
=============================================
Files 2477 1200 -1277
Lines 136691 62477 -74214
Branches 16634 6754 -9880
=============================================
- Hits 94112 27982 -66130
+ Misses 35008 31440 -3568
+ Partials 7571 3055 -4516
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (+0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2078 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307992095
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `44.82759%` with `32 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.85%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 35.71% | [7 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 53.33% | [8 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (288aad1). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (288aad1) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 46.85% -22.00%
+ Complexity 28468 15140 -13328
=============================================
Files 2477 1953 -524
Lines 136691 105870 -30821
Branches 16634 12770 -3864
=============================================
- Hits 94112 49604 -44508
- Misses 35008 51086 +16078
+ Partials 7571 5180 -2391
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.22% <44.82%> (-12.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `38.59% <53.33%> (-32.84%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `52.88% <35.71%> (-26.43%)` | :arrow_down: |
... and [1632 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307950748
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `1.72414%` with `57 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.98%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 3.57% | [24 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (288aad1). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (288aad1) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 53.98% -14.87%
+ Complexity 28468 12361 -16107
=============================================
Files 2477 1430 -1047
Lines 136691 71572 -65119
Branches 16634 8124 -8510
=============================================
- Hits 94112 38641 -55471
+ Misses 35008 29473 -5535
+ Partials 7571 3458 -4113
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `15.55% <3.57%> (-63.76%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.14% <0.00%> (-65.29%)` | :arrow_down: |
... and [1823 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303357588
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.84%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|11|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.84% 47.84% -21.01%
+ Complexity 28468 16441 -12027
=============================================
Files 2477 2017 -460
Lines 136691 113311 -23380
Branches 16634 14455 -2179
=============================================
- Hits 94109 54212 -39897
- Misses 35011 53401 +18390
+ Partials 7571 5698 -1873
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.63% <25.00%> (-16.74%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <56.25%> (-13.55%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.33% <12.50%> (-25.98%)` | :arrow_down: |
... and [1544 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305511594
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `40.54054%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.40%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 51.72% | [7 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [0 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (266cbd9). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (266cbd9) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 46.40% -22.45%
+ Complexity 28468 15347 -13121
=============================================
Files 2477 1971 -506
Lines 136691 108245 -28446
Branches 16634 13274 -3360
=============================================
- Hits 94112 50228 -43884
- Misses 35008 52655 +17647
+ Partials 7571 5362 -2209
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <40.54%> (-12.24%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `52.38% <0.00%> (-26.93%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `39.82% <51.72%> (-31.61%)` | :arrow_down: |
... and [1620 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4305705650
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.81%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`266cbd9`](https://app.codecov.io/gh/apache/hudi/commit/266cbd9e50951dde68b23c4adc9d9742ffb01ae9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.81% -0.04%
+ Complexity 28468 28461 -7
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16649 +15
============================================
- Hits 94112 94100 -12
- Misses 35008 35080 +72
+ Partials 7571 7569 -2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.34% <32.43%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.29% <62.16%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.03% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [22 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306768862
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `55.88235%` with `30 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.10%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 64.81% | [12 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 45.10% -23.75%
+ Complexity 28468 15610 -12858
=============================================
Files 2477 2017 -460
Lines 136691 113330 -23361
Branches 16634 14464 -2170
=============================================
- Hits 94112 51122 -42990
- Misses 35008 56669 +21661
+ Partials 7571 5539 -2032
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <55.88%> (-12.89%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.03% <21.42%> (-18.28%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `49.27% <64.81%> (-22.16%)` | :arrow_down: |
... and [1596 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307420955
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 06a7f9e8333a73e73b3c1487b1629cd3f1013cc8 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491)
* 839ee5166867c465f7c5d72872a101e26736fe92 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308090772
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.92%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 65.92% -2.93%
+ Complexity 28468 27273 -1195
============================================
Files 2477 2478 +1
Lines 136691 136737 +46
Branches 16634 16653 +19
============================================
- Hits 94112 90147 -3965
- Misses 35008 38954 +3946
- Partials 7571 7636 +65
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.23% <20.68%> (-17.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <70.68%> (-0.29%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `71.11% <53.57%> (-8.20%)` | :arrow_down: |
... and [387 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3134442775
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/avro/HoodieSparkSchemaConverters.scala:
##########
@@ -363,6 +385,31 @@ object HoodieSparkSchemaConverters extends SparkAdapterSupport {
}
}
+ private def matchesStructure(source: DataType, expected: DataType, caseSensitive: Boolean): Boolean =
+ (source, expected) match {
+ case (s: StructType, e: StructType) =>
+ s.length == e.length && s.fields.zip(e.fields).forall { case (sf, ef) =>
+ nameEquals(sf.name, ef.name, caseSensitive) &&
+ matchesStructure(sf.dataType, ef.dataType, caseSensitive)
+ }
+ case _ => source == expected
+ }
+
+ private def nameEquals(a: String, b: String, caseSensitive: Boolean): Boolean =
+ if (caseSensitive) a == b else a.equalsIgnoreCase(b)
+
+ private def withAllFieldsNullable(dataType: DataType): DataType = dataType match {
Review Comment:
🤖 nit: `withAllFieldsNullable` implies it only touches struct fields, but the method also sets `containsNull = true` on arrays and `valueContainsNull = true` on maps — a future reader scanning the name alone might not expect those side effects. Something like `makeFullyNullable` or `forceNullable` would describe the full scope more accurately.
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303854728
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `64.86486%` with `13 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.82%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 75.86% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.82% -0.03%
+ Complexity 28468 28458 -10
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16652 +18
============================================
+ Hits 94112 94115 +3
- Misses 35008 35061 +53
- Partials 7571 7573 +2
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.46% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.40% <32.43%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.28% <62.16%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `72.56% <75.86%> (+1.13%)` | :arrow_up: |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311217910
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.40%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.40% -20.49%
+ Complexity 28532 16749 -11783
=============================================
Files 2479 2018 -461
Lines 136810 113443 -23367
Branches 16660 14492 -2168
=============================================
- Hits 94244 54907 -39337
- Misses 34982 52617 +17635
+ Partials 7584 5919 -1665
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <20.68%> (-16.88%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1537 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311233058
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.41%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 61.41% -7.47%
+ Complexity 28532 25428 -3104
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 84060 -10184
- Misses 34982 45578 +10596
+ Partials 7584 7224 -360
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.20% <20.68%> (-17.29%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.96% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `64.00% <46.42%> (-15.32%)` | :arrow_down: |
... and [543 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311627538
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.94%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 58.94% -9.94%
+ Complexity 28532 24463 -4069
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 80677 -13567
- Misses 34982 49113 +14131
+ Partials 7584 7072 -512
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.20% <20.68%> (-17.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <53.44%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.55% <46.42%> (-15.76%)` | :arrow_down: |
... and [661 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311620090
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.40%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|3|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.40% -20.49%
+ Complexity 28532 16747 -11785
=============================================
Files 2479 2018 -461
Lines 136810 113443 -23367
Branches 16660 14492 -2168
=============================================
- Hits 94244 54909 -39335
- Misses 34982 52612 +17630
+ Partials 7584 5922 -1662
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.61% <20.68%> (-16.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <53.44%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1538 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311634332
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.41%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (c9a5ccd). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (c9a5ccd) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 61.41% -7.47%
+ Complexity 28532 25427 -3105
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 84057 -10187
- Misses 34982 45581 +10599
+ Partials 7584 7224 -360
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.20% <20.68%> (-17.28%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <53.44%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `64.00% <46.42%> (-15.32%)` | :arrow_down: |
... and [543 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306487819
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `47.72727%` with `23 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.60%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6235e1`](https://app.codecov.io/gh/apache/hudi/commit/b6235e1eef6740d98ea9cc72490bb731f9d8e1de?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 21.42% | [0 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (b6235e1). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (b6235e1) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 45.60% -23.25%
+ Complexity 28468 15814 -12654
=============================================
Files 2477 2017 -460
Lines 136691 113306 -23385
Branches 16634 14454 -2180
=============================================
- Hits 94112 51678 -42434
- Misses 35008 55914 +20906
+ Partials 7571 5714 -1857
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <47.72%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.03% <21.42%> (-18.28%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `44.73% <60.00%> (-26.70%)` | :arrow_down: |
... and [1588 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303365360
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `14 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.84%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d3c9220`](https://app.codecov.io/gh/apache/hudi/commit/d3c9220ef21705582d43471b21a6df685ea4d0e9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (d3c9220). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (d3c9220) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|12|4|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.84% 47.84% -21.01%
+ Complexity 28468 16441 -12027
=============================================
Files 2477 2017 -460
Lines 136691 113311 -23380
Branches 16634 14455 -2179
=============================================
- Hits 94110 54214 -39896
- Misses 35010 53400 +18390
+ Partials 7571 5697 -1874
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.80% <ø> (+0.02%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.63% <25.00%> (-16.74%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.76% <56.25%> (-13.55%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.33% <12.50%> (-25.98%)` | :arrow_down: |
... and [1544 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306737083
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.97%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [54 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (06a7f9e). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (06a7f9e) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 53.97% -14.88%
+ Complexity 28468 12362 -16106
=============================================
Files 2477 1430 -1047
Lines 136691 71584 -65107
Branches 16634 8130 -8504
=============================================
- Hits 94112 38641 -55471
+ Misses 35008 29487 -5521
+ Partials 7571 3456 -4115
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `16.43% <0.00%> (-62.88%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `5.07% <0.00%> (-66.36%)` | :arrow_down: |
... and [1823 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306870611
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.64706%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.61%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 77.77% | [4 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 28.57% | [0 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 67.61% -1.24%
+ Complexity 28468 27901 -567
============================================
Files 2477 2478 +1
Lines 136691 136749 +58
Branches 16634 16659 +25
============================================
- Hits 94112 92467 -1645
- Misses 35008 36774 +1766
+ Partials 7571 7508 -63
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.30% <44.11%> (-4.13%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <66.17%> (-0.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.52% <28.57%> (-2.79%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.91% <77.77%> (+2.48%)` | :arrow_up: |
... and [199 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311694813
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.00%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 68.00% -0.89%
+ Complexity 28532 28149 -383
============================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
============================================
- Hits 94244 93075 -1169
- Misses 34982 36144 +1162
- Partials 7584 7643 +59
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.55% <43.10%> (-3.93%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4302591840
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `65.62500%` with `11 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 25.00% | [0 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.76% -0.09%
+ Complexity 28462 28399 -63
============================================
Files 2475 2475
Lines 136580 136611 +31
Branches 16613 16629 +16
============================================
- Hits 94041 93941 -100
- Misses 34977 35116 +139
+ Partials 7562 7554 -8
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.38% <31.25%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.16% <62.50%> (-0.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `77.14% <25.00%> (-2.17%)` | :arrow_down: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308043551
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.89%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (288aad1). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (288aad1) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|1|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 58.89% -9.96%
+ Complexity 28468 24423 -4045
============================================
Files 2477 2478 +1
Lines 136691 136737 +46
Branches 16634 16653 +19
============================================
- Hits 94112 80538 -13574
- Misses 35008 49105 +14097
+ Partials 7571 7094 -477
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.31% <18.96%> (-16.12%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <53.44%> (-12.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `63.55% <46.42%> (-15.76%)` | :arrow_down: |
... and [666 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289498866
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.67%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.67% -0.19%
+ Complexity 28449 28336 -113
============================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
============================================
- Hits 93985 93744 -241
- Misses 34953 35258 +305
+ Partials 7561 7507 -54
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.08% <40.00%> (-0.33%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.19% <90.00%> (-0.13%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [35 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "rahil-c (via GitHub)" <gi...@apache.org>.
rahil-c commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3119626765
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,30 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach custom Hudi logical-type metadata (e.g. VECTOR, BLOB) from `targetSchema` onto
+ * matching fields of `sourceSchema`, by name. Spark's TableOutputResolver wraps INSERT outputs
+ * in Cast(...) which drops the StructField metadata that marks these custom types. Without
+ * re-attaching, downstream conversion to HoodieSchema yields the backing physical type
+ * (e.g. plain ARRAY) and the schema-compat check against the persisted tableCreateSchema fails.
+ */
+ def enrichWithCustomTypeMetadata(sourceSchema: StructType, targetSchema: StructType): StructType = {
+ val targetByName = targetSchema.fields.map(f => f.name -> f).toMap
Review Comment:
@voonhous i think this might be a good point from the agent to consider. If its a larger change maybe leaving a comment and some followup would be ideal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4293830556
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34b7555383976f932baa24bc0631fb610924cf9d Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412)
* f104c57b7539e59468aea3171f531fdd0e70f980 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295600307
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69b7c9779c03f08f664eeb8d6c79395886db883c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433)
* bd7672c304cdf9889be3fb0c797651a69053e39c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289599160
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.85%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=========================================
Coverage 68.85% 68.85%
- Complexity 28449 28456 +7
=========================================
Files 2475 2475
Lines 136499 136509 +10
Branches 16594 16595 +1
=========================================
+ Hits 93985 93993 +8
- Misses 34953 34959 +6
+ Partials 7561 7557 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.47% <0.00%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.40% <40.00%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <90.00%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.40% <90.00%> (+1.97%)` | :arrow_up: |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3121599367
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,30 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach custom Hudi logical-type metadata (e.g. VECTOR, BLOB) from `targetSchema` onto
+ * matching fields of `sourceSchema`, by name. Spark's TableOutputResolver wraps INSERT outputs
+ * in Cast(...) which drops the StructField metadata that marks these custom types. Without
+ * re-attaching, downstream conversion to HoodieSchema yields the backing physical type
+ * (e.g. plain ARRAY) and the schema-compat check against the persisted tableCreateSchema fails.
+ */
+ def enrichWithCustomTypeMetadata(sourceSchema: StructType, targetSchema: StructType): StructType = {
+ val targetByName = targetSchema.fields.map(f => f.name -> f).toMap
Review Comment:
Addressed.
##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala:
##########
@@ -111,7 +111,9 @@ object InsertIntoHoodieTableCommand extends Logging with ProvidesHoodieConfig wi
}
val config = buildHoodieInsertConfig(catalogTable, sparkSession, isOverWritePartition, isOverWriteTable, partitionSpec, extraOptions, staticOverwritePartitionPathOpt)
- val df = sparkSession.internalCreateDataFrame(query.execute(), query.schema)
+ val enrichedSchema = HoodieSchemaConversionUtils.enrichWithCustomTypeMetadata(
+ query.schema, catalogTable.tableSchemaWithoutMetaFields)
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294062877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f104c57b7539e59468aea3171f531fdd0e70f980 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430)
* 69b7c9779c03f08f664eeb8d6c79395886db883c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294151905
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.97%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (69b7c97). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (69b7c97) |
>|------|------|------|
>|spark-scala-tests|7|5|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 65.85% 58.97% -6.89%
+ Complexity 27205 24414 -2791
============================================
Files 2475 2475
Lines 136566 136590 +24
Branches 16611 16623 +12
============================================
- Hits 89938 80548 -9390
- Misses 39100 48989 +9889
+ Partials 7528 7053 -475
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <33.33%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <70.83%> (-12.08%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `70.37% <70.83%> (-1.06%)` | :arrow_down: |
... and [456 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294156505
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.44%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 65.85% 61.44% -4.42%
+ Complexity 27205 25378 -1827
============================================
Files 2475 2475
Lines 136566 136590 +24
Branches 16611 16623 +12
============================================
- Hits 89938 83929 -6009
- Misses 39100 45456 +6356
+ Partials 7528 7205 -323
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <33.33%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <70.83%> (-12.08%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `70.37% <70.83%> (-1.06%)` | :arrow_down: |
... and [305 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294162044
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.16667%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.91%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 65.97% 65.91% -0.07%
+ Complexity 27278 27230 -48
============================================
Files 2475 2475
Lines 136566 136590 +24
Branches 16611 16623 +12
============================================
- Hits 90106 90038 -68
- Misses 38876 38924 +48
- Partials 7584 7628 +44
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.22% <33.33%> (+<0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <79.16%> (-0.12%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
... and [66 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294230723
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.16667%` with `5 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 79.16% | [1 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.77% -0.08%
+ Complexity 28460 28387 -73
============================================
Files 2475 2475
Lines 136580 136604 +24
Branches 16613 16625 +12
============================================
- Hits 94036 93944 -92
- Misses 34980 35112 +132
+ Partials 7564 7548 -16
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.36% <33.33%> (+0.05%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.17% <79.16%> (-0.14%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.01% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.14% <79.16%> (+1.71%)` | :arrow_up: |
... and [32 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4295830963
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.12500%` with `15 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.31%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd7672c`](https://app.codecov.io/gh/apache/hudi/commit/bd7672c304cdf9889be3fb0c797651a69053e39c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (bd7672c). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (bd7672c) |
>|------|------|------|
>|spark-java-tests|15|2|
>|spark-scala-tests|10|5|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 48.31% -20.54%
+ Complexity 28462 16694 -11768
=============================================
Files 2475 2015 -460
Lines 136580 113200 -23380
Branches 16613 14434 -2179
=============================================
- Hits 94041 54697 -39344
- Misses 34977 52593 +17616
+ Partials 7562 5910 -1652
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.99% <25.00%> (-16.44%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.89% <53.12%> (-12.43%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `70.37% <70.83%> (-1.06%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `57.14% <0.00%> (-22.17%)` | :arrow_down: |
... and [1536 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4312672756
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.88%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c9a5ccd`](https://app.codecov.io/gh/apache/hudi/commit/c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=========================================
Coverage 68.88% 68.88%
+ Complexity 28532 28519 -13
=========================================
Files 2479 2479
Lines 136810 136862 +52
Branches 16660 16687 +27
=========================================
+ Hits 94244 94280 +36
- Misses 34982 34986 +4
- Partials 7584 7596 +12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.41% <1.72%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.49% <43.10%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.35% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.97% <1.72%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303705852
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.81%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 48.81% -20.04%
+ Complexity 28468 16465 -12003
=============================================
Files 2477 1988 -489
Lines 136691 110683 -26008
Branches 16634 13893 -2741
=============================================
- Hits 94112 54027 -40085
- Misses 35008 50943 +15935
+ Partials 7571 5713 -1858
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.41% <27.02%> (-16.02%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.98% <54.05%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.33% <12.50%> (-25.98%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `68.14% <65.51%> (-3.29%)` | :arrow_down: |
... and [1556 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4303692610
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `54.05405%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.85%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4729eef`](https://app.codecov.io/gh/apache/hudi/commit/4729eef1a150bf906ccb01b5943fc3903ab3adb0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 65.51% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 12.50% | [0 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (4729eef). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (4729eef) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 46.85% -22.00%
+ Complexity 28468 15146 -13322
=============================================
Files 2477 1953 -524
Lines 136691 105794 -30897
Branches 16634 12811 -3823
=============================================
- Hits 94112 49572 -44540
- Misses 35008 51069 +16061
+ Partials 7571 5153 -2418
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.23% <54.05%> (-12.08%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `51.90% <12.50%> (-27.41%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `42.47% <65.51%> (-28.96%)` | :arrow_down: |
... and [1647 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4306958252
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.64706%` with `22 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.63%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`06a7f9e`](https://app.codecov.io/gh/apache/hudi/commit/06a7f9e8333a73e73b3c1487b1629cd3f1013cc8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 77.77% | [4 Missing and 8 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 28.57% | [0 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.63% -0.22%
+ Complexity 28468 28342 -126
============================================
Files 2477 2478 +1
Lines 136691 136777 +86
Branches 16634 16663 +29
============================================
- Hits 94112 93877 -235
- Misses 35008 35406 +398
+ Partials 7571 7494 -77
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.37% <44.11%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <66.17%> (-0.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.99% <0.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.52% <28.57%> (-2.79%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `73.91% <77.77%> (+2.48%)` | :arrow_up: |
... and [48 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4307801663
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.77%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (7f4dd31) and HEAD (288aad1). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (7f4dd31) | HEAD (288aad1) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 44.77% -24.08%
+ Complexity 28468 8508 -19960
=============================================
Files 2477 1200 -1277
Lines 136691 62477 -74214
Branches 16634 6754 -9880
=============================================
- Hits 94112 27974 -66138
+ Misses 35008 31444 -3564
+ Partials 7571 3059 -4512
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2078 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4308222960
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.81%. Comparing base ([`7f4dd31`](https://app.codecov.io/gh/apache/hudi/commit/7f4dd319616504e3973c68c29b042989fa03e4ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`288aad1`](https://app.codecov.io/gh/apache/hudi/commit/288aad1b3d8f8ae825841f3a56b1b2cccff761ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.85% 68.81% -0.04%
+ Complexity 28468 28448 -20
============================================
Files 2477 2478 +1
Lines 136691 136737 +46
Branches 16634 16653 +19
============================================
- Hits 94112 94096 -16
- Misses 35008 35074 +66
+ Partials 7571 7567 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <1.72%> (-0.01%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.51% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.10% <43.10%> (-0.34%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.38% <70.68%> (+0.07%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.00% <1.72%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [40 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4311205336
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `29 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.76%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ee559eb`](https://app.codecov.io/gh/apache/hudi/commit/ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 39.28% | [7 Missing and 10 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (ee559eb). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (ee559eb) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|14|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.76% -20.13%
+ Complexity 28532 16470 -12062
=============================================
Files 2479 1988 -491
Lines 136810 110820 -25990
Branches 16660 13931 -2729
=============================================
- Hits 94244 54041 -40203
- Misses 34982 51061 +16079
+ Partials 7584 5718 -1866
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.44% <1.72%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.37% <20.68%> (-16.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <50.00%> (-12.33%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `66.66% <60.00%> (-4.77%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `53.77% <39.28%> (-25.54%)` | :arrow_down: |
... and [1555 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294135753
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.66%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (0d57435) and HEAD (69b7c97). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (0d57435) | HEAD (69b7c97) |
>|------|------|------|
>|spark-java-tests|5|3|
>|spark-scala-tests|6|4|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 65.70% 58.66% -7.04%
+ Complexity 27129 24246 -2883
============================================
Files 2475 2475
Lines 136566 136590 +24
Branches 16611 16623 +12
============================================
- Hits 89732 80133 -9599
- Misses 39341 49511 +10170
+ Partials 7493 6946 -547
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.45% <0.00%> (-0.02%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.62% <33.33%> (+0.40%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.93% <70.83%> (-11.79%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `69.44% <70.83%> (-1.99%)` | :arrow_down: |
... and [465 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294110600
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.43%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 47.93% 48.43% +0.49%
+ Complexity 16555 16311 -244
============================================
Files 2015 1997 -18
Lines 113169 110816 -2353
Branches 14418 13920 -498
============================================
- Hits 54253 53675 -578
+ Misses 53218 51524 -1694
+ Partials 5698 5617 -81
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.38% <33.33%> (+0.77%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.10% <70.83%> (+0.65%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `66.66% <70.83%> (-3.58%)` | :arrow_down: |
... and [80 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4294103336
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.83333%` with `7 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.88%. Comparing base ([`0d57435`](https://app.codecov.io/gh/apache/hudi/commit/0d5743510b679e0c759dffaf52eb8d11d209bf69?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`69b7c97`](https://app.codecov.io/gh/apache/hudi/commit/69b7c9779c03f08f664eeb8d6c79395886db883c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 70.83% | [3 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 47.86% 48.88% +1.01%
+ Complexity 16534 16111 -423
============================================
Files 2015 1980 -35
Lines 113169 108304 -4865
Branches 14418 13349 -1069
============================================
- Hits 54165 52940 -1225
+ Misses 53289 49906 -3383
+ Partials 5715 5458 -257
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.77% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.38% <33.33%> (+0.05%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.18% <70.83%> (+0.73%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `65.74% <70.83%> (-0.93%)` | :arrow_down: |
... and [229 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18540:
URL: https://github.com/apache/hudi/pull/18540#discussion_r3117949566
##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/hudi/command/InsertIntoHoodieTableCommand.scala:
##########
@@ -111,7 +111,9 @@ object InsertIntoHoodieTableCommand extends Logging with ProvidesHoodieConfig wi
}
val config = buildHoodieInsertConfig(catalogTable, sparkSession, isOverWritePartition, isOverWriteTable, partitionSpec, extraOptions, staticOverwritePartitionPathOpt)
- val df = sparkSession.internalCreateDataFrame(query.execute(), query.schema)
+ val enrichedSchema = HoodieSchemaConversionUtils.enrichWithCustomTypeMetadata(
+ query.schema, catalogTable.tableSchemaWithoutMetaFields)
Review Comment:
🤖 `enrichWithCustomTypeMetadata` matches fields via an exact-name `toMap` lookup. With `spark.sql.caseSensitive=true` and a differently-cased column name, the lookup would silently miss and the custom-type metadata wouldn't be restored, reproducing the original failure. Worth either doing case-insensitive lookup using the session's resolver, or confirming that `query.schema` names are already normalized to match the catalog schema here.
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,30 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach custom Hudi logical-type metadata (e.g. VECTOR, BLOB) from `targetSchema` onto
+ * matching fields of `sourceSchema`, by name. Spark's TableOutputResolver wraps INSERT outputs
+ * in Cast(...) which drops the StructField metadata that marks these custom types. Without
+ * re-attaching, downstream conversion to HoodieSchema yields the backing physical type
+ * (e.g. plain ARRAY) and the schema-compat check against the persisted tableCreateSchema fails.
+ */
+ def enrichWithCustomTypeMetadata(sourceSchema: StructType, targetSchema: StructType): StructType = {
Review Comment:
🤖 nit: the Javadoc says "Re-attach" but the method is called `enrichWith...` — "enrich" suggests adding brand-new information, whereas this is really restoring metadata that was stripped by Spark. Could you rename it to `reattachCustomTypeMetadata` (or `restoreCustomTypeMetadata`) to match the documented intent?
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieSchemaConversionUtils.scala:
##########
@@ -145,6 +145,30 @@ object HoodieSchemaConversionUtils {
}
}
+ /**
+ * Re-attach custom Hudi logical-type metadata (e.g. VECTOR, BLOB) from `targetSchema` onto
+ * matching fields of `sourceSchema`, by name. Spark's TableOutputResolver wraps INSERT outputs
+ * in Cast(...) which drops the StructField metadata that marks these custom types. Without
+ * re-attaching, downstream conversion to HoodieSchema yields the backing physical type
+ * (e.g. plain ARRAY) and the schema-compat check against the persisted tableCreateSchema fails.
+ */
+ def enrichWithCustomTypeMetadata(sourceSchema: StructType, targetSchema: StructType): StructType = {
+ val targetByName = targetSchema.fields.map(f => f.name -> f).toMap
Review Comment:
🤖 This only re-attaches `hudi_type` on top-level fields. If a custom-typed column is ever allowed inside a nested `StructType` (or `ArrayType<Struct>` / `MapType`), `Cast` will strip that inner metadata too and this helper won't restore it. VECTOR is forbidden from nesting, but is the same true for BLOB and any future custom types? Might be worth either recursing into nested `StructType` here, or adding a comment that this is intentionally top-level-only.
<sub><i>- Generated by an AI agent and may contain mistakes. Please verify any suggestions before applying.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289027567
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34b7555383976f932baa24bc0631fb610924cf9d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4289310632
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `10 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.88%. Comparing base ([`59fee58`](https://app.codecov.io/gh/apache/hudi/commit/59fee58a71a264b546a7a159981d679259bd6aba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`34b7555`](https://app.codecov.io/gh/apache/hudi/commit/34b7555383976f932baa24bc0631fb610924cf9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (59fee58) and HEAD (34b7555). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (59fee58) | HEAD (34b7555) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.85% 53.88% -14.97%
+ Complexity 28449 12317 -16132
=============================================
Files 2475 1428 -1047
Lines 136499 71386 -65113
Branches 16594 8073 -8521
=============================================
- Hits 93985 38469 -55516
+ Misses 34953 29476 -5477
+ Partials 7561 3441 -4120
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.78% <ø> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.40% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `7.44% <0.00%> (-63.99%)` | :arrow_down: |
... and [1824 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322646218
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
+ Coverage 68.88% 68.89% +0.01%
- Complexity 28532 28579 +47
============================================
Files 2479 2482 +3
Lines 136810 137105 +295
Branches 16660 16737 +77
============================================
+ Hits 94244 94462 +218
- Misses 34982 35021 +39
- Partials 7584 7622 +38
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.36% <1.72%> (-0.08%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.41% <43.10%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <70.68%> (+0.04%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.91% <1.72%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [33 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321406545
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 44.75%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 7 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (4a72e7f). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (4a72e7f) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 44.75% -24.14%
+ Complexity 28532 8499 -20033
=============================================
Files 2479 1201 -1278
Lines 136810 62608 -74202
Branches 16660 6778 -9882
=============================================
- Hits 94244 28021 -66223
+ Misses 34982 31511 -3471
+ Partials 7584 3076 -4508
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 2080 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321462524
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.91%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
============================================
- Coverage 68.88% 65.91% -2.98%
+ Complexity 28532 27336 -1196
============================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
============================================
- Hits 94244 90336 -3908
- Misses 34982 39043 +4061
- Partials 7584 7668 +84
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.17% <20.68%> (-17.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.10% <70.68%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `71.11% <53.57%> (-8.20%)` | :arrow_down: |
... and [371 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4321516413
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.68966%` with `17 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.89%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4a72e7f`](https://app.codecov.io/gh/apache/hudi/commit/4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 53.57% | [2 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 86.66% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
==========================================
Coverage 68.88% 68.89%
- Complexity 28532 28575 +43
==========================================
Files 2479 2480 +1
Lines 136810 137047 +237
Branches 16660 16718 +58
==========================================
+ Hits 94244 94420 +176
- Misses 34982 35013 +31
- Partials 7584 7614 +30
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <1.72%> (-0.06%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <ø> (+<0.01%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.46% <1.72%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.47% <43.10%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <70.68%> (+0.03%)` | :arrow_up: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.92% <1.72%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `75.43% <86.66%> (+4.01%)` | :arrow_up: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `76.88% <53.57%> (-2.43%)` | :arrow_down: |
... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322545993
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
}, {
"hash" : "873d4aefc68214948ee600469ed64e6d20e48004",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529",
"triggerID" : "873d4aefc68214948ee600469ed64e6d20e48004",
"triggerType" : "PUSH"
}, {
"hash" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530",
"triggerID" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"triggerType" : "PUSH"
}, {
"hash" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604",
"triggerID" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"triggerType" : "PUSH"
}, {
"hash" : "48694abcc64b1f376301b1588049c09f8771ebdf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13617",
"triggerID" : "48694abcc64b1f376301b1588049c09f8771ebdf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604)
* 48694abcc64b1f376301b1588049c09f8771ebdf Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13617)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322539852
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "34b7555383976f932baa24bc0631fb610924cf9d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13412",
"triggerID" : "34b7555383976f932baa24bc0631fb610924cf9d",
"triggerType" : "PUSH"
}, {
"hash" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13430",
"triggerID" : "f104c57b7539e59468aea3171f531fdd0e70f980",
"triggerType" : "PUSH"
}, {
"hash" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13433",
"triggerID" : "69b7c9779c03f08f664eeb8d6c79395886db883c",
"triggerType" : "PUSH"
}, {
"hash" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13437",
"triggerID" : "bd7672c304cdf9889be3fb0c797651a69053e39c",
"triggerType" : "PUSH"
}, {
"hash" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13475",
"triggerID" : "a5c777d4168cf7128dd19f8ae6d5e06b1f20b6f8",
"triggerType" : "PUSH"
}, {
"hash" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13477",
"triggerID" : "d3c9220ef21705582d43471b21a6df685ea4d0e9",
"triggerType" : "PUSH"
}, {
"hash" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13479",
"triggerID" : "4729eef1a150bf906ccb01b5943fc3903ab3adb0",
"triggerType" : "PUSH"
}, {
"hash" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13485",
"triggerID" : "266cbd9e50951dde68b23c4adc9d9742ffb01ae9",
"triggerType" : "PUSH"
}, {
"hash" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13488",
"triggerID" : "b6235e1eef6740d98ea9cc72490bb731f9d8e1de",
"triggerType" : "PUSH"
}, {
"hash" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13491",
"triggerID" : "06a7f9e8333a73e73b3c1487b1629cd3f1013cc8",
"triggerType" : "PUSH"
}, {
"hash" : "839ee5166867c465f7c5d72872a101e26736fe92",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13495",
"triggerID" : "839ee5166867c465f7c5d72872a101e26736fe92",
"triggerType" : "PUSH"
}, {
"hash" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13498",
"triggerID" : "288aad1b3d8f8ae825841f3a56b1b2cccff761ba",
"triggerType" : "PUSH"
}, {
"hash" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13526",
"triggerID" : "ee559ebfcda9213cc0ce19d99cbfa64c8853ef4c",
"triggerType" : "PUSH"
}, {
"hash" : "873d4aefc68214948ee600469ed64e6d20e48004",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13529",
"triggerID" : "873d4aefc68214948ee600469ed64e6d20e48004",
"triggerType" : "PUSH"
}, {
"hash" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13530",
"triggerID" : "c9a5ccd4dbde8bc9f6249a80fe6b1d26ba66e51c",
"triggerType" : "PUSH"
}, {
"hash" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604",
"triggerID" : "4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8",
"triggerType" : "PUSH"
}, {
"hash" : "48694abcc64b1f376301b1588049c09f8771ebdf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "48694abcc64b1f376301b1588049c09f8771ebdf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a72e7f6eccf802cceeba530dc089d0b5cc9d2f8 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13604)
* 48694abcc64b1f376301b1588049c09f8771ebdf UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322611256
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `53.44828%` with `27 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.33%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 46.42% | [2 Missing and 13 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 60.00% | [8 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (48694ab). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (48694ab) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|14|1|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 48.33% -20.55%
+ Complexity 28532 16768 -11764
=============================================
Files 2479 2021 -458
Lines 136810 113683 -23127
Branches 16660 14542 -2118
=============================================
- Hits 94244 54953 -39291
- Misses 34982 52786 +17804
+ Partials 7584 5944 -1640
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.33% <20.68%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.90% <53.44%> (-12.39%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `67.54% <60.00%> (-3.89%)` | :arrow_down: |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `61.77% <46.42%> (-17.54%)` | :arrow_down: |
... and [1544 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(vector): Preserve VECTOR/BLOB metadata on SQL INSERT path [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18540:
URL: https://github.com/apache/hudi/pull/18540#issuecomment-4322598636
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `1.72414%` with `57 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.95%. Comparing base ([`edaa168`](https://app.codecov.io/gh/apache/hudi/commit/edaa16820b7b103a7342506c196da1754d0fdfe2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`48694ab`](https://app.codecov.io/gh/apache/hudi/commit/48694abcc64b1f376301b1588049c09f8771ebdf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 8 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | 3.57% | [24 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (edaa168) and HEAD (48694ab). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (edaa168) | HEAD (48694ab) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|spark-java-tests|14|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18540 +/- ##
=============================================
- Coverage 68.88% 53.95% -14.93%
+ Complexity 28532 12394 -16138
=============================================
Files 2479 1433 -1046
Lines 136810 71888 -64922
Branches 16660 8191 -8469
=============================================
- Hits 94244 38790 -55454
+ Misses 34982 29623 -5359
+ Partials 7584 3475 -4109
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <ø> (+0.08%)` | :arrow_up: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <1.72%> (-0.05%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18540?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...e/spark/sql/avro/HoodieSparkSchemaConverters.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fspark%2Fsql%2Favro%2FHoodieSparkSchemaConverters.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9zcGFyay9zcWwvYXZyby9Ib29kaWVTcGFya1NjaGVtYUNvbnZlcnRlcnMuc2NhbGE=) | `15.55% <3.57%> (-63.76%)` | :arrow_down: |
| [.../org/apache/hudi/HoodieSchemaConversionUtils.scala](https://app.codecov.io/gh/apache/hudi/pull/18540?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FHoodieSchemaConversionUtils.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9odWRpL0hvb2RpZVNjaGVtYUNvbnZlcnNpb25VdGlscy5zY2FsYQ==) | `6.14% <0.00%> (-65.29%)` | :arrow_down: |
... and [1827 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org