[GitHub] [superset] zhaoyongjie commented on a diff in pull request #19600: fix: Add 1 month to quaterly time grain

[GitBox <gi...@apache.org>]

zhaoyongjie commented on code in PR #19600:
URL: https://github.com/apache/superset/pull/19600#discussion_r845705862


##########
superset/db_engine_specs/netezza.py:
##########
@@ -31,7 +31,7 @@ class NetezzaEngineSpec(PostgresBaseEngineSpec):
         "P1D": "DATE_TRUNC('day', {col})",
         "P1W": "DATE_TRUNC('week', {col})",
         "P1M": "DATE_TRUNC('month', {col})",
-        "P3M": "DATE_TRUNC('quarter', {col})",
+        "P3M": "ADD_MONTHS(DATE_TRUNC('quarter', {col}), 1)",

Review Comment:
   This is a breaking change, and I don't think a quarter plus 1 mouth is a correct solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org