You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by GitBox <gi...@apache.org> on 2022/05/09 10:37:55 UTC
[GitHub] [jmeter] vlsi opened a new pull request, #712: Use kotlinx-coroutines for UI launcher
vlsi opened a new pull request, #712:
URL: https://github.com/apache/jmeter/pull/712
## Description
This PR moves `startGui` from `class JMeter` to another class.
## Motivation and Context
a) It is nice to factor UI from non-UI code
b) Current code fails to update progress during "GUI startup". The reason is that all the contents of `startGui` is running in a single `Runnable`, so Swing has no way to break in-between and render progress updates.
See https://bz.apache.org/bugzilla/show_bug.cgi?id=66044#c5
Coroutines enable an easy-to-maintain approach for splitting long UI methods into chunks.
In this case, I used `yield()` right after `setProgress`, so we give room for the Swing event dispatcher thread to update the UI.
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [ ] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a diff in pull request #712: Use kotlinx-coroutines for UI launcher
Posted by GitBox <gi...@apache.org>.
vlsi commented on code in PR #712:
URL: https://github.com/apache/jmeter/pull/712#discussion_r867880630
##########
src/core/src/main/java/org/apache/jmeter/JMeterGuiLauncher.kt:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.jmeter
+
+import com.thoughtworks.xstream.converters.ConversionException
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.GlobalScope
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.runBlocking
+import kotlinx.coroutines.swing.Swing
+import kotlinx.coroutines.withContext
+import kotlinx.coroutines.yield
+import org.apache.jmeter.gui.GuiPackage
+import org.apache.jmeter.gui.MainFrame
+import org.apache.jmeter.gui.action.ActionNames
+import org.apache.jmeter.gui.action.ActionRouter
+import org.apache.jmeter.gui.action.Load
+import org.apache.jmeter.gui.action.LookAndFeelCommand
+import org.apache.jmeter.gui.tree.JMeterTreeListener
+import org.apache.jmeter.gui.tree.JMeterTreeModel
+import org.apache.jmeter.gui.util.FocusRequester
+import org.apache.jmeter.save.SaveService
+import org.apache.jmeter.services.FileServer
+import org.apache.jmeter.util.JMeterUtils
+import org.apache.jorphan.collections.HashTree
+import org.apache.jorphan.gui.ComponentUtil
+import org.apache.jorphan.gui.JMeterUIDefaults
+import org.apache.jorphan.gui.ui.KerningOptimizer
+import org.slf4j.LoggerFactory
+import java.awt.event.ActionEvent
+import java.io.File
+
+public object JMeterGuiLauncher {
+ private val log = LoggerFactory.getLogger(JMeterGuiLauncher::class.java)
+
+ /**
+ * Starts up JMeter in GUI mode
+ */
+ @JvmStatic
+ public fun startGui(testFile: String?) {
+ println("================================================================================") //NOSONAR
+ println("Don't use GUI mode for load testing !, only for Test creation and Test debugging.") //NOSONAR
+ println("For load testing, use CLI Mode (was NON GUI):") //NOSONAR
+ println(" jmeter -n -t [jmx file] -l [results file] -e -o [Path to web report folder]") //NOSONAR
+ println("& increase Java Heap to meet your test requirements:") //NOSONAR
+ println(" Modify current env variable HEAP=\"-Xms1g -Xmx1g -XX:MaxMetaspaceSize=256m\" in the jmeter batch file") //NOSONAR
+ println("Check : https://jmeter.apache.org/usermanual/best-practices.html") //NOSONAR
+ println("================================================================================") //NOSONAR
+
+ runBlocking {
+ // See https://github.com/Kotlin/kotlinx.coroutines/blob/master/ui/coroutines-guide-ui.md
+ launch(Dispatchers.Swing) {
+ setupLaF()
+ val splash = SplashScreen()
+ splash.showScreen()
+ setProgress(splash, 10)
+ JMeterUtils.applyHiDPIOnFonts()
+ setProgress(splash, 20)
+ startGuiPartTwo(testFile, splash)
+ }
+ }
+ }
+
+ private fun setupLaF() {
+ KerningOptimizer.INSTANCE.maxTextLengthWithKerning =
+ JMeterUtils.getPropDefault("text.kerning.max_document_size", 10000)
+ JMeterUIDefaults.INSTANCE.install()
+ val jMeterLaf = LookAndFeelCommand.getPreferredLafCommand()
+ try {
+ log.info("Setting LAF to: {}", jMeterLaf)
+ LookAndFeelCommand.activateLookAndFeel(jMeterLaf)
+ } catch (ex: IllegalArgumentException) {
+ log.warn("Could not set LAF to: {}", jMeterLaf, ex)
+ }
+ }
+
+ private suspend fun startGuiPartTwo(testFile: String?, splash: SplashScreen) {
+ log.debug("Configure PluginManager")
+ setProgress(splash, 30)
+ log.debug("Setup tree")
+ val treeModel = JMeterTreeModel()
+ val treeLis = JMeterTreeListener(treeModel)
+ val instance = ActionRouter.getInstance()
+ setProgress(splash, 40)
+ log.debug("populate command map")
+ instance.populateCommandMap()
+ setProgress(splash, 60)
+ treeLis.setActionHandler(instance)
+ log.debug("init instance")
+ setProgress(splash, 70)
+ GuiPackage.initInstance(treeLis, treeModel)
+ setProgress(splash, 80)
+ log.debug("constructing main frame")
+ val main = MainFrame(treeModel, treeLis)
+ setProgress(splash, 100)
+ ComponentUtil.centerComponentInWindow(main, 80)
+ main.setLocationRelativeTo(splash)
+ main.isVisible = true
+ main.toFront()
+ instance.actionPerformed(ActionEvent(main, 1, ActionNames.ADD_ALL))
+ if (testFile != null) {
+ try {
+ val f: File
+ val tree: HashTree?
+ withContext(Dispatchers.Default) {
+ f = File(testFile)
+ log.info("Loading file: {}", f)
+ FileServer.getFileServer().setBaseForScript(f)
+ tree = SaveService.loadTree(f)
+ }
+ GuiPackage.getInstance().testPlanFile = f.absolutePath
+ Load.insertLoadedTree(1, tree)
+ } catch (e: ConversionException) {
+ log.error("Failure loading test file", e)
+ splash.close()
+ JMeterUtils.reportErrorToUser(SaveService.CEtoString(e))
+ } catch (e: Exception) {
+ log.error("Failure loading test file", e)
+ splash.close()
+ JMeterUtils.reportErrorToUser(e.toString())
+ }
+ } else {
+ val jTree = GuiPackage.getInstance().mainFrame.tree
+ val path = jTree.getPathForRow(0)
+ jTree.selectionPath = path
+ FocusRequester.requestFocus(jTree)
+ }
+ setProgress(splash, 100)
+ splash.close()
+ }
+
+ private suspend fun setProgress(splash: SplashScreen, progress: Int) {
+ splash.setProgress(progress)
+ // Allow UI updates
+ yield()
Review Comment:
@FSchumacher , this enables to make a brief pause in the execution of the current coroutine, and it immediately schedules the continuation. That allows Swing EDT to update the UI.
The code in `startGuiPartTwo` looks sequential, however, in practice, it is split into a sequence of chunks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi merged pull request #712: Use kotlinx-coroutines for UI launcher
Posted by GitBox <gi...@apache.org>.
vlsi merged PR #712:
URL: https://github.com/apache/jmeter/pull/712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #712: Use kotlinx-coroutines for UI launcher
Posted by GitBox <gi...@apache.org>.
vlsi commented on PR #712:
URL: https://github.com/apache/jmeter/pull/712#issuecomment-1123799975
@pmouawad , @FSchumacher , team. do you have any thoughts/comments? I think this is pretty much mergeable, except I would like to make `JMeterGuiLauncher` private or something like that.
I really like how coroutine-swing enables sequential code that is executed in chunks and moved across thread pools via `withContext` as needed (UI thread vs computation thread).
I am fine if this is merged after 5.5 release, however, including the change in 5.5 might work as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a diff in pull request #712: Use kotlinx-coroutines for UI launcher
Posted by GitBox <gi...@apache.org>.
vlsi commented on code in PR #712:
URL: https://github.com/apache/jmeter/pull/712#discussion_r867881621
##########
src/core/src/main/java/org/apache/jmeter/JMeterGuiLauncher.kt:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.jmeter
+
+import com.thoughtworks.xstream.converters.ConversionException
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.GlobalScope
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.runBlocking
+import kotlinx.coroutines.swing.Swing
+import kotlinx.coroutines.withContext
+import kotlinx.coroutines.yield
+import org.apache.jmeter.gui.GuiPackage
+import org.apache.jmeter.gui.MainFrame
+import org.apache.jmeter.gui.action.ActionNames
+import org.apache.jmeter.gui.action.ActionRouter
+import org.apache.jmeter.gui.action.Load
+import org.apache.jmeter.gui.action.LookAndFeelCommand
+import org.apache.jmeter.gui.tree.JMeterTreeListener
+import org.apache.jmeter.gui.tree.JMeterTreeModel
+import org.apache.jmeter.gui.util.FocusRequester
+import org.apache.jmeter.save.SaveService
+import org.apache.jmeter.services.FileServer
+import org.apache.jmeter.util.JMeterUtils
+import org.apache.jorphan.collections.HashTree
+import org.apache.jorphan.gui.ComponentUtil
+import org.apache.jorphan.gui.JMeterUIDefaults
+import org.apache.jorphan.gui.ui.KerningOptimizer
+import org.slf4j.LoggerFactory
+import java.awt.event.ActionEvent
+import java.io.File
+
+public object JMeterGuiLauncher {
+ private val log = LoggerFactory.getLogger(JMeterGuiLauncher::class.java)
+
+ /**
+ * Starts up JMeter in GUI mode
+ */
+ @JvmStatic
+ public fun startGui(testFile: String?) {
+ println("================================================================================") //NOSONAR
+ println("Don't use GUI mode for load testing !, only for Test creation and Test debugging.") //NOSONAR
+ println("For load testing, use CLI Mode (was NON GUI):") //NOSONAR
+ println(" jmeter -n -t [jmx file] -l [results file] -e -o [Path to web report folder]") //NOSONAR
+ println("& increase Java Heap to meet your test requirements:") //NOSONAR
+ println(" Modify current env variable HEAP=\"-Xms1g -Xmx1g -XX:MaxMetaspaceSize=256m\" in the jmeter batch file") //NOSONAR
+ println("Check : https://jmeter.apache.org/usermanual/best-practices.html") //NOSONAR
+ println("================================================================================") //NOSONAR
+
+ runBlocking {
+ // See https://github.com/Kotlin/kotlinx.coroutines/blob/master/ui/coroutines-guide-ui.md
+ launch(Dispatchers.Swing) {
+ setupLaF()
+ val splash = SplashScreen()
+ splash.showScreen()
+ setProgress(splash, 10)
+ JMeterUtils.applyHiDPIOnFonts()
+ setProgress(splash, 20)
+ startGuiPartTwo(testFile, splash)
+ }
+ }
+ }
+
+ private fun setupLaF() {
+ KerningOptimizer.INSTANCE.maxTextLengthWithKerning =
+ JMeterUtils.getPropDefault("text.kerning.max_document_size", 10000)
+ JMeterUIDefaults.INSTANCE.install()
+ val jMeterLaf = LookAndFeelCommand.getPreferredLafCommand()
+ try {
+ log.info("Setting LAF to: {}", jMeterLaf)
+ LookAndFeelCommand.activateLookAndFeel(jMeterLaf)
+ } catch (ex: IllegalArgumentException) {
+ log.warn("Could not set LAF to: {}", jMeterLaf, ex)
+ }
+ }
+
+ private suspend fun startGuiPartTwo(testFile: String?, splash: SplashScreen) {
+ log.debug("Configure PluginManager")
+ setProgress(splash, 30)
+ log.debug("Setup tree")
+ val treeModel = JMeterTreeModel()
+ val treeLis = JMeterTreeListener(treeModel)
+ val instance = ActionRouter.getInstance()
+ setProgress(splash, 40)
+ log.debug("populate command map")
+ instance.populateCommandMap()
+ setProgress(splash, 60)
+ treeLis.setActionHandler(instance)
+ log.debug("init instance")
+ setProgress(splash, 70)
+ GuiPackage.initInstance(treeLis, treeModel)
+ setProgress(splash, 80)
+ log.debug("constructing main frame")
+ val main = MainFrame(treeModel, treeLis)
+ setProgress(splash, 100)
+ ComponentUtil.centerComponentInWindow(main, 80)
+ main.setLocationRelativeTo(splash)
+ main.isVisible = true
+ main.toFront()
+ instance.actionPerformed(ActionEvent(main, 1, ActionNames.ADD_ALL))
+ if (testFile != null) {
+ try {
+ val f: File
+ val tree: HashTree?
+ withContext(Dispatchers.Default) {
+ f = File(testFile)
+ log.info("Loading file: {}", f)
+ FileServer.getFileServer().setBaseForScript(f)
+ tree = SaveService.loadTree(f)
+ }
Review Comment:
This is how switching between "regular thread pool" and "Swing event dispatcher" would look like. The code within `withContext(Dispatchers.Default)` is executed outside of the EDT, and then the execution moves back to the EDT.
##########
src/core/src/main/java/org/apache/jmeter/JMeterGuiLauncher.kt:
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.jmeter
+
+import com.thoughtworks.xstream.converters.ConversionException
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.GlobalScope
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.runBlocking
+import kotlinx.coroutines.swing.Swing
+import kotlinx.coroutines.withContext
+import kotlinx.coroutines.yield
+import org.apache.jmeter.gui.GuiPackage
+import org.apache.jmeter.gui.MainFrame
+import org.apache.jmeter.gui.action.ActionNames
+import org.apache.jmeter.gui.action.ActionRouter
+import org.apache.jmeter.gui.action.Load
+import org.apache.jmeter.gui.action.LookAndFeelCommand
+import org.apache.jmeter.gui.tree.JMeterTreeListener
+import org.apache.jmeter.gui.tree.JMeterTreeModel
+import org.apache.jmeter.gui.util.FocusRequester
+import org.apache.jmeter.save.SaveService
+import org.apache.jmeter.services.FileServer
+import org.apache.jmeter.util.JMeterUtils
+import org.apache.jorphan.collections.HashTree
+import org.apache.jorphan.gui.ComponentUtil
+import org.apache.jorphan.gui.JMeterUIDefaults
+import org.apache.jorphan.gui.ui.KerningOptimizer
+import org.slf4j.LoggerFactory
+import java.awt.event.ActionEvent
+import java.io.File
+
+public object JMeterGuiLauncher {
+ private val log = LoggerFactory.getLogger(JMeterGuiLauncher::class.java)
+
+ /**
+ * Starts up JMeter in GUI mode
+ */
+ @JvmStatic
+ public fun startGui(testFile: String?) {
+ println("================================================================================") //NOSONAR
+ println("Don't use GUI mode for load testing !, only for Test creation and Test debugging.") //NOSONAR
+ println("For load testing, use CLI Mode (was NON GUI):") //NOSONAR
+ println(" jmeter -n -t [jmx file] -l [results file] -e -o [Path to web report folder]") //NOSONAR
+ println("& increase Java Heap to meet your test requirements:") //NOSONAR
+ println(" Modify current env variable HEAP=\"-Xms1g -Xmx1g -XX:MaxMetaspaceSize=256m\" in the jmeter batch file") //NOSONAR
+ println("Check : https://jmeter.apache.org/usermanual/best-practices.html") //NOSONAR
+ println("================================================================================") //NOSONAR
+
+ runBlocking {
+ // See https://github.com/Kotlin/kotlinx.coroutines/blob/master/ui/coroutines-guide-ui.md
+ launch(Dispatchers.Swing) {
+ setupLaF()
+ val splash = SplashScreen()
+ splash.showScreen()
+ setProgress(splash, 10)
+ JMeterUtils.applyHiDPIOnFonts()
+ setProgress(splash, 20)
+ startGuiPartTwo(testFile, splash)
+ }
+ }
+ }
+
+ private fun setupLaF() {
+ KerningOptimizer.INSTANCE.maxTextLengthWithKerning =
+ JMeterUtils.getPropDefault("text.kerning.max_document_size", 10000)
+ JMeterUIDefaults.INSTANCE.install()
+ val jMeterLaf = LookAndFeelCommand.getPreferredLafCommand()
+ try {
+ log.info("Setting LAF to: {}", jMeterLaf)
+ LookAndFeelCommand.activateLookAndFeel(jMeterLaf)
+ } catch (ex: IllegalArgumentException) {
+ log.warn("Could not set LAF to: {}", jMeterLaf, ex)
+ }
+ }
+
+ private suspend fun startGuiPartTwo(testFile: String?, splash: SplashScreen) {
+ log.debug("Configure PluginManager")
+ setProgress(splash, 30)
+ log.debug("Setup tree")
+ val treeModel = JMeterTreeModel()
+ val treeLis = JMeterTreeListener(treeModel)
+ val instance = ActionRouter.getInstance()
+ setProgress(splash, 40)
+ log.debug("populate command map")
+ instance.populateCommandMap()
+ setProgress(splash, 60)
+ treeLis.setActionHandler(instance)
+ log.debug("init instance")
+ setProgress(splash, 70)
+ GuiPackage.initInstance(treeLis, treeModel)
+ setProgress(splash, 80)
+ log.debug("constructing main frame")
+ val main = MainFrame(treeModel, treeLis)
+ setProgress(splash, 100)
+ ComponentUtil.centerComponentInWindow(main, 80)
+ main.setLocationRelativeTo(splash)
+ main.isVisible = true
+ main.toFront()
+ instance.actionPerformed(ActionEvent(main, 1, ActionNames.ADD_ALL))
+ if (testFile != null) {
+ try {
+ val f: File
+ val tree: HashTree?
+ withContext(Dispatchers.Default) {
+ f = File(testFile)
+ log.info("Loading file: {}", f)
+ FileServer.getFileServer().setBaseForScript(f)
+ tree = SaveService.loadTree(f)
+ }
Review Comment:
This is what switching between "regular thread pool" and "Swing event dispatcher" would look like. The code within `withContext(Dispatchers.Default)` is executed outside of the EDT, and then the execution moves back to the EDT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] codecov-commenter commented on pull request #712: Use kotlinx-coroutines for UI launcher
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #712:
URL: https://github.com/apache/jmeter/pull/712#issuecomment-1121605827
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#712](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa57a6e) into [master](https://codecov.io/gh/apache/jmeter/commit/aaead67610cd61d486d6ae54dab7b05338bcf40a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aaead67) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head aa57a6e differs from pull request most recent head 52b8c3d. Consider uploading reports for the commit 52b8c3d to get more accurate results
[](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #712 +/- ##
============================================
- Coverage 55.22% 55.22% -0.01%
+ Complexity 10381 10379 -2
============================================
Files 1061 1062 +1
Lines 65762 65760 -2
Branches 7531 7533 +2
============================================
- Hits 36320 36313 -7
- Misses 26842 26849 +7
+ Partials 2600 2598 -2
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...c/core/src/main/java/org/apache/jmeter/JMeter.java](https://codecov.io/gh/apache/jmeter/pull/712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9KTWV0ZXIuamF2YQ==) | `42.79% <0.00%> (+4.42%)` | :arrow_up: |
| [...c/main/java/org/apache/jmeter/JMeterGuiLauncher.kt](https://codecov.io/gh/apache/jmeter/pull/712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9KTWV0ZXJHdWlMYXVuY2hlci5rdA==) | `0.00% <0.00%> (ø)` | |
| [...ter/protocol/http/proxy/SamplerCreatorFactory.java](https://codecov.io/gh/apache/jmeter/pull/712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L1NhbXBsZXJDcmVhdG9yRmFjdG9yeS5qYXZh) | `27.90% <0.00%> (-13.96%)` | :arrow_down: |
| [...jmeter/report/processor/ErrorsSummaryConsumer.java](https://codecov.io/gh/apache/jmeter/pull/712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9yZXBvcnQvcHJvY2Vzc29yL0Vycm9yc1N1bW1hcnlDb25zdW1lci5qYXZh) | `94.64% <0.00%> (-1.73%)` | :arrow_down: |
| [...ter/protocol/http/proxy/DefaultSamplerCreator.java](https://codecov.io/gh/apache/jmeter/pull/712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3Byb3RvY29sL2h0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2ptZXRlci9wcm90b2NvbC9odHRwL3Byb3h5L0RlZmF1bHRTYW1wbGVyQ3JlYXRvci5qYXZh) | `54.12% <0.00%> (-0.52%)` | :arrow_down: |
| [.../apache/jmeter/threads/openmodel/scheduleParser.kt](https://codecov.io/gh/apache/jmeter/pull/712/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmUvc3JjL21haW4va290bGluL29yZy9hcGFjaGUvam1ldGVyL3RocmVhZHMvb3Blbm1vZGVsL3NjaGVkdWxlUGFyc2VyLmt0) | `69.60% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [cbacd08...52b8c3d](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org