You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2020/01/30 21:31:39 UTC
Review Request 72067: Improved performance of v1 agent operator API
GET_STATE call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72067/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Greg Mann.
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description
-------
This follow the same approach used for the master's v1 calls:
https://github.com/apache/mesos/commit/1c60f0e4acbac96c34bd90e26515
https://github.com/apache/mesos/commit/3dda3622f5ed01e8c132dc5ca594
That is, serializing directly to protobuf or json from the in-memory
v0 state.
Diffs
-----
src/slave/http.hpp 0afdad9479f0cc2c94452b6b1f2289dd6ea01494
src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488
Diff: https://reviews.apache.org/r/72067/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 72067: Improved performance of v1 agent operator
API GET_STATE call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72067/#review219648
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Sekretenko
On Jan. 30, 2020, 9:31 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72067/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2020, 9:31 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Greg Mann.
>
>
> Bugs: MESOS-10026
> https://issues.apache.org/jira/browse/MESOS-10026
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This follow the same approach used for the master's v1 calls:
>
> https://github.com/apache/mesos/commit/1c60f0e4acbac96c34bd90e26515
> https://github.com/apache/mesos/commit/3dda3622f5ed01e8c132dc5ca594
>
> That is, serializing directly to protobuf or json from the in-memory
> v0 state.
>
>
> Diffs
> -----
>
> src/slave/http.hpp 0afdad9479f0cc2c94452b6b1f2289dd6ea01494
> src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488
>
>
> Diff: https://reviews.apache.org/r/72067/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>