You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by tzolkincz <gi...@git.apache.org> on 2014/10/19 23:34:22 UTC

[GitHub] phoenix pull request: PHOENIX-1344 fix duplicit values in NTH_VALU...

GitHub user tzolkincz opened a pull request:

    https://github.com/apache/phoenix/pull/24

    PHOENIX-1344 fix duplicit values in NTH_VALUE function

    I've fixed issue PHOENIX-1344, but there is one thing: the NTH_VALUE function is not deterministic now.  Nondeterministic come to light when nth value could be any of values as long as "ordered by" values are duplicit. Methond getDeterminism is implemented in parent: AggregateFunction and returns Determinism.PER_ROW. Is that ok?
    I've used LinkedList (over ArrayDeque) for storing multiple values to one "ordered by" key cos LinkedList can hold null values and there can be in future switch for respect null values.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzolkincz/phoenix fix_1344

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/phoenix/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 980c65d251cccd80a87e54449a1afe4a550a6448
Author: Vaclav Loffelmann <va...@socialbakers.com>
Date:   2014-10-19T15:18:00Z

    PHOENIX-1344 fix duplicit values in NTH_VALUE function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request: PHOENIX-1344 fix duplicit values in NTH_VALU...

Posted by tzolkincz <gi...@git.apache.org>.
Github user tzolkincz commented on the pull request:

    https://github.com/apache/phoenix/pull/24#issuecomment-59688396
  
    integrated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] phoenix pull request: PHOENIX-1344 fix duplicit values in NTH_VALU...

Posted by tzolkincz <gi...@git.apache.org>.
Github user tzolkincz closed the pull request at:

    https://github.com/apache/phoenix/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---