[GitHub] [beam] tweise commented on a change in pull request #12133: [BEAM-10385] Integrate SQL expansion into Flink job server

[GitBox <gi...@apache.org>]

tweise commented on a change in pull request #12133:
URL: https://github.com/apache/beam/pull/12133#discussion_r449298751



##########
File path: sdks/python/apache_beam/transforms/sql.py
##########
@@ -67,10 +66,9 @@ class SqlTransform(ExternalTransform):
   """
   URN = 'beam:external:java:sql:v1'
 
-  def __init__(self, query, dialect=None):
+  def __init__(self, query, dialect=None, expansion_service=None):
     super(SqlTransform, self).__init__(
         self.URN,
         NamedTupleBasedPayloadBuilder(
             SqlTransformSchema(query=query, dialect=dialect)),
-        BeamJarExpansionService(
-            ':sdks:java:extensions:sql:expansion-service:shadowJar'))
+        expansion_service=expansion_service)

Review comment:
       If the goal is to make things easier/flexible for developers, then convenience built into Gradle tasks may be a good option. Users would probably find it rather problematic if by default there is an attempt to pull down artifacts behind the scenes and execute them. That is probably also going to fail within isolated production environments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org