[GitHub] [hudi] nsivabalan commented on a diff in pull request #8557: [HUDI-5895] Remove bootstrap key generator configs

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #8557:
URL: https://github.com/apache/hudi/pull/8557#discussion_r1186754142


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -411,6 +411,11 @@ object DataSourceWriteOptions {
     .markAdvanced()
     .withDocumentation("Key generator class, that implements `org.apache.hudi.keygen.KeyGenerator`")
 
+  val KEYGENERATOR_TYPE: ConfigProperty[String] = ConfigProperty
+    .key("hoodie.datasource.write.keygenerator.type")
+    .defaultValue(KeyGeneratorType.SIMPLE.name)
+    .withDocumentation("Key generator type.")

Review Comment:
   we might need to add more docs here. for eg, which one takes precedence among the key gen class and key gen type. thats why we removed it sometime back. 
   whats the real need to add it back ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org