You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "greatsharp (via GitHub)" <gi...@apache.org> on 2025/10/12 03:23:53 UTC
[PR] Improve the failover efficiency [kvrocks-controller]
greatsharp opened a new pull request, #362:
URL: https://github.com/apache/kvrocks-controller/pull/362
This enhancement can improve the failover efficiency when a lots of master node probe failed concurrently.
Since there is only one can UpdateCluster successfully each time, we should reset the failure count after UpdateCluster successfully, and can do failover later again, there is no need to wait more than 15 seconds(ping_interval_seconds*max_ping_count).
For example, if 3 master node doing failover concurrently, it will cost more than 45 seconds before, but now it is 18 seconds (12s + 3s + 3s).
BTW, we should enlarge the minIdleConns to each node, this can save time in acquiring new connections when doing probe and sync cluster topology to all nodes, 10 is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve the failover efficiency [kvrocks-controller]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #362:
URL: https://github.com/apache/kvrocks-controller/pull/362#issuecomment-3393891284
@greatsharp Thanks for your improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve the failover efficiency [kvrocks-controller]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #362:
URL: https://github.com/apache/kvrocks-controller/pull/362#issuecomment-3393895084
## [Codecov](https://app.codecov.io/gh/apache/kvrocks-controller/pull/362?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `50.00000%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.28%. Comparing base ([`6c56470`](https://app.codecov.io/gh/apache/kvrocks-controller/commit/6c564700d621ef30a182bad1bfeff0aa13db6ea7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`0bfb1d2`](https://app.codecov.io/gh/apache/kvrocks-controller/commit/0bfb1d2a9de5df9f6ecfaee212d94b47dd997b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 97 commits behind head on unstable.
| [Files with missing lines](https://app.codecov.io/gh/apache/kvrocks-controller/pull/362?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [controller/cluster.go](https://app.codecov.io/gh/apache/kvrocks-controller/pull/362?src=pr&el=tree&filepath=controller%2Fcluster.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29udHJvbGxlci9jbHVzdGVyLmdv) | 50.00% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/kvrocks-controller/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## unstable #362 +/- ##
============================================
+ Coverage 43.38% 44.28% +0.89%
============================================
Files 37 45 +8
Lines 2971 4453 +1482
============================================
+ Hits 1289 1972 +683
- Misses 1544 2274 +730
- Partials 138 207 +69
```
| [Flag](https://app.codecov.io/gh/apache/kvrocks-controller/pull/362/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [unittests](https://app.codecov.io/gh/apache/kvrocks-controller/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.28% <50.00%> (+0.89%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kvrocks-controller/pull/362?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve the failover efficiency [kvrocks-controller]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #362:
URL: https://github.com/apache/kvrocks-controller/pull/362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org