You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/01 15:03:13 UTC
[GitHub] [spark] xuanyuanking opened a new pull request #25327:
[SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more
close to its usage
xuanyuanking opened a new pull request #25327: [SPARK-28593][CORE] Rename ShuffleClient to BlockStoreClient which more close to its usage
URL: https://github.com/apache/spark/pull/25327
## What changes were proposed in this pull request?
After SPARK-27677, the shuffle client not only handles the shuffle block but also responsible for local persist RDD blocks. For better code scalability and clear semantics(as the [discussion](https://github.com/apache/spark/pull/24892#discussion_r300173331)), here we rename ShuffleClient to BlockStoreClient. Correspondingly rename the ExternalShuffleClient to ExternalBlockStoreClient, also change the server-side class from ExternalShuffleBlockHandler to ExternalBlockHandler. Note, we still keep the name of BlockTransferService, because the `Service` contains both client and server, also the name of BlockTransferService is not referencing shuffle client only.
## How was this patch tested?
Existing UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org