[jira] [Commented] (FLINK-6941) Selecting window start / end on over window causes field not resolve exception

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053364#comment-16053364 ] 

ASF GitHub Bot commented on FLINK-6941:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/4137

    [FLINK-6941][table]Add validate that the start and end window propert…

     Add validate that the start and end window properties are not accessed on over windows.
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-6941-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4137
    
----
commit 2d5405c684e21cf0a89f390ae9ea9ba762fc2767
Author: sunjincheng121 <su...@gmail.com>
Date:   2017-06-19T00:06:15Z

    [FLINK-6941][table]Add validate that the start and end window properties are not accessed on over windows

----


> Selecting window start / end on over window causes field not resolve exception
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-6941
>                 URL: https://issues.apache.org/jira/browse/FLINK-6941
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> Selecting window start / end on over window causes field not resolve exception.
> The following program:
> {code}
> table
>       .window(
>         Over partitionBy 'c orderBy 'proctime preceding UNBOUNDED_ROW as 'w)
>       .select('c, countFun('b) over 'w, 'w.start, 'w.end)
> {code}
> causes
> {code}
> org.apache.flink.table.api.ValidationException: Cannot resolve [w] given input [a, b, c, proctime].
> 	at org.apache.flink.table.plan.logical.LogicalNode.failValidation(LogicalNode.scala:143)
> 	at org.apache.flink.table.plan.logical.LogicalNode$$anonfun$validate$1.applyOrElse(LogicalNode.scala:86)
> 	at org.apache.flink.table.plan.logical.LogicalNode$$anonfun$validate$1.applyOrElse(LogicalNode.scala:83)
> 	at org.apache.flink.table.plan.TreeNode.postOrderTransform(TreeNode.scala:72)
> 	at org.apache.flink.table.plan.TreeNode$$anonfun$1.apply(TreeNode.scala:46)
> 	at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
> 	at scala.collection.Iterator$class.foreach(Iterator.scala:727)
> 	at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
> 	at scala.collection.generic.Growable$class.$plus$plus$eq(Growable.scala:48)
> {code}
> We should validate that the start and end window properties are not accessed on over windows.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)