You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2018/12/10 22:38:10 UTC

[GitHub] [incubator-dubbo] codecov-io commented on issue #2929: Replace anonymous class with method reference

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=h1) Report
> Merging [#2929](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/107a0cc11ac8fa38986025bb7adec700d5c65482?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `50%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2929      +/-   ##
==========================================
- Coverage   63.92%   63.77%   -0.15%     
==========================================
  Files         578      578              
  Lines       25928    25946      +18     
  Branches     4539     4543       +4     
==========================================
- Hits        16574    16547      -27     
- Misses       7189     7232      +43     
- Partials     2165     2167       +2
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ng/zookeeper/zkclient/ZkclientZookeeperClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvemtjbGllbnQvWmtjbGllbnRab29rZWVwZXJDbGllbnQuamF2YQ==) | `62.5% <0%> (+2.97%)` | :arrow_up: |
| [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `54.31% <0%> (-0.32%)` | :arrow_down: |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `81.95% <100%> (+0.61%)` | :arrow_up: |
| [...org/apache/dubbo/rpc/protocol/rmi/RmiProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1ybWkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9ybWkvUm1pUHJvdG9jb2wuamF2YQ==) | `56.41% <100%> (-1.09%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `75.75% <0%> (-8.25%)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `60.86% <0%> (-6.53%)` | :arrow_down: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `79.48% <0%> (-5.13%)` | :arrow_down: |
| ... and [19 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2929/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=footer). Last update [107a0cc...d7f5a9d](https://codecov.io/gh/apache/incubator-dubbo/pull/2929?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2929 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org