You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/06/02 06:49:25 UTC
[GitHub] [iceberg] coolderli opened a new pull request #2661: Docs: Add commit.status-check on doc.
coolderli opened a new pull request #2661:
URL: https://github.com/apache/iceberg/pull/2661
Add configures to doc: `commit.status-check.num-retries`, `commit.status-check.min-wait-ms`,`commit.status-check.max-wait-ms `,`commit.status-check.total-timeout-ms`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2661: Docs: Add commit.status-check on doc.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2661:
URL: https://github.com/apache/iceberg/pull/2661#issuecomment-864171157
Merged. Thanks, @coolderli!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2661: Docs: Add commit.status-check on doc.
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2661:
URL: https://github.com/apache/iceberg/pull/2661#discussion_r654574530
##########
File path: site/docs/configuration.md
##########
@@ -61,6 +61,10 @@ Iceberg tables support table properties to configure table behavior, like the de
| commit.retry.min-wait-ms | 100 | Minimum time in milliseconds to wait before retrying a commit |
| commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in milliseconds to wait before retrying a commit |
| commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in milliseconds to wait before retrying a commit |
+| commit.status-check.num-retries | 3 | Number of times to check the commit status before failing |
Review comment:
I added a fix for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2661: Docs: Add commit.status-check on doc.
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2661:
URL: https://github.com/apache/iceberg/pull/2661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #2661: Docs: Add commit.status-check on doc.
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #2661:
URL: https://github.com/apache/iceberg/pull/2661#discussion_r650446736
##########
File path: site/docs/configuration.md
##########
@@ -61,6 +61,10 @@ Iceberg tables support table properties to configure table behavior, like the de
| commit.retry.min-wait-ms | 100 | Minimum time in milliseconds to wait before retrying a commit |
| commit.retry.max-wait-ms | 60000 (1 min) | Maximum time in milliseconds to wait before retrying a commit |
| commit.retry.total-timeout-ms | 1800000 (30 min) | Maximum time in milliseconds to wait before retrying a commit |
+| commit.status-check.num-retries | 3 | Number of times to check the commit status before failing |
Review comment:
I think this is a bit too unclear because it isn't clear what "check the commit status" or "failing" mean exactly. I think this should be "Number of times to check whether a commit succeeded after a connection is lost before failing due to an unknown commit state".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] coolderli commented on pull request #2661: Docs: Add commit.status-check on doc.
Posted by GitBox <gi...@apache.org>.
coolderli commented on pull request #2661:
URL: https://github.com/apache/iceberg/pull/2661#issuecomment-852786949
I am not sure if the description of `commit.status-check.total-timeout-ms` and `commit.retry.total-timeout-ms ` are clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org