You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by praveenmeenakshi56 <gi...@git.apache.org> on 2018/07/04 18:27:13 UTC
[GitHub] carbondata pull request #2450: [CARBONDATA-2689] Added validations for compl...
GitHub user praveenmeenakshi56 opened a pull request:
https://github.com/apache/carbondata/pull/2450
[CARBONDATA-2689] Added validations for complex columns in alter set statements
### What was the issue
Alter set statements were not validating complex dataType columns correctly.
### What is the solution
Added a recursive method to validate string and varchar child columns of complex dataType columns.
Added UTs for the same
Dependent on #2422
- [ ] Any interfaces changed?
NA
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
NA
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
UT done, Test cases added
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/praveenmeenakshi56/carbondata local_dict_varchar
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2450.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2450
----
commit bb89f1139ddd1f35bddf541a3d701c0c1cc33c0b
Author: brijoobopanna <br...@...>
Date: 2018-06-27T09:22:46Z
Added Validations for Complex datatype columns for local dictionary include and exclude
Added test cases for local dictionary support for alter table,set, unset and preaggregate
commit 7884a436f20d0660d61b6c8bb0e1313ad240cb68
Author: praveenmeenakshi56 <pr...@...>
Date: 2018-07-04T18:22:46Z
Added check for Complex Type columns and added Test cases for alter statements
----
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2450
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6893/
---
[GitHub] carbondata pull request #2450: [CARBONDATA-2689] Added validations for compl...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2450#discussion_r200269178
--- Diff: integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/CreateTableWithLocalDictionaryTestCase.scala ---
@@ -242,6 +225,7 @@ class CreateTableWithLocalDictionaryTestCase extends QueryTest with BeforeAndAft
descLoc.find(_.get(0).toString.contains("Local Dictionary Enabled")) match {
case Some(row) => assert(row.get(1).toString.contains("true"))
}
+ sql("desc formatted local1").show(truncate = false)
--- End diff --
avoid .show in test cases
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2450
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5664/
---
[GitHub] carbondata pull request #2450: [CARBONDATA-2689] Added validations for compl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2450
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2450
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5620/
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2450
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5662/
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2450
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5660/
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2450
LGTM
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2450
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5673/
---
[GitHub] carbondata pull request #2450: [CARBONDATA-2689] Added validations for compl...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2450#discussion_r200610555
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/localdictionary/LocalDictionarySupportAlterTableTest.scala ---
@@ -822,17 +821,17 @@ class LocalDictionarySupportAlterTableTest extends QueryTest with BeforeAndAfter
sql(
"""
| CREATE TABLE local1(id int, name string, city string, age int,add string)
- | STORED BY 'carbondata' tblproperties('local_dictionary_include'='city')
+ | STORED BY 'carbondata' tblproperties('local_dictionary_exclude'='city')
--- End diff --
change local_dictionary_exclude to local_dictionary_include as the name suggests
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2450
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6770/
---
[GitHub] carbondata issue #2450: [CARBONDATA-2689] Added validations for complex colu...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2450
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5592/
---