You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/05/03 23:05:55 UTC

[GitHub] [thrift] eranrund opened a new pull request, #2598: Update ordered-float dependency to latest version

eranrund opened a new pull request, #2598:
URL: https://github.com/apache/thrift/pull/2598

   Version 2.0.0 had RUSTSEC advisory, see https://github.com/rustsec/advisory-db/blob/main/crates/ordered-float/RUSTSEC-2020-0082.md
   
   2.0.1 resolved the issue but I figured this is a good opportunity to move to the latest version.
   
   I did not create a JIRA issue since this is a trivial change, but I am happy to do that if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist commented on pull request #2598: Update ordered-float dependency to latest version

Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2598:
URL: https://github.com/apache/thrift/pull/2598#issuecomment-1172846733

   > @Jimexist Does your last comment still stand? Should the rust Github Actions PR be merged first, and then this one?
   
   my plan is to get:
   - #2628 
   
   merged first then i can fix and merge
   - #2594 
   
   which will then catch all future rust related code changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist merged pull request #2598: Update ordered-float dependency to latest version

Posted by GitBox <gi...@apache.org>.
Jimexist merged PR #2598:
URL: https://github.com/apache/thrift/pull/2598


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jimexist commented on pull request #2598: Update ordered-float dependency to latest version

Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2598:
URL: https://github.com/apache/thrift/pull/2598#issuecomment-1119189757

   one thing we can do before merge is to rebase this onto or merge first:
   - #2594 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] allengeorge commented on pull request #2598: Update ordered-float dependency to latest version

Posted by GitBox <gi...@apache.org>.
allengeorge commented on PR #2598:
URL: https://github.com/apache/thrift/pull/2598#issuecomment-1172470936

   @Jimexist Does your last comment still stand? Should the rust Github Actions PR be merged first, and then this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org