[jira] [Comment Edited] (BIGTOP-1316) enhance Shell for better checking of return code & output logging

["jay vyas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033391#comment-14033391 ] 

jay vyas edited comment on BIGTOP-1316 at 6/17/14 3:19 AM:
-----------------------------------------------------------

okay , well if I do {{patch -p1 < ....}} this applies cleanly.  But in bigtop we usually are able to apply patches doing "git am".

Do we support any kind of patch (p0 p1 git ....) [~cos] ?   Im asking because im currently writing the BIGTOP-1249 automated validator, and it failed to apply the patch (because it tried to do {{git am}} instead of {{patch -p0 <}}).  

Currently in our wiki, we suggest people create patches using git {{git format-patch HEAD^..HEAD --stdout > BIGTOP-1031.patch}}.

.... regarding the **contents** of the patch : they seem good as per your responses  above.


was (Author: jayunit100):
okay , well if I do {{patch -p1 < ....}} this applies cleanly.  But in bigtop we usually are able to apply patches doing "git am".

Do we support any kind of patch (p0 p1 git ....) [~cos] ?   Im asking because im currently writing the BIGTOP-1249 automated validator, and it failed to apply the patch (because it tried to do {{git am}} instead of {{patch -p0 <}}).  

Currently in our wiki, we suggest people create patches using git {{ git format-patch HEAD^..HEAD --stdout > BIGTOP-1031.

.... regarding the **contents** of the patch : they seem good as per your responses  above.

> enhance Shell for better checking of return code & output logging
> -----------------------------------------------------------------
>
>                 Key: BIGTOP-1316
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1316
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 0.8.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: BIGTOP-1316-001.patch
>
>
> for the slider tests, we extended Shell with [SliderShellhttps://svn.apache.org/viewvc/incubator/slider/trunk/slider-funtest/src/main/groovy/org/apache/slider/funtest/framework/SliderShell.groovy?view=markup], adding some more features. Some of those are biased towards executing our entry point, but there are some useful core features worth pulling up to the base class
> # {{toString()}} and {{dump()}} methods with diagnostics
> # return code sign correction and assertion checking
> # construction of bash environment and command lines
> The bash setup could be done with a class {{Bash extends Shell}} which is designed purely for bash execution



--
This message was sent by Atlassian JIRA
(v6.2#6252)