You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/03/07 11:09:40 UTC

[GitHub] [incubator-apisix] totemofwolf opened a new pull request #1215: doc: add export `PERL5LIB` env for running test cases

totemofwolf opened a new pull request #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215
 
 
   
   ### Full changelog
   
   * add export `PERL5LIB` env for running test cases
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1215: doc: add export `PERL5LIB` env for running test cases

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215#discussion_r389247379
 
 

 ##########
 File path: doc/how-to-build-cn.md
 ##########
 @@ -106,6 +106,7 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集：
+    * 追加当前目录到PERL模块目录：`export PERL5LIB=.:$PERL5LIB`
 
 Review comment:
   it seems `perl`  is better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] sshniro commented on issue #1215: doc: add export `PERL5LIB` env for running test cases

Posted by GitBox <gi...@apache.org>.
sshniro commented on issue #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215#issuecomment-598165926
 
 
   This addition will be useful because for Ubuntu this env config is needed to run the test cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1215: doc: add export `PERL5LIB` env for running test cases

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215#discussion_r389247329
 
 

 ##########
 File path: doc/how-to-build-cn.md
 ##########
 @@ -106,6 +106,7 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集：
+    * 追加当前目录到PERL模块目录：`export PERL5LIB=.:$PERL5LIB`
 
 Review comment:
   add a space between Chinese and English.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] totemofwolf commented on issue #1215: doc: add export `PERL5LIB` env for running test cases

Posted by GitBox <gi...@apache.org>.
totemofwolf commented on issue #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215#issuecomment-598494321
 
 
   > This addition will be useful because for Ubuntu this env config is needed to run the test cases.
   
   So does MacOSX.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on issue #1215: doc: add export `PERL5LIB` env for running test cases

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215#issuecomment-596177340
 
 
   why we need this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming merged pull request #1215: doc: add export `PERL5LIB` env for running test cases

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #1215: doc: add export `PERL5LIB` env for running test cases

Posted by GitBox <gi...@apache.org>.
totemofwolf commented on a change in pull request #1215: doc: add export `PERL5LIB` env for running test cases
URL: https://github.com/apache/incubator-apisix/pull/1215#discussion_r389251142
 
 

 ##########
 File path: doc/how-to-build-cn.md
 ##########
 @@ -106,6 +106,7 @@ Makefile rules:
 2. 然后通过 cpanm 来安装 test-gninx：`sudo cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)`
 3. 然后 clone 最新的源码：`git clone https://github.com/openresty/test-nginx.git`
 4. 通过 perl 的 `prove` 命令来加载 test-nginx 的库，并运行 `/t` 目录下的测试案例集：
+    * 追加当前目录到PERL模块目录：`export PERL5LIB=.:$PERL5LIB`
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services