You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by misakuo <gi...@git.apache.org> on 2017/10/18 11:47:30 UTC
[GitHub] incubator-weex pull request #806: * [android] fix crash when set box-shadow ...
GitHub user misakuo opened a pull request:
https://github.com/apache/incubator-weex/pull/806
* [android] fix crash when set box-shadow on horizontal scroller
The ScrollView and HorizontalScrollView can host only one child, so we can not add box-shadow host view as it's child view
Test case:
http://dotwe.org/vue/6bc1c6eae6ec927e1bd97c5ee2e18720
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/misakuo/incubator-weex android-feature-boxshadow
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/806.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #806
----
commit 7f6203c9b6a4c398cce6584cd9da1689bb14e5ba
Author: misakuo <mi...@apache.org>
Date: 2017-10-18T11:44:50Z
* [android] fix crash when set box-shadow on horizontal scroller
----
---
[GitHub] incubator-weex pull request #806: * [android] fix crash when set box-shadow ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/806
---
[GitHub] incubator-weex issue #806: * [android] fix crash when set box-shadow on hori...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/806
<!--
0 failure:
2 warning: No Changelog chan..., This PR should up...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
<tr>
<td>:warning:</td>
<td>This PR should update related documents as well. </td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---