You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by cm...@apache.org on 2013/10/02 02:33:21 UTC

svn commit: r1528285 - /hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfsDisable.java

Author: cmccabe
Date: Wed Oct  2 00:33:20 2013
New Revision: 1528285

URL: http://svn.apache.org/r1528285
Log:
HADOOP-9758.  Provide configuration option for FS/FC symlink resolution.  (Andrew Wang via Colin Patrick McCabe)

Added:
    hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfsDisable.java

Added: hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfsDisable.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfsDisable.java?rev=1528285&view=auto
==============================================================================
--- hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfsDisable.java (added)
+++ hadoop/common/branches/branch-2.1-beta/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestSymlinkHdfsDisable.java Wed Oct  2 00:33:20 2013
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.fs;
+
+import static org.junit.Assert.fail;
+
+import java.io.IOException;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hdfs.DFSTestUtil;
+import org.apache.hadoop.hdfs.DistributedFileSystem;
+import org.apache.hadoop.hdfs.HdfsConfiguration;
+import org.apache.hadoop.hdfs.MiniDFSCluster;
+import org.apache.hadoop.test.GenericTestUtils;
+import org.junit.Test;
+
+public class TestSymlinkHdfsDisable {
+
+  @Test(timeout=60000)
+  public void testSymlinkHdfsDisable() throws Exception {
+    Configuration conf = new HdfsConfiguration();
+    // disable symlink resolution
+    conf.setBoolean(
+        CommonConfigurationKeys.FS_CLIENT_RESOLVE_REMOTE_SYMLINKS_KEY, false);
+    // spin up minicluster, get dfs and filecontext
+    MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf).build();
+    DistributedFileSystem dfs = cluster.getFileSystem();
+    FileContext fc = FileContext.getFileContext(cluster.getURI(0), conf);
+    // Create test files/links
+    FileContextTestHelper helper = new FileContextTestHelper();
+    Path root = helper.getTestRootPath(fc);
+    Path target = new Path(root, "target");
+    Path link = new Path(root, "link");
+    DFSTestUtil.createFile(dfs, target, 4096, (short)1, 0xDEADDEAD);
+    fc.createSymlink(target, link, false);
+
+    // Try to resolve links with FileSystem and FileContext
+    try {
+      fc.open(link);
+      fail("Expected error when attempting to resolve link");
+    } catch (IOException e) {
+      GenericTestUtils.assertExceptionContains("resolution is disabled", e);
+    }
+    try {
+      dfs.open(link);
+      fail("Expected error when attempting to resolve link");
+    } catch (IOException e) {
+      GenericTestUtils.assertExceptionContains("resolution is disabled", e);
+    }
+  }
+}