You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by ma...@apache.org on 2014/09/06 06:47:02 UTC
[4/5] git commit: Add plugin aliases to JMS appender.
Add plugin aliases to JMS appender.
- Now this plugin will work with old config formats!
- Implements LOG4J2-815.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a1ea15b4
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a1ea15b4
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a1ea15b4
Branch: refs/heads/messaging-module
Commit: a1ea15b44283f09a2122c034abb2da61f6457966
Parents: 4827cdb
Author: Matt Sicker <ma...@apache.org>
Authored: Fri Sep 5 23:46:24 2014 -0500
Committer: Matt Sicker <ma...@apache.org>
Committed: Fri Sep 5 23:46:24 2014 -0500
----------------------------------------------------------------------
.../apache/logging/log4j/mom/jms/appender/JmsAppender.java | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a1ea15b4/log4j-jms/src/main/java/org/apache/logging/log4j/mom/jms/appender/JmsAppender.java
----------------------------------------------------------------------
diff --git a/log4j-jms/src/main/java/org/apache/logging/log4j/mom/jms/appender/JmsAppender.java b/log4j-jms/src/main/java/org/apache/logging/log4j/mom/jms/appender/JmsAppender.java
index c98e2a1..f99e890 100644
--- a/log4j-jms/src/main/java/org/apache/logging/log4j/mom/jms/appender/JmsAppender.java
+++ b/log4j-jms/src/main/java/org/apache/logging/log4j/mom/jms/appender/JmsAppender.java
@@ -27,6 +27,7 @@ import org.apache.logging.log4j.core.LogEvent;
import org.apache.logging.log4j.core.appender.AbstractAppender;
import org.apache.logging.log4j.core.appender.AppenderLoggingException;
import org.apache.logging.log4j.core.config.plugins.Plugin;
+import org.apache.logging.log4j.core.config.plugins.PluginAliases;
import org.apache.logging.log4j.core.config.plugins.PluginBuilderAttribute;
import org.apache.logging.log4j.core.config.plugins.PluginBuilderFactory;
import org.apache.logging.log4j.core.config.plugins.PluginElement;
@@ -35,10 +36,11 @@ import org.apache.logging.log4j.mom.jms.manager.JmsManager;
import org.apache.logging.log4j.mom.jms.manager.JndiManager;
/**
- * Generic JMS appender plugin for both queues and topics.
+ * Generic JMS Appender plugin for both queues and topics. This Appender replaces the previous split ones. However,
+ * configurations set up for the 2.0 version of the JMS appenders will still work.
*/
@Plugin(name = "JMS", category = "Core", elementType = "appender", printObject = true)
-// TODO: use @PluginAliases to make the separated plugins work through this one
+@PluginAliases({"JMSQueue", "JMSTopic"})
public class JmsAppender extends AbstractAppender {
private final JmsManager manager;
@@ -53,7 +55,7 @@ public class JmsAppender extends AbstractAppender {
}
@Override
- public void append(LogEvent event) {
+ public void append(final LogEvent event) {
try {
final Message message = this.manager.createMessage(getLayout().toSerializable(event));
message.setJMSTimestamp(event.getTimeMillis());
@@ -92,6 +94,7 @@ public class JmsAppender extends AbstractAppender {
private String factoryBindingName;
@PluginBuilderAttribute
+ @PluginAliases({"queueBindingName", "topicBindingName"})
private String destinationBindingName;
@PluginBuilderAttribute