You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by no...@apache.org on 2009/08/06 17:08:36 UTC

svn commit: r801664 - /james/jspf/trunk/tester/src/main/java/org/apache/james/jspf/tester/DNSTestingServerLauncher.java

Author: norman
Date: Thu Aug  6 15:08:36 2009
New Revision: 801664

URL: http://svn.apache.org/viewvc?rev=801664&view=rev
Log:
"Correct usage" of OptionBuilder to eliminate warnings (JSPF-80)

Modified:
    james/jspf/trunk/tester/src/main/java/org/apache/james/jspf/tester/DNSTestingServerLauncher.java

Modified: james/jspf/trunk/tester/src/main/java/org/apache/james/jspf/tester/DNSTestingServerLauncher.java
URL: http://svn.apache.org/viewvc/james/jspf/trunk/tester/src/main/java/org/apache/james/jspf/tester/DNSTestingServerLauncher.java?rev=801664&r1=801663&r2=801664&view=diff
==============================================================================
--- james/jspf/trunk/tester/src/main/java/org/apache/james/jspf/tester/DNSTestingServerLauncher.java (original)
+++ james/jspf/trunk/tester/src/main/java/org/apache/james/jspf/tester/DNSTestingServerLauncher.java Thu Aug  6 15:08:36 2009
@@ -189,36 +189,38 @@
      */
     private static Options generateOptions() {
         Options options = new Options();
-        options.addOption(OptionBuilder
-                .withLongOpt(CMD_IP)
-                .withValueSeparator('=')
-                .hasArg()
-                .withArgName("ip")
-                .withDescription("Listening IP (default: 0.0.0.0 for every IP)")
-                .create(CHAR_IP));
-        options.addOption(OptionBuilder
-                .withLongOpt(CMD_PORT)
-                .withValueSeparator('=')
-                .hasArg()
-                .withArgName("port")
-                .withDescription("Listening port (default: 53)")
-                .create(CHAR_PORT));
-        options.addOption(OptionBuilder
-                .withLongOpt(CMD_FILE)
-                .withValueSeparator('=')
-                .withDescription("YML file name")
-                .withArgName("file")
-                .isRequired()
-                .hasArg()
-                .create(CHAR_FILE));
-        options.addOption(OptionBuilder
-                .withLongOpt(CMD_TESTNAME)
-                .withValueSeparator('=')
-                .hasArg()
-                .withDescription("Test name")
-                .withArgName("test")
-                .isRequired()
-                .create(CHAR_TESTNAME));
+        
+        OptionBuilder.withLongOpt(CMD_IP);
+        OptionBuilder.withValueSeparator('=');
+        OptionBuilder.hasArg();
+        OptionBuilder.withArgName("ip");
+        OptionBuilder.withDescription("Listening IP (default: 0.0.0.0 for every IP)");
+        options.addOption(OptionBuilder.create(CHAR_IP));
+                
+        OptionBuilder.withLongOpt(CMD_PORT);
+        OptionBuilder.withValueSeparator('=');
+        OptionBuilder.hasArg();
+        OptionBuilder.withArgName("port");
+        OptionBuilder.withDescription("Listening port (default: 53)");
+        options.addOption(OptionBuilder.create(CHAR_PORT));
+                
+        OptionBuilder.withLongOpt(CMD_FILE);
+        OptionBuilder.withValueSeparator('=');
+        OptionBuilder.withDescription("YML file name");
+        OptionBuilder.withArgName("file");
+        OptionBuilder.isRequired();
+        OptionBuilder.hasArg();
+        options.addOption(OptionBuilder.create(CHAR_FILE));
+                
+        OptionBuilder.withLongOpt(CMD_TESTNAME);
+        OptionBuilder.withValueSeparator('=');
+        OptionBuilder.hasArg();
+        OptionBuilder.withDescription("Test name");
+        OptionBuilder.withArgName("test");
+        OptionBuilder.isRequired();
+        options.addOption(OptionBuilder.create(CHAR_TESTNAME));
+                
+                
         return options;
     }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org