[GitHub] jlahoda commented on a change in pull request #378: NETBEANS-133: Use explicit loopback address instead of autoselect

[GitBox <gi...@apache.org>]

jlahoda commented on a change in pull request #378: NETBEANS-133: Use explicit loopback address instead of autoselect
URL: https://github.com/apache/incubator-netbeans/pull/378#discussion_r163234940
 
 

 ##########
 File path: jshell.support/src/org/netbeans/modules/jshell/tool/JShellLauncher.java
 ##########
 @@ -249,7 +249,7 @@ protected JShell createJShellInstance() {
             Thread.currentThread().setContextClassLoader(Lookup.getDefault().lookup(ClassLoader.class));
             JShell.Builder b = makeBuilder();
             if (execGen != null) {
-                    b.executionEngine(new CaptureExecControl(execGen), Collections.emptyMap());
+                    b.executionEngine(new CaptureExecControl(execGen), null);
 
 Review comment:
   There's also another overload that does not take the second param that (I guess) has the same meaning. But this is not a big deal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists