You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "pingpingy1 (via GitHub)" <gi...@apache.org> on 2024/02/22 05:27:57 UTC
[PR] Add null guards for DelegatingDatabaseMetaData [commons-dbcp]
pingpingy1 opened a new pull request, #352:
URL: https://github.com/apache/commons-dbcp/pull/352
The class `DelegatingDatabaseMetaData` has two `private final` properties, `databaseMetaData` and `connection`. Their values are provided as arguments to the constructor, but are not guarded against `null` which could propagate and cause NPEs at a later arbitrary time.
This commit implements a fail-fast guard against `null` values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add null guards for DelegatingDatabaseMetaData [commons-dbcp]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #352:
URL: https://github.com/apache/commons-dbcp/pull/352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add null guards for DelegatingDatabaseMetaData [commons-dbcp]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #352:
URL: https://github.com/apache/commons-dbcp/pull/352#issuecomment-1959647558
## [Codecov](https://app.codecov.io/gh/apache/commons-dbcp/pull/352?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`ab6207f`)](https://app.codecov.io/gh/apache/commons-dbcp/commit/ab6207fa63afd33b507e253338f45c8bcff81a40?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 59.81% compared to head [(`99450c2`)](https://app.codecov.io/gh/apache/commons-dbcp/pull/352?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 59.86%.
> Report is 14 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #352 +/- ##
============================================
+ Coverage 59.81% 59.86% +0.05%
- Complexity 1787 1794 +7
============================================
Files 57 57
Lines 7418 7430 +12
Branches 419 423 +4
============================================
+ Hits 4437 4448 +11
Misses 2766 2766
- Partials 215 216 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/commons-dbcp/pull/352?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org