[GitHub] [hbase] Apache9 commented on a diff in pull request #5374: HBASE-28047 Deadlock when opening mob files

["Apache9 (via GitHub)" <gi...@apache.org>]

Apache9 commented on code in PR #5374:
URL: https://github.com/apache/hbase/pull/5374#discussion_r1338129353


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCache.java:
##########
@@ -325,4 +326,8 @@ public void printStatistics() {
     lastEvictedFileCount += evicted;
   }
 
+  private long hashFileName(String fileName) {
+    return Hashing.murmur3_32_fixed().hashString(fileName, java.nio.charset.StandardCharsets.UTF_8)

Review Comment:
   Better use murmur3_128 and finall use asLong to reduce conflicts? We could use long in IdLock.
   And please add comments to say why we use this function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org