You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/01/22 13:19:10 UTC

[PR] Minor: Add publishing datafusion-sqllogictest to release README.md [datafusion]

alamb opened a new pull request, #14233:
URL: https://github.com/apache/datafusion/pull/14233

   ## Which issue does this PR close?
   
   - Related to https://github.com/apache/datafusion/discussions/14229
   
   ## Rationale for this change
   
   Other projects such as rust-iceberg would like to use the datafusion sqllogictest driver to write tests
   
   The code is structured to be published as a crate, and is part of the official release tarballs. We just haven't previously published it to crates. io. 
   
   ## What changes are included in this PR?
   1. Add instructions to release for publishing the datafusion-sqllogictest crates as part of releasing
   
   
   ## Are these changes tested?
   I tested it manually to publish previously approved releases
   - https://dist.apache.org/repos/dist/release/datafusion/datafusion-43.0.0/
   - https://dist.apache.org/repos/dist/release/datafusion/datafusion-44.0.0/
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add publishing datafusion-sqllogictest to release README.md [datafusion]

Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 merged PR #14233:
URL: https://github.com/apache/datafusion/pull/14233


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Minor: Add publishing datafusion-sqllogictest to release README.md [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #14233:
URL: https://github.com/apache/datafusion/pull/14233#discussion_r1925313432


##########
datafusion/sqllogictest/Cargo.toml:
##########
@@ -17,6 +17,7 @@
 
 [package]
 authors = { workspace = true }
+description = "DataFusion sqllogictest driver"

Review Comment:
   Without this field publishing to crates.io failed like:
   
   ```
   error: failed to publish to registry at https://crates.io
   
   Caused by:
     the remote server responded with an error (status 400 Bad Request): missing or empty metadata fields: description. Please see https://doc.rust-lang.org/cargo/reference/manifest.html for more information on configuring these fields
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org