You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/04/06 12:45:57 UTC
[GitHub] [arrow] rtpsw opened a new pull request, #34931: GH-34930: [C++] Standardize aggregation column order
rtpsw opened a new pull request, #34931:
URL: https://github.com/apache/arrow/pull/34931
See #34930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1499012164
:warning: GitHub issue #34930 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1509117871
> and I haven't heard back from you. I am going to merge this. If you have some requests for changes we can address as follow up.
That's fine. I'm sorry I didn't get to this earlier. I've been heads down this week on resolving 12.0.0 blockers and fallen behind on some reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1508871382
@westonpace Since this is a pretty straight forward change and this has been agreed on in the issue:
https://github.com/apache/arrow/issues/34908#issuecomment-1500355286
and I haven't heard back from you. I am going to merge this. If you have some requests for changes we can address as follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1510745238
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/81eb4f2025a3492ea594fa0566aa14ba...a843c2986c774739b2bea9e5481729f4/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1499011983
cc @icexelloss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1503434509
Gentle ping @westonpace - can you please take a look if you have time? (in case you missed this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1499012047
* Closes: #34930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1510744791
Benchmark runs are scheduled for baseline = 3f5457df8e6646f26834280baeb3d485aaad3320 and contender = 5c73973a23deb68bef75be8acd743763307ac12f. 5c73973a23deb68bef75be8acd743763307ac12f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7a9a4d94dbd04311a4d7853ea70648b4...0afd05de07874a6ea791abd139fcf2a2/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/607e515c51c942c9b91dc7f98df94e41...99e5514b5b9c4ee5b8d4e4847479ef73/)
[Finished :arrow_down:8.93% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/81eb4f2025a3492ea594fa0566aa14ba...a843c2986c774739b2bea9e5481729f4/)
[Finished :arrow_down:0.25% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2195f9d6310b485bb5a0b915626885ac...d358c47f9c164f55bcfedd6cd7cecbfd/)
Buildkite builds:
[Finished] [`5c73973a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2717)
[Failed] [`5c73973a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2751)
[Finished] [`5c73973a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2715)
[Finished] [`5c73973a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2742)
[Finished] [`3f5457df` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2716)
[Failed] [`3f5457df` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2750)
[Finished] [`3f5457df` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2714)
[Finished] [`3f5457df` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2741)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss commented on pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss commented on PR #34931:
URL: https://github.com/apache/arrow/pull/34931#issuecomment-1501803984
@westonpace This one looks good to me. Let me know if this looks good to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] icexelloss merged pull request #34931: GH-34930: [C++] Standardize aggregation column order
Posted by "icexelloss (via GitHub)" <gi...@apache.org>.
icexelloss merged PR #34931:
URL: https://github.com/apache/arrow/pull/34931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org