You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by dgkimura <gi...@git.apache.org> on 2017/02/15 21:06:54 UTC
[GitHub] geode-native pull request #12: GEODE-2309: Remove or ignore apache-rat flagg...
GitHub user dgkimura opened a pull request:
https://github.com/apache/geode-native/pull/12
GEODE-2309: Remove or ignore apache-rat flagged files
`resolv.config` used to work around Solaris SPARC networking issues on a local OpenStack instance. It should not be needed going forward.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dgkimura/geode-native feature/GEODE-2309
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode-native/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 8d29d42869b4df5a83ef83c8e2c8992074b378ef
Author: David Kimura <dk...@pivotal.io>
Date: 2017-02-15T20:58:33Z
GEODE-2309: Remove or ignore apache-rat flagged files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #12: GEODE-2309: Remove or ignore apache-rat flagg...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode-native/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #12: GEODE-2309: Remove or ignore apache-rat flagg...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/12#discussion_r101671763
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
# expect script
.*changepasswd$
+.*winrm.cloud-init$
# doxygen
.*package-list$
.*testframeworkdox.txt$
+docs
--- End diff --
Hmm.. ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #12: GEODE-2309: Remove or ignore apache-rat flagg...
Posted by pivotal-jbarrett <gi...@git.apache.org>.
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/12#discussion_r101658884
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
# expect script
.*changepasswd$
+.*winrm.cloud-init$
# doxygen
.*package-list$
.*testframeworkdox.txt$
+docs
--- End diff --
This will match any file with "docs" in it. Seems like a rather greedy regex.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode-native pull request #12: GEODE-2309: Remove or ignore apache-rat flagg...
Posted by dgkimura <gi...@git.apache.org>.
Github user dgkimura commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/12#discussion_r101664490
--- Diff: .ratignore ---
@@ -23,10 +23,12 @@
# expect script
.*changepasswd$
+.*winrm.cloud-init$
# doxygen
.*package-list$
.*testframeworkdox.txt$
+docs
--- End diff --
Good point.
However, I tested that this seems to work. I created a file `somedocs` and `docsblah`, both without licenses. When I ran `rat` it flagged both of those files, which would make it seem like it doesn't treat this change as a regex?
I couldn't seem to find apache-rat documentation for their regex. If you know where they are could you point me to them?
`$ java -jar ~/tools/apache-rat-0.12/apache-rat-0.12.jar --dir . --exclude-file .ratignore`
```
*****************************************************
Printing headers for text files without a valid license header...
=====================================================
== File: ./docsblah
=====================================================
no license
=====================================================
== File: ./somedocs
=====================================================
no license
=====================================================
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---