You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by rm...@apache.org on 2021/06/18 16:35:26 UTC
[ranger] branch master updated: Improve logging in Presto plugin
This is an automated email from the ASF dual-hosted git repository.
rmani pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ranger.git
The following commit(s) were added to refs/heads/master by this push:
new f0f1877 Improve logging in Presto plugin
f0f1877 is described below
commit f0f1877c08a2c92d6de537121106da7decdd5343
Author: Naoki Takezoe <ta...@gmail.com>
AuthorDate: Tue Jan 12 00:11:00 2021 +0900
Improve logging in Presto plugin
Signed-off-by: Asha Ramesh <as...@Ashas-MacBook-Air-2.local>
---
.../org/apache/ranger/services/presto/RangerServicePresto.java | 8 ++++----
.../org/apache/ranger/services/presto/client/PrestoClient.java | 10 +++++-----
.../ranger/services/presto/client/PrestoResourceManager.java | 10 +++++-----
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java b/plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java
index d95876a..164b8f9 100644
--- a/plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java
+++ b/plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java
@@ -83,7 +83,7 @@ public class RangerServicePresto extends RangerBaseService {
}
ret = PrestoResourceManager.connectionTest(serviceName, configs);
} catch (HadoopException he) {
- LOG.error("<== RangerServicePresto.validateConfig Error:" + he);
+ LOG.error("<== RangerServicePresto.validateConfig() Error:" + he);
throw he;
}
}
@@ -103,7 +103,7 @@ public class RangerServicePresto extends RangerBaseService {
String serviceType = getServiceType();
Map<String,String> configs = getConfigs();
if(LOG.isDebugEnabled()) {
- LOG.debug("==> RangerServiceHive.lookupResource Context: (" + context + ")");
+ LOG.debug("==> RangerServicePresto.lookupResource() Context: (" + context + ")");
}
if (context != null) {
try {
@@ -112,12 +112,12 @@ public class RangerServicePresto extends RangerBaseService {
}
ret = PrestoResourceManager.getPrestoResources(serviceName, serviceType, configs,context);
} catch (Exception e) {
- LOG.error( "<==RangerServicePresto.lookupResource Error : " + e);
+ LOG.error( "<==RangerServicePresto.lookupResource() Error : " + e);
throw e;
}
}
if(LOG.isDebugEnabled()) {
- LOG.debug("<== RangerServicePresto.lookupResource Response: (" + ret + ")");
+ LOG.debug("<== RangerServicePresto.lookupResource() Response: (" + ret + ")");
}
return ret;
}
diff --git a/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java b/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java
index 7b55b77..3529793 100644
--- a/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java
+++ b/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java
@@ -212,7 +212,7 @@ public class PrestoClient extends BaseClient implements Closeable {
try {
ret = getCatalogs(ndl, catList);
} catch (HadoopException he) {
- LOG.error("<== PrestoClient getCatalogList() :Unable to get the Database List", he);
+ LOG.error("<== PrestoClient.getCatalogList() :Unable to get the Database List", he);
throw he;
}
return ret;
@@ -294,7 +294,7 @@ public class PrestoClient extends BaseClient implements Closeable {
try {
ret = getSchemas(ndl, cats, shms);
} catch (HadoopException he) {
- LOG.error("<== PrestoClient getSchemaList() :Unable to get the Schema List", he);
+ LOG.error("<== PrestoClient.getSchemaList() :Unable to get the Schema List", he);
}
return ret;
}
@@ -377,7 +377,7 @@ public class PrestoClient extends BaseClient implements Closeable {
try {
ret = getTables(ndl, cats, shms, tbls);
} catch (HadoopException he) {
- LOG.error("<== PrestoClient getTableList() :Unable to get the Column List", he);
+ LOG.error("<== PrestoClient.getTableList() :Unable to get the Column List", he);
throw he;
}
return ret;
@@ -474,7 +474,7 @@ public class PrestoClient extends BaseClient implements Closeable {
try {
ret = getColumns(ndl, cats, shms, tbls, cols);
} catch (HadoopException he) {
- LOG.error("<== PrestoClient getColumnList() :Unable to get the Column List", he);
+ LOG.error("<== PrestoClient.getColumnList() :Unable to get the Column List", he);
throw he;
}
return ret;
@@ -503,7 +503,7 @@ public class PrestoClient extends BaseClient implements Closeable {
}
if (status) {
- String msg = "Connection test succesful";
+ String msg = "Connection test successful";
generateResponseDataMap(status, msg, msg, null, null, resp);
}
} catch (Exception e) {
diff --git a/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java b/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java
index 008bf0f..c9f3826 100644
--- a/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java
+++ b/plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java
@@ -41,18 +41,18 @@ public class PrestoResourceManager {
Map<String, Object> ret = null;
if (LOG.isDebugEnabled()) {
- LOG.debug("==> PrestoResourceMgr.connectionTest ServiceName: " + serviceName + "Configs" + configs);
+ LOG.debug("==> PrestoResourceManager.connectionTest() ServiceName: " + serviceName + " Configs: " + configs);
}
try {
ret = PrestoClient.connectionTest(serviceName, configs);
} catch (Exception e) {
- LOG.error("<== PrestoResourceManager.connectionTest Error: " + e);
+ LOG.error("<== PrestoResourceManager.connectionTest() Error: " + e);
throw e;
}
if (LOG.isDebugEnabled()) {
- LOG.debug("<== PrestoResourceManager.connectionTest Result : " + ret);
+ LOG.debug("<== PrestoResourceManager.connectionTest() Result : " + ret);
}
return ret;
@@ -75,7 +75,7 @@ public class PrestoResourceManager {
if (LOG.isDebugEnabled()) {
- LOG.debug("<== PrestoResourceMgr.getPrestoResources() UserInput: \"" + userInput + "\" resource : " + resource + " resourceMap: " + resourceMap);
+ LOG.debug("<== PrestoResourceMgr.getPrestoResources() UserInput: \"" + userInput + "\" resource : " + resource + " resourceMap: " + resourceMap);
}
if (userInput != null && resource != null) {
@@ -106,7 +106,7 @@ public class PrestoResourceManager {
try {
if (LOG.isDebugEnabled()) {
- LOG.debug("==> PrestoResourceMgr.getPrestoResources() UserInput: " + userInput + " configs: " + configs + " catalogList: " + catalogList + " tableList: "
+ LOG.debug("==> PrestoResourceManager.getPrestoResources() UserInput: \"" + userInput + "\" configs: " + configs + " catalogList: " + catalogList + " tableList: "
+ tableList + " columnList: " + columnList);
}