You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/02 01:47:10 UTC
[GitHub] [druid] vogievetsky opened a new pull request #10461: Web console: fix lookup edit dialog version setting
vogievetsky opened a new pull request #10461:
URL: https://github.com/apache/druid/pull/10461
This PR fixed a number of issues found in the console while testing for 0.20.0 release:
1. The lookup edit dialog is does not have a fallback state meaning that if someone edits a lookup with an old property (like `uri`) there is no way to see it. A fallback state was added
2. The lookup edit dialog version updater was not working properly
3. The datasource view does not surface query errors correctly
New lookup edit dialog with version fallback:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on pull request #10461: Web console: fix lookup edit dialog version setting
Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #10461:
URL: https://github.com/apache/druid/pull/10461#issuecomment-702498896
This seems to be legit failing the [web-console tests in Travis for the lookup edit dialog](https://travis-ci.org/github/apache/druid/jobs/732127771#L412)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on a change in pull request #10461: Web console: fix lookup edit dialog version setting
Posted by GitBox <gi...@apache.org>.
suneet-s commented on a change in pull request #10461:
URL: https://github.com/apache/druid/pull/10461#discussion_r498617177
##########
File path: web-console/src/components/form-json-selector/form-json-selector.tsx
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Button, ButtonGroup, FormGroup } from '@blueprintjs/core';
+import React from 'react';
+
+export type FormJsonTabs = 'form' | 'json';
+
+export interface FormJsonSelectorProps {
+ tab: FormJsonTabs;
+ onChange: (tab: FormJsonTabs) => void;
+}
+
+export const FormJsonSelector = React.memo(function FormJsonSelector(props: FormJsonSelectorProps) {
Review comment:
🤘 I like this component!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on pull request #10461: Web console: fix lookup edit dialog version setting
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on pull request #10461:
URL: https://github.com/apache/druid/pull/10461#issuecomment-703121790
Thank you for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky merged pull request #10461: Web console: fix lookup edit dialog version setting
Posted by GitBox <gi...@apache.org>.
vogievetsky merged pull request #10461:
URL: https://github.com/apache/druid/pull/10461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10461: Web console: fix lookup edit dialog version setting
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10461:
URL: https://github.com/apache/druid/pull/10461#issuecomment-702821149
Addresses #10436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org