You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2005/09/28 01:18:16 UTC
Re: svn commit: r291966 - in /maven/components/trunk/maven-embedder:
./ src/main/assembly/ src/main/java/org/apache/maven/embedder/ src/main/resources/META-INF/maven/
src/main/resources/META-INF/maven/org.apache.maven/ src/main/resources/META-INF/maven/org...
Yep, I'm aware of that. The OSGi seems the way to go for the eclipse
plugin, and there is an enhancement req on assembly already to learn to
merge some files.
Actually, I was asking about pom.properties and pom.xml that you
manually included?
- Brett
Jason van Zyl wrote:
>On Wed, 2005-09-28 at 08:54 +1000, Brett Porter wrote:
>
>
>>Is this a temporary solution?
>>
>>I'm a bit confused - why can't DRI find it from the maven-core JAR? If
>>it really needs to be reading the maven-embedder POM should that be made
>>to happen instead?
>>
>>
>
>I think this is working exactly in the same way the ant tasks are in
>that the assembly plugin throws away the META-INF/plexus/components.xml
>file. I see in the maven-ant-tasks that you have a hand rolled
>descriptor so I assumed you are doing this as I have too.
>
>Ideally I think the Eclipse plugin could be an OSGi bundle that could
>have the intact JARs or maybe the assembly plugin can be taught to
>process resources if necessary (I don't believe it does this, maybe I'm
>wrong) but for now I just wanted to make a single JAR and hand-bombing a
>components.xml seems to be the only way.
>
>
>
>>- Brett
>>
>>jvanzyl@apache.org wrote:
>>
>>
>>
>>>Author: jvanzyl
>>>Date: Tue Sep 27 07:42:04 2005
>>>New Revision: 291966
>>>
>>>URL: http://svn.apache.org/viewcvs?rev=291966&view=rev
>>>Log:
>>>o adding metadata needed by DefaultRuntimeInformation
>>>o adding required plexus component descriptors
>>>
>>>
>>>Added:
>>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/
>>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/
>>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/maven-core/
>>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/maven-core/pom.properties (with props)
>>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/maven-core/pom.xml (with props)
>>>
>>>
>>>
>>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r291966 - in /maven/components/trunk/maven-embedder:
./ src/main/assembly/ src/main/java/org/apache/maven/embedder/ src/main/resources/META-INF/maven/
src/main/resources/META-INF/maven/org.apache.maven/ src/main/resources/META-INF/maven/org...
Posted by Brett Porter <br...@apache.org>.
Jason van Zyl wrote:
>On Wed, 2005-09-28 at 09:18 +1000, Brett Porter wrote:
>
>
>>Yep, I'm aware of that. The OSGi seems the way to go for the eclipse
>>plugin, and there is an enhancement req on assembly already to learn to
>>merge some files.
>>
>>Actually, I was asking about pom.properties and pom.xml that you
>>manually included?
>>
>>
>
>The DefaultRuntimeInformation component doesn't like it if it doesn't
>exist. I think the information there can't hurt so I put it in. I
>definitely want not to have to hand bomb this piece of information.
>
>
It should be finding it from the classloader it is coming from - I think
it is just because it is missing the leading "/".
ie change:
resourceAsStream =
getClass().getClassLoader().getResourceAsStream(
"META-INF/maven/org.apache.maven/maven-core/pom.properties" );
to
resourceAsStream =
getClass().getClassLoader().getResourceAsStream(
"/META-INF/maven/org.apache.maven/maven-core/pom.properties" );
Can you see if that fixes the issue?
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r291966 -
in /maven/components/trunk/maven-embedder: ./
src/main/assembly/ src/main/java/org/apache/maven/embedder/
src/main/resources/META-INF/maven/
src/main/resources/META-INF/maven/org.apache.maven/ src/main/resources/META-INF/maven/org...
Posted by Jason van Zyl <ja...@maven.org>.
On Wed, 2005-09-28 at 09:18 +1000, Brett Porter wrote:
> Yep, I'm aware of that. The OSGi seems the way to go for the eclipse
> plugin, and there is an enhancement req on assembly already to learn to
> merge some files.
>
> Actually, I was asking about pom.properties and pom.xml that you
> manually included?
The DefaultRuntimeInformation component doesn't like it if it doesn't
exist. I think the information there can't hurt so I put it in. I
definitely want not to have to hand bomb this piece of information.
> - Brett
>
> Jason van Zyl wrote:
>
> >On Wed, 2005-09-28 at 08:54 +1000, Brett Porter wrote:
> >
> >
> >>Is this a temporary solution?
> >>
> >>I'm a bit confused - why can't DRI find it from the maven-core JAR? If
> >>it really needs to be reading the maven-embedder POM should that be made
> >>to happen instead?
> >>
> >>
> >
> >I think this is working exactly in the same way the ant tasks are in
> >that the assembly plugin throws away the META-INF/plexus/components.xml
> >file. I see in the maven-ant-tasks that you have a hand rolled
> >descriptor so I assumed you are doing this as I have too.
> >
> >Ideally I think the Eclipse plugin could be an OSGi bundle that could
> >have the intact JARs or maybe the assembly plugin can be taught to
> >process resources if necessary (I don't believe it does this, maybe I'm
> >wrong) but for now I just wanted to make a single JAR and hand-bombing a
> >components.xml seems to be the only way.
> >
> >
> >
> >>- Brett
> >>
> >>jvanzyl@apache.org wrote:
> >>
> >>
> >>
> >>>Author: jvanzyl
> >>>Date: Tue Sep 27 07:42:04 2005
> >>>New Revision: 291966
> >>>
> >>>URL: http://svn.apache.org/viewcvs?rev=291966&view=rev
> >>>Log:
> >>>o adding metadata needed by DefaultRuntimeInformation
> >>>o adding required plexus component descriptors
> >>>
> >>>
> >>>Added:
> >>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/
> >>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/
> >>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/maven-core/
> >>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/maven-core/pom.properties (with props)
> >>> maven/components/trunk/maven-embedder/src/main/resources/META-INF/maven/org.apache.maven/maven-core/pom.xml (with props)
> >>>
> >>>
> >>>
> >>>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
jvz.
Jason van Zyl
jason at maven.org
http://maven.apache.org
A party which is not afraid of letting culture,
business, and welfare go to ruin completely can
be omnipotent for a while.
-- Jakob Burckhardt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org