You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@bellsouth.net> on 2000/12/20 15:57:57 UTC
AP_CHARSET_EBCDIC broken
As Greg Stein mentioned, if APR defines it then it shouldn't be AP_.
Another issue is with the exports.c generation. exports.c thinks #if
should work, but it is #ifdef everywhere. Shouldn't the exports.c
generation recognize #if vs. #ifdef? exports.c won't compile without
editing now.
--
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
Re: AP_CHARSET_EBCDIC broken
Posted by rb...@covalent.net.
> Ummm, APR defines it too, but in arch/unix/apr_private.h.
>
> How about letting APR define APR_CHARSET_EBCDIC to 0 or 1 in apr.h,
> and Apache and apr-util can just use the APR_CHARSET_EBCDIC symbol?
> That seems simple enough.
>
> I'd need to change all the references again, but that is okay with me.
>
> Okay?
Go for it. :-)
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: AP_CHARSET_EBCDIC broken
Posted by Jeff Trawick <tr...@bellsouth.net>.
rbb@covalent.net writes:
> > As Greg Stein mentioned, if APR defines it then it shouldn't be AP_.
>
> APR doesn't define AP_CHARSET_EBCDIC. Apache defines it, but APR uses it,
> which is broken.
Ummm, APR defines it too, but in arch/unix/apr_private.h.
How about letting APR define APR_CHARSET_EBCDIC to 0 or 1 in apr.h,
and Apache and apr-util can just use the APR_CHARSET_EBCDIC symbol?
That seems simple enough.
I'd need to change all the references again, but that is okay with me.
Okay?
> > Another issue is with the exports.c generation. exports.c thinks #if
> > should work, but it is #ifdef everywhere. Shouldn't the exports.c
> > generation recognize #if vs. #ifdef? exports.c won't compile without
> > editing now.
>
> Yes, it should. Feel free to fix it.
If I make the change described above, this problem goes away.
--
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...
Re: AP_CHARSET_EBCDIC broken
Posted by rb...@covalent.net.
> As Greg Stein mentioned, if APR defines it then it shouldn't be AP_.
APR doesn't define AP_CHARSET_EBCDIC. Apache defines it, but APR uses it,
which is broken.
> Another issue is with the exports.c generation. exports.c thinks #if
> should work, but it is #ifdef everywhere. Shouldn't the exports.c
> generation recognize #if vs. #ifdef? exports.c won't compile without
> editing now.
Yes, it should. Feel free to fix it.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------