You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "stack (JIRA)" <ji...@apache.org> on 2007/12/21 08:30:43 UTC
[jira] Created: (HADOOP-2479) [hbase] Save on number of Text object
creations
[hbase] Save on number of Text object creations
-----------------------------------------------
Key: HADOOP-2479
URL: https://issues.apache.org/jira/browse/HADOOP-2479
Project: Hadoop
Issue Type: Improvement
Components: contrib/hbase
Reporter: stack
Priority: Minor
Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2479) [hbase] Save on number of Text object
creations
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2479:
--------------------------
Status: In Progress (was: Patch Available)
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2479) [hbase] Save on number of Text object
creations
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2479:
--------------------------
Attachment: p-3.patch
Fix embarrassing fail in my own unit test (lesson: don't make last minute changes before submitting patch)
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch, p-3.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2479) [hbase] Save on number of Text object
creations
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2479:
--------------------------
Fix Version/s: 0.16.0
Status: Patch Available (was: Open)
Builds and passes tests locally. Trying hudson.
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-2479) [hbase] Save on number of Text
object creations
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HADOOP-2479:
-----------------------------
Assignee: stack
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2479) [hbase] Save on number of Text object
creations
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2479:
--------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed. Resolving.
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch, p-3.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2479) [hbase] Save on number of Text object
creations
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2479:
--------------------------
Attachment: p-2.patch
Profiling shows us creating lots of short-lived Text objects particularly looking at column families during updates, deletes, etc.
Here is commit message:
A src/contrib/hbase/src/test/org/apache/hadoop/hbase/io/TestTextSequence.java
Tests for new TextSequence class.
M src/contrib/hbase/src/test/org/apache/hadoop/hbase/PerformanceEvaluation.java
Especially during mapfile tests, the generation of value and key were
consuming lots of cpu. Refactor so uses less.
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStore.java
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HAbstractScanner.java
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HRegion.java
Changes to address new behavior of HSK.extractFamily.
M src/contrib/hbase/src/java/org/apache/hadoop/hbase/HStoreKey.java
Move static utility to the end. Change extractFamily to return
TextSequence.
A src/contrib/hbase/src/java/org/apache/hadoop/hbase/io/TextSequence.java
New TextSequence class: As CharSequence is to String, so is
TextSequence to Text (sort-of).
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Attachments: p-2.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2479) [hbase] Save on number of Text
object creations
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553907 ]
Hadoop QA commented on HADOOP-2479:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12372068/p-2.patch
against trunk revision r606058.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests -1. The patch failed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1416/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1416/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1416/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1416/console
This message is automatically generated.
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2479) [hbase] Save on number of Text
object creations
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554041 ]
Hadoop QA commented on HADOOP-2479:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12372101/p-3.patch
against trunk revision r606297.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1421/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1421/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1421/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1421/console
This message is automatically generated.
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch, p-3.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2479) [hbase] Save on number of Text object
creations
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HADOOP-2479:
--------------------------
Status: Patch Available (was: In Progress)
Give new patch to hudson.
> [hbase] Save on number of Text object creations
> -----------------------------------------------
>
> Key: HADOOP-2479
> URL: https://issues.apache.org/jira/browse/HADOOP-2479
> Project: Hadoop
> Issue Type: Improvement
> Components: contrib/hbase
> Reporter: stack
> Assignee: stack
> Priority: Minor
> Fix For: 0.16.0
>
> Attachments: p-2.patch, p-3.patch
>
>
> Save on number of Text object creations by using new TextSequence, particularly where the instances are short-lived.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.