You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2013/04/16 16:47:58 UTC
Review Request: Fix for SQOOP-988
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10549/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Description
-------
Changes to write a message about the validation being performed and on successful validation, a message that validation was successful
Diffs
-----
src/java/com/cloudera/sqoop/mapreduce/JobBase.java b89612d
src/java/org/apache/sqoop/validation/RowCountValidator.java ca21232
Diff: https://reviews.apache.org/r/10549/diff/
Testing
-------
Ran all tests and also some validation tests. Output similar to the following will be provided for validation
13/04/16 07:28:21 INFO mapreduce.JobBase: Validating the integrity of the import using the following configuration
Validator : org.apache.sqoop.validation.RowCountValidator
Threshold Specifier : org.apache.sqoop.validation.AbsoluteValidationThreshold
Failure Handler : org.apache.sqoop.validation.AbortOnFailureHandler
13/04/16 07:28:21 INFO validation.RowCountValidator: Data successfully validated
Thanks,
Venkat Ranganathan
Re: Review Request: Fix for SQOOP-988
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10549/#review19252
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On April 16, 2013, 2:47 p.m., Venkat Ranganathan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10549/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 2:47 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Description
> -------
>
> Changes to write a message about the validation being performed and on successful validation, a message that validation was successful
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/mapreduce/JobBase.java b89612d
> src/java/org/apache/sqoop/validation/RowCountValidator.java ca21232
>
> Diff: https://reviews.apache.org/r/10549/diff/
>
>
> Testing
> -------
>
> Ran all tests and also some validation tests. Output similar to the following will be provided for validation
>
> 13/04/16 07:28:21 INFO mapreduce.JobBase: Validating the integrity of the import using the following configuration
> Validator : org.apache.sqoop.validation.RowCountValidator
> Threshold Specifier : org.apache.sqoop.validation.AbsoluteValidationThreshold
> Failure Handler : org.apache.sqoop.validation.AbortOnFailureHandler
>
> 13/04/16 07:28:21 INFO validation.RowCountValidator: Data successfully validated
>
>
> Thanks,
>
> Venkat Ranganathan
>
>