You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "liubao68 (GitHub)" <gi...@apache.org> on 2018/08/25 02:38:39 UTC

[GitHub] [incubator-servicecomb-java-chassis] liubao68 opened pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Follow this checklist to help us incorporate your contribution quickly and easily:

 - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
 - [ ] Each commit in the pull request should have a meaningful subject line and body.
 - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
 - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
 - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
 - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

---


[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
added

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] wujimin commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "wujimin (GitHub)" <gi...@apache.org>.
better to make loadBalancer statless
1.invoke discoveryTree before getOrCreateLoadBalancer
2.getOrCreateLoadBalancer
3.send or sendWithRetry with server list
  chooseServer with server list
  create RetryLoadBalancer instance with server list

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 commented on issue #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
1. refactor to RuleExt
2. fix a bug required=true that int will have default value
3. This commit is a initial commit, I am going to add more tests 

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] coveralls commented on issue #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "coveralls (GitHub)" <gi...@apache.org>.
[![Coverage Status](https://coveralls.io/builds/18665826/badge)](https://coveralls.io/builds/18665826)

Coverage decreased (-0.02%) to 86.156% when pulling **789ab3e47568eda9d53bc2dc1e110d762c6e0e03 on liubao68:empty_param** into **ea17cca3e2e35a2f2b779533189f242b0b1f9324 on apache:master**.


[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 closed pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
[ pull request closed by liubao68 ]

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] wujimin commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "wujimin (GitHub)" <gi...@apache.org>.
avg result better to be double

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
权重算法就是这样的。对我们的场景，这个计算量很少，以及过滤掉不可用实例了。 即使200实例，这个算法复杂度也很低。

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] coveralls commented on issue #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "coveralls (GitHub)" <gi...@apache.org>.
[![Coverage Status](https://coveralls.io/builds/18664795/badge)](https://coveralls.io/builds/18664795)

Coverage decreased (-0.02%) to 86.158% when pulling **59e39869ebd413fbc18c86ab9a2ad5f82adf53d9 on liubao68:empty_param** into **ea17cca3e2e35a2f2b779533189f242b0b1f9324 on apache:master**.


[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] coveralls commented on issue #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "coveralls (GitHub)" <gi...@apache.org>.
[![Coverage Status](https://coveralls.io/builds/18663835/badge)](https://coveralls.io/builds/18663835)

Coverage decreased (-0.01%) to 86.169% when pulling **c1ab6c5be36681b590d6813330fd58d826f95deb on liubao68:empty_param** into **ea17cca3e2e35a2f2b779533189f242b0b1f9324 on apache:master**.


[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
权重算法就是这样的。对我们的场景，这个计算量很少，以及过滤掉不可用实例了。 即使200实例，这个算法复杂度也很低。比原来的Robin的WeightedResonseTimeRule要快，它的计算量更多。而且现在还省去了timer的后台计算。 现在是简单权重算法，来换取可靠性，不追求权重的精确性。 

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
Now the extension point is ExtensionsFactory, not RuleExt. Maybe we can work RuleExt based on SPI in future, now no need to give so many extension points. 

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
Now the extension point is ExtensionsFactory, not RuleExt.

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] jeho0815 commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "jeho0815 (GitHub)" <gi...@apache.org>.
每次都进行重新计算，如果server很多的时候，会影响性能吧

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] wujimin commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "wujimin (GitHub)" <gi...@apache.org>.
support SPI?
and use a map to manage them?

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] coveralls commented on issue #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "coveralls (GitHub)" <gi...@apache.org>.
[![Coverage Status](https://coveralls.io/builds/18664880/badge)](https://coveralls.io/builds/18664880)

Coverage decreased (-0.03%) to 86.151% when pulling **b232f78b28e9772c056cba5bb82b8f472c5c38cf on liubao68:empty_param** into **ea17cca3e2e35a2f2b779533189f242b0b1f9324 on apache:master**.


[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] liubao68 closed pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "liubao68 (GitHub)" <gi...@apache.org>.
[ pull request closed by liubao68 ]

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] wujimin commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "wujimin (GitHub)" <gi...@apache.org>.
calc weight for every invocation is not a good idea

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [incubator-servicecomb-java-chassis] wujimin commented on pull request #883: [SBC-870]refactor to using custom RuleExt, not using Robin IRule.

Posted by "wujimin (GitHub)" <gi...@apache.org>.
it's better to check if customers being using old policy configuration, and tell them how to switch to new mechanism
check can be done when init, not when handle
currently maybe init method not invoked.

[ Full content available at: https://github.com/apache/incubator-servicecomb-java-chassis/pull/883 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org