You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/12/08 06:40:38 UTC
[GitHub] [apisix] zuiyangqingzhou commented on a change in pull request #5728: refine the ua-restriction plugin configuration checksum logic
zuiyangqingzhou commented on a change in pull request #5728:
URL: https://github.com/apache/apisix/pull/5728#discussion_r764585950
##########
File path: apisix/plugins/ua-restriction.lua
##########
@@ -34,11 +35,11 @@ local schema = {
type = "boolean",
default = false,
},
- allowlist = {
+ allow_list = {
type = "array",
minItems = 1
},
- denylist = {
+ deny_list = {
Review comment:
Oh, I just don't think it's in line with the variable naming specification, and if the scope of the impact is too great, I'll change it back @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org