You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Pavel Pereslegin (Jira)" <ji...@apache.org> on 2020/04/16 15:08:00 UTC
[jira] [Comment Edited] (IGNITE-12888) Add support for ConstantName
to checkstyle rules
[ https://issues.apache.org/jira/browse/IGNITE-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084960#comment-17084960 ]
Pavel Pereslegin edited comment on IGNITE-12888 at 4/16/20, 3:07 PM:
---------------------------------------------------------------------
[~mmuzaf],
I think this rule may violate the Ignite coding convention:
"_{color:#172b4d}Constants ({color}*final*{color:#172b4d} class attributes that have *constant semantic* and *not just made final* *because* of inner class access or *performance considerations*) should all be upper-case.{color}_"
I'm pretty sure that this checkstyle rule cannot take into account the semantics of using each of the "static final" field. Right?
was (Author: xtern):
[~mmuzaf],
I think this rule may violate the Ignite coding convention:
"_{color:#172b4d}Constants ({color}*final*{color:#172b4d} class attributes that have *constant semantic* and *not just made final* *because* of inner class access or *performance considerations*) should all be upper-case.{color}_"
I'm pretty sure that this checkstyle rule cannot take into account the semantics of using each "static final" field. Right?
> Add support for ConstantName to checkstyle rules
> ------------------------------------------------
>
> Key: IGNITE-12888
> URL: https://issues.apache.org/jira/browse/IGNITE-12888
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Major
> Fix For: 2.9
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add a new rule to checkstyle according to Apache Ignite naming conventions.
> <module name="ConstantName"/>
> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-Naming
--
This message was sent by Atlassian Jira
(v8.3.4#803005)