You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/13 20:32:05 UTC
[GitHub] [camel] bvahdat opened a new pull request #4211: fix the broken mvn sourcecheck step in build
bvahdat opened a new pull request #4211:
URL: https://github.com/apache/camel/pull/4211
See https://github.com/apache/camel/runs/1109005262
[x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #4211: fix the broken mvn sourcecheck step in build
Posted by GitBox <gi...@apache.org>.
bvahdat commented on pull request #4211:
URL: https://github.com/apache/camel/pull/4211#issuecomment-691726019
O.K I found the root cause and managed to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] asfgit merged pull request #4211: fix the broken mvn sourcecheck step in build
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #4211:
URL: https://github.com/apache/camel/pull/4211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bvahdat commented on pull request #4211: fix the broken mvn sourcecheck step in build
Posted by GitBox <gi...@apache.org>.
bvahdat commented on pull request #4211:
URL: https://github.com/apache/camel/pull/4211#issuecomment-691724245
Ah sorry, I just fixed the following warning:
```
[WARNING] The project org.apache.camel:camel:pom:3.6.0-SNAPSHOT uses prerequisites which is only intended for maven-plugin projects but not for non maven-plugin projects. For such purposes you should use the maven-enforcer-plugin. See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
```
But the main problem breaking this step is the following error I've got no clue about:
```
2020-09-13T20:45:10.7839063Z [ERROR] Failed to execute goal org.apache.camel:camel-format-plugin:3.6.0-SNAPSHOT:validate (validate) on project camel-aws2-s3: File '/home/runner/work/camel/camel/components/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Consumer.java' has not been previously formatted. Please format file and commit before running validation! -> [Help 1]
```
Seems somehow to be relevant with `camel-format-plugin` and revelc's `impsort-maven-plugin`. The error message comes from the following PR:
https://github.com/revelc/formatter-maven-plugin/issues/172
@gnodet do you maybe know what the root cause of the problem could be?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org