You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "sstojak1 (via GitHub)" <gi...@apache.org> on 2024/10/31 19:15:27 UTC
[PR] Add missing migration script to register.go [incubator-devlake]
sstojak1 opened a new pull request, #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes.
Please fill out as many sections below as possible.
-->
### Summary
What does this PR do?
Adds increaseProjectKeyLength and changeIssueComponentType to register.go
### Does this close any open issues?
Closes [#8177](https://github.com/apache/incubator-devlake/issues/8177)
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178#issuecomment-2456323685
@sstojak1 Could you fix the test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "sstojak1 (via GitHub)" <gi...@apache.org>.
sstojak1 commented on PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178#issuecomment-2454455023
@klesh can we merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "sstojak1 (via GitHub)" <gi...@apache.org>.
sstojak1 commented on PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178#issuecomment-2456936280
@klesh, 20240813_change_issue_component_type is fixed. Could you run the tests again?
Before that, could you review the 20240813_increase_project_key_length script? It might fail since the project_key column doesn’t exist in cq_projects. Did you intend to modify a different column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178#issuecomment-2458558946
@sstojak1 I just checked the code and found out `20240813_increase_project_key_length` under the `core/model` should be changing the length of `cq_projects.id` from 255 to 500 instead.
Would you kindly update the script to do so? Thanks, 🌹
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178#issuecomment-2463920267
@sstojak1 Thank you very much for correcting my mistakes 🌹
I wondered why people kept reporting "Data too long" after my PR merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "sstojak1 (via GitHub)" <gi...@apache.org>.
sstojak1 commented on PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178#issuecomment-2463904401
@klesh updated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "sstojak1 (via GitHub)" <gi...@apache.org>.
sstojak1 commented on PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178#issuecomment-2463923956
I was almost one of them until I did a bit of troubleshooting 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add missing migration script to register.go [incubator-devlake]
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh merged PR #8178:
URL: https://github.com/apache/incubator-devlake/pull/8178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org