[GitHub] [hop] hansva commented on a diff in pull request #1896: XML cleanup

[GitBox <gi...@apache.org>]

hansva commented on code in PR #1896:
URL: https://github.com/apache/hop/pull/1896#discussion_r1039817477


##########
plugins/actions/setvariables/src/test/java/org/apache/hop/workflow/actions/setvariables/WorkflowEntrySetVariablesTest.java:
##########
@@ -46,10 +46,7 @@
 import java.io.RandomAccessFile;
 import java.nio.charset.StandardCharsets;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import static org.junit.Assert.*;

Review Comment:
   star import introduced



##########
plugins/transforms/replacestring/src/test/java/org/apache/hop/pipeline/transforms/replacestring/ReplaceStringTest.java:
##########
@@ -36,10 +34,7 @@
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.anyObject;
 import static org.mockito.Matchers.anyString;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.never;
-import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.*;

Review Comment:
   star import



##########
core/src/main/java/org/apache/hop/core/Const.java:
##########
@@ -30,8 +30,7 @@
 import org.apache.hop.core.variables.VariableScope;
 import org.apache.hop.i18n.BaseMessages;
 
-import java.awt.Font;
-import java.awt.GraphicsEnvironment;
+import java.awt.*;

Review Comment:
   Star import introduced



##########
plugins/transforms/reservoirsampling/src/test/java/org/apache/hop/pipeline/transforms/reservoirsampling/ReservoirSamplingMetaTest.java:
##########
@@ -13,39 +13,27 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
+ *
  */
 
 package org.apache.hop.pipeline.transforms.reservoirsampling;
 
-import org.apache.hop.core.exception.HopException;
-import org.apache.hop.junit.rules.RestoreHopEngineEnvironment;
-import org.apache.hop.pipeline.transforms.loadsave.LoadSaveTester;
-import org.junit.ClassRule;
+import org.apache.hop.pipeline.transform.TransformSerializationTestUtil;
+import org.junit.Assert;
 import org.junit.Test;
 
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
+import static org.junit.Assert.*;

Review Comment:
   star import



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org