You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/12/26 07:33:00 UTC

[GitHub] [skywalking] mrproliu opened a new pull request #4133: provide config stream processor

mrproliu opened a new pull request #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #4104 
   
   ### New feature or improvement
   - Provide a new stream processor, because when I create the thread monitor task, need storage similar to inventory and support TTL deletion mode similar to the record.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mrproliu commented on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569171077
 
 
   > So, is `Thread Monitor Task Segment snapshot` a `Config`?
   
   No, It will create base on `Record`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 merged pull request #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] kezhenxu94 commented on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569080895
 
 
   > * Provide a new stream processor, because when I create the thread monitor task, need storage similar to inventory and support TTL deletion mode similar to the record.
   
   @mrproliu Does the configs need TTL and why?
   
   As you wrote in #4144 , monitoring tasks are stored in the inventory here, I suppose the tasks are created by users in the web UI right? So why they should be deleted after a so-called TTL? Does the users expect this? Is it designed for so?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io commented on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569076459
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@4aac329`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4133/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4133   +/-   ##
   =========================================
     Coverage          ?   27.18%           
   =========================================
     Files             ?     1145           
     Lines             ?    25100           
     Branches          ?     3629           
   =========================================
     Hits              ?     6824           
     Misses            ?    17670           
     Partials          ?      606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...er/core/analysis/worker/ConfigStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0NvbmZpZ1N0cmVhbVByb2Nlc3Nvci5qYXZh) | `0% <0%> (ø)` | |
   | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0% <0%> (ø)` | |
   | [...r/core/analysis/worker/ConfigPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL0NvbmZpZ1BlcnNpc3RlbnRXb3JrZXIuamF2YQ==) | `0% <0%> (ø)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `0% <0%> (ø)` | |
   | [...orage/plugin/elasticsearch7/dao/StorageEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vU3RvcmFnZUVzN0RBTy5qYXZh) | `0% <0%> (ø)` | |
   | [...erver/storage/plugin/jdbc/h2/dao/H2StorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyU3RvcmFnZURBTy5qYXZh) | `0% <0%> (ø)` | |
   | [...storage/plugin/elasticsearch/base/ConfigEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Db25maWdFc0RBTy5qYXZh) | `0% <0%> (ø)` | |
   | [...server/storage/plugin/jdbc/h2/dao/H2ConfigDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyQ29uZmlnREFPLmphdmE=) | `0% <0%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=footer). Last update [4aac329...5ba093b](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569076459
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=h1) Report
   > Merging [#4133](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9415f681271518fe6836aebbb27fc696627b612d?src=pr&el=desc) will **decrease** coverage by `0.04%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4133/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4133      +/-   ##
   ==========================================
   - Coverage   27.17%   27.13%   -0.05%     
   ==========================================
     Files        1141     1145       +4     
     Lines       25057    25100      +43     
     Branches     3625     3629       +4     
   ==========================================
     Hits         6810     6810              
   - Misses      17644    17687      +43     
     Partials      603      603
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...re/analysis/worker/NoneStreamPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1QZXJzaXN0ZW50V29ya2VyLmphdmE=) | `0% <0%> (ø)` | |
   | [...r/core/analysis/worker/NoneStreamingProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1pbmdQcm9jZXNzb3IuamF2YQ==) | `0% <0%> (ø)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...orage/plugin/elasticsearch7/dao/StorageEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vU3RvcmFnZUVzN0RBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...erver/storage/plugin/jdbc/h2/dao/H2StorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyU3RvcmFnZURBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...er/storage/plugin/jdbc/h2/dao/H2NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTm9uZVN0cmVhbURBTy5qYXZh) | `0% <0%> (ø)` | |
   | [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `0% <0%> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=footer). Last update [9415f68...cab0750](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mrproliu commented on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569182776
 
 
   @wu-sheng All issue has been resolved.
   please have a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] codecov-io edited a comment on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569076459
 
 
   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=h1) Report
   > Merging [#4133](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/9415f681271518fe6836aebbb27fc696627b612d?src=pr&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/4133/graphs/tree.svg?width=650&token=qrILxY5yA8&height=150&src=pr)](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #4133      +/-   ##
   ==========================================
   - Coverage   27.26%   27.18%   -0.08%     
   ==========================================
     Files        1141     1145       +4     
     Lines       25057    25100      +43     
     Branches     3625     3629       +4     
   ==========================================
   - Hits         6831     6824       -7     
   - Misses      17620    17670      +50     
     Partials      606      606
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
   | [...re/analysis/worker/NoneStreamPersistentWorker.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1QZXJzaXN0ZW50V29ya2VyLmphdmE=) | `0% <0%> (ø)` | |
   | [...r/core/analysis/worker/NoneStreamingProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL05vbmVTdHJlYW1pbmdQcm9jZXNzb3IuamF2YQ==) | `0% <0%> (ø)` | |
   | [...server/core/analysis/StreamAnnotationListener.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtQW5ub3RhdGlvbkxpc3RlbmVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
   | [...orage/plugin/elasticsearch7/dao/StorageEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vU3RvcmFnZUVzN0RBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...erver/storage/plugin/jdbc/h2/dao/H2StorageDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyU3RvcmFnZURBTy5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
   | [...er/storage/plugin/jdbc/h2/dao/H2NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyTm9uZVN0cmVhbURBTy5qYXZh) | `0% <0%> (ø)` | |
   | [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `0% <0%> (ø)` | |
   | [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `29.16% <0%> (-25.01%)` | :arrow_down: |
   | [.../agent/core/context/trace/AbstractTracingSpan.java](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9BYnN0cmFjdFRyYWNpbmdTcGFuLmphdmE=) | `60.36% <0%> (-0.91%)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/4133/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=footer). Last update [9415f68...cab0750](https://codecov.io/gh/apache/skywalking/pull/4133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mrproliu commented on a change in pull request #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#discussion_r361567759
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/IConfigDAO.java
 ##########
 @@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage;
+
+import org.apache.skywalking.oap.server.core.analysis.config.Config;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+
+import java.io.IOException;
+
+/**
+ * @author MrPro
+ */
+public interface IConfigDAO extends DAO {
+
+    void insert(Model model, Config config) throws IOException;
 
 Review comment:
   No, It will only have the insert method, haven't other steps.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569160177
 
 
   > monitoring tasks are stored in the inventory here, I suppose the tasks are created by users in the web UI right? So why they should be deleted after a so-called TTL? Does the users expect this? Is it designed for so?
   
   Monitoring should be set by UI or GraphQL. But it isn't inventory, that is why we create a new type of streaming process. I think the point of deleting is the thread dump will be saved as a kind of record, similar to the segment. So even we don't set up TTL, it will miss all related thread dump data.
   I agree to support TTL.
   
   @mrproliu A reminder to you, as TTL setup based on time bucket, this field should be set based on task expected finish time, rather than config time. Because you need to avoid the task has been deleted before the task starts.
   
   Also, I notice, this task entity is not time series, why? Deleting is a big payload for the ES, I would recommend setup the time series for this too.
   
   ___
   
   ## Request rename
   `Config` is a very widely used concept. In the streaming process, a mode called config is very strange and not clear. I want to propose the processor name, `noneStreamingProcessor`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#discussion_r361471585
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/IConfigDAO.java
 ##########
 @@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage;
+
+import org.apache.skywalking.oap.server.core.analysis.config.Config;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+
+import java.io.IOException;
+
+/**
+ * @author MrPro
+ */
+public interface IConfigDAO extends DAO {
+
+    void insert(Model model, Config config) throws IOException;
 
 Review comment:
   Is this for step one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] arugal commented on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
arugal commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569169785
 
 
   So,  is `Thread Monitor Task Segment snapshot` a `Config`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] mrproliu commented on issue #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
mrproliu commented on issue #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#issuecomment-569170965
 
 
   > > monitoring tasks are stored in the inventory here, I suppose the tasks are created by users in the web UI right? So why they should be deleted after a so-called TTL? Does the users expect this? Is it designed for so?
   > 
   > Monitoring should be set by UI or GraphQL. But it isn't inventory, that is why we create a new type of streaming process. I think the point of deleting is the thread dump will be saved as a kind of record, similar to the segment. So even we don't set up TTL, it will miss all related thread dump data.
   > I agree to support TTL.
   > 
   > @mrproliu A reminder to you, as TTL setup based on time bucket, this field should be set based on task expected finish time, rather than config time. Because you need to avoid the task has been deleted before the task starts.
   > 
   > Also, I notice, this task entity is not time series, why? Deleting is a big payload for the ES, I would recommend setup the time series for this too.
   > 
   > ## Request rename
   > `Config` is a very widely used concept. In the streaming process, a mode called config is very strange and not clear. I want to propose the processor name, `noneStreamingProcessor`.
   
   I agree with all your suggestions. I will change that today.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4133: provide config stream processor

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4133: provide config stream processor
URL: https://github.com/apache/skywalking/pull/4133#discussion_r361471526
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/IConfigDAO.java
 ##########
 @@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage;
+
+import org.apache.skywalking.oap.server.core.analysis.config.Config;
+import org.apache.skywalking.oap.server.core.storage.model.Model;
+
+import java.io.IOException;
+
+/**
+ * @author MrPro
+ */
+public interface IConfigDAO extends DAO {
+
+    void insert(Model model, Config config) throws IOException;
 
 Review comment:
   Why not insert?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services