You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/05 21:47:12 UTC

[GitHub] [arrow] westonpace commented on a change in pull request #10255: ARROW-12661: [C++] Add ReaderOptions::skip_rows_after_names

westonpace commented on a change in pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#discussion_r626935893



##########
File path: cpp/src/arrow/csv/reader_test.cc
##########
@@ -216,5 +216,42 @@ TEST(StreamingReaderTests, NestedParallelism) {
   TestNestedParallelism(thread_pool, table_factory);
 }
 
+TEST(ReaderOptionsTests, SkipRowsAfterNames) {

Review comment:
       Can you add a test case where `autogenerate_column_names` is set to `true` (i.e. there is no header in the CSV file)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org