You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/05/07 22:50:35 UTC
Review Request 33955: Invoke pip as a python module rather than
directly.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33955/
-----------------------------------------------------------
Review request for Aurora, Brian Wickman and Zameer Manji.
Bugs: AURORA-1309
https://issues.apache.org/jira/browse/AURORA-1309
Repository: aurora
Description
-------
This is a workaround for https://github.com/pypa/pip/issues/1773
Diffs
-----
build-support/jenkins/build.sh 229fc9d78a06f5b3a284a60504e1a1e8b50e9233
build-support/pex 61fbc915dddc7c6048862548a3348811469131d7
build-support/python/checkstyle ee8c8d5ee4cf891a9a905e48d451bcd50611bdf4
build-support/python/isort 2f697bebb5375acfddf2e1a7170b92ab9be68393
build-support/python/make-pycharm-virtualenv 84dfb64386dd9cbbe1f0cd4bb71f762928a83912
build-support/python/update-pants-requirements ae210bc8ad1175e27f903c6fc66b41f6891b78d2
pants 9dd31881deb225ded87ce40b3c0985cdf2528f7e
rbt c14924954121eb03a37dfa75196fba025da4ff03
Diff: https://reviews.apache.org/r/33955/diff/
Testing
-------
TODO(wfarner): Report back results of end-to-end tests and invoking other tools manually.
Thanks,
Bill Farner
Re: Review Request 33955: Invoke pip as a python module rather than
directly.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33955/#review82906
-----------------------------------------------------------
Ship it!
Master (fef7194) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 7, 2015, 8:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33955/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1309
> https://issues.apache.org/jira/browse/AURORA-1309
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is a workaround for https://github.com/pypa/pip/issues/1773
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 229fc9d78a06f5b3a284a60504e1a1e8b50e9233
> build-support/pex 61fbc915dddc7c6048862548a3348811469131d7
> build-support/python/checkstyle ee8c8d5ee4cf891a9a905e48d451bcd50611bdf4
> build-support/python/isort 2f697bebb5375acfddf2e1a7170b92ab9be68393
> build-support/python/make-pycharm-virtualenv 84dfb64386dd9cbbe1f0cd4bb71f762928a83912
> build-support/python/update-pants-requirements ae210bc8ad1175e27f903c6fc66b41f6891b78d2
> pants 9dd31881deb225ded87ce40b3c0985cdf2528f7e
> rbt c14924954121eb03a37dfa75196fba025da4ff03
>
> Diff: https://reviews.apache.org/r/33955/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of end-to-end tests and invoking other tools manually.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33955: Invoke pip as a python module rather than
directly.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33955/
-----------------------------------------------------------
(Updated May 7, 2015, 9:18 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
reviewers -= wickman
Bugs: AURORA-1309
https://issues.apache.org/jira/browse/AURORA-1309
Repository: aurora
Description
-------
This is a workaround for https://github.com/pypa/pip/issues/1773
Diffs
-----
build-support/jenkins/build.sh 229fc9d78a06f5b3a284a60504e1a1e8b50e9233
build-support/pex 61fbc915dddc7c6048862548a3348811469131d7
build-support/python/checkstyle ee8c8d5ee4cf891a9a905e48d451bcd50611bdf4
build-support/python/isort 2f697bebb5375acfddf2e1a7170b92ab9be68393
build-support/python/make-pycharm-virtualenv 84dfb64386dd9cbbe1f0cd4bb71f762928a83912
build-support/python/update-pants-requirements ae210bc8ad1175e27f903c6fc66b41f6891b78d2
pants 9dd31881deb225ded87ce40b3c0985cdf2528f7e
rbt c14924954121eb03a37dfa75196fba025da4ff03
Diff: https://reviews.apache.org/r/33955/diff/
Testing (updated)
-------
```
vagrant destroy -f
git clean -fdx
./rbt
./build-support/python/make-pycharm-virtualenv
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
Bill Farner
Re: Review Request 33955: Invoke pip as a python module rather than
directly.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33955/#review82900
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On May 7, 2015, 1:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33955/
> -----------------------------------------------------------
>
> (Updated May 7, 2015, 1:50 p.m.)
>
>
> Review request for Aurora, Brian Wickman and Zameer Manji.
>
>
> Bugs: AURORA-1309
> https://issues.apache.org/jira/browse/AURORA-1309
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is a workaround for https://github.com/pypa/pip/issues/1773
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 229fc9d78a06f5b3a284a60504e1a1e8b50e9233
> build-support/pex 61fbc915dddc7c6048862548a3348811469131d7
> build-support/python/checkstyle ee8c8d5ee4cf891a9a905e48d451bcd50611bdf4
> build-support/python/isort 2f697bebb5375acfddf2e1a7170b92ab9be68393
> build-support/python/make-pycharm-virtualenv 84dfb64386dd9cbbe1f0cd4bb71f762928a83912
> build-support/python/update-pants-requirements ae210bc8ad1175e27f903c6fc66b41f6891b78d2
> pants 9dd31881deb225ded87ce40b3c0985cdf2528f7e
> rbt c14924954121eb03a37dfa75196fba025da4ff03
>
> Diff: https://reviews.apache.org/r/33955/diff/
>
>
> Testing
> -------
>
> TODO(wfarner): Report back results of end-to-end tests and invoking other tools manually.
>
>
> Thanks,
>
> Bill Farner
>
>