You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/08/18 08:07:04 UTC
[GitHub] [incubator-dolphinscheduler] yangxifi opened a new issue #3540: [Bug][api] There are annotation spelling errors in TaskRecordController
yangxifi opened a new issue #3540:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3540
1. detalis
name| about| title| labels| assignees|
---|---|---|---|---|
word spelling mistake|The word "numbere" should be "number"|[Bug][api] There are annotation spelling errors in TaskRecordController|bug|
2. screenshot as follows
3. code as follows
` /**
* query task record list page
*
* @param loginUser login user
* @param taskName task name
* @param state state
* @param sourceTable source table
* @param destTable destination table
* @param taskDate task date
* @param startTime start time
* @param endTime end time
* @param pageNo **page numbere**--->page number
* @param pageSize page size
* @return task record list
*/
@GetMapping("/list-paging")
@ResponseStatus(HttpStatus.OK)
@ApiException(QUERY_TASK_RECORD_LIST_PAGING_ERROR)
public Result queryTaskRecordListPaging(@ApiIgnore @RequestAttribute(value = Constants.SESSION_USER) User loginUser,
@RequestParam(value = "taskName", required = false) String taskName,
@RequestParam(value = "state", required = false) String state,
@RequestParam(value = "sourceTable", required = false) String sourceTable,
@RequestParam(value = "destTable", required = false) String destTable,
@RequestParam(value = "taskDate", required = false) String taskDate,
@RequestParam(value = "startDate", required = false) String startTime,
@RequestParam(value = "endDate", required = false) String endTime,
@RequestParam("pageNo") Integer pageNo,
@RequestParam("pageSize") Integer pageSize
) {
logger.info("query task record list, task name:{}, state :{}, taskDate: {}, start:{}, end:{}",
taskName, state, taskDate, startTime, endTime);
Map<String, Object> result = taskRecordService.queryTaskRecordListPaging(false, taskName, startTime, taskDate, sourceTable, destTable, endTime, state, pageNo, pageSize);
return returnDataListPaging(result);
}
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] yangyichao-mango commented on issue #3540: [Bug][api] There are annotation spelling errors in TaskRecordController
Posted by GitBox <gi...@apache.org>.
yangyichao-mango commented on issue #3540:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3540#issuecomment-675852921
Hi~
These is not a bug, it should be the improvement issue, please change the title. And welcome to submit a improvement pr to resolve it~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei closed issue #3540: [Bug][api] There are annotation spelling errors in TaskRecordController
Posted by GitBox <gi...@apache.org>.
qiaozhanwei closed issue #3540:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #3540: [Bug][api] There are annotation spelling errors in TaskRecordController
Posted by GitBox <gi...@apache.org>.
hermeshephaestus commented on issue #3540:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3540#issuecomment-703121360
OK, i will submit a pr to resolve it. @yangyichao-mango @yangxifi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] qiaozhanwei closed issue #3540: [Bug][api] There are annotation spelling errors in TaskRecordController
Posted by GitBox <gi...@apache.org>.
qiaozhanwei closed issue #3540:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org