You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/19 14:07:34 UTC
[GitHub] [incubator-superset] Caahlo opened a new pull request #8605: add
Liechtenstein to country selection
Caahlo opened a new pull request #8605: add Liechtenstein to country selection
URL: https://github.com/apache/incubator-superset/pull/8605
add Liechtenstein to country selection and document its municipalities as regions
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [x] Documentation
### SUMMARY
Add Liechtenstein to the documentation and to the country map drop-down menu
requires: apache-superset/superset-ui-plugins#263
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
![Screenshot (6)](https://user-images.githubusercontent.com/54531195/69153117-eab4f780-0add-11ea-98ef-880f17d1a792.png)
### TEST PLAN
1. Go to the charts list
2. Click on the "Birth in France by department in 2016" link
3. under "Options" in the "Country Name" drop-down menu, select "Liechtenstein"
#### Expected
The borders of the cantons of Liechtenstein should appear in pale gray.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org